From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Matt Weber <matthew.weber@collins.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl
Date: Sun, 29 Jan 2023 22:06:09 +0100 [thread overview]
Message-ID: <87edrd3vb2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230118210834.GM2770@scaer> (Yann E. MORIN's message of "Wed, 18 Jan 2023 22:08:34 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Fabrice, All,
> On 2023-01-18 18:37 +0100, Fabrice Fontaine spake thusly:
>> sftp doesn't build with libressl >= 3.5.0 resulting in the following
>> build failure since commit 8b216927db080b38fdbf1f8b025b6f90a89d4bc2:
>>
>> mac.c: In function 'init_mac':
>> mac.c:189:3: warning: implicit declaration of function
>> 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'?
>> [-Wimplicit-function-declaration]
>> 189 | HMAC_CTX_init(hmac_ctx);
>> | ^~~~~~~~~~~~~
>> | HMAC_CTX_new
>> mac.c: In function 'set_mac_key':
>> mac.c:435:14: error: storage size of 'ctx' isn't known
>> 435 | EVP_MD_CTX ctx;
>> | ^~~
>>
>> So disable sftp with libressl
> This, and the commit title, are misleading: sftp is not _disabled_ with
> libressl; if you had done that, then the code would have looked like:
> config BR2_PACKAGE_PROFTPD_MOD_SFTP
> bool "mod_sftp"
> depends on !BR2_PACKAGE_LIBRESSL
> Realy, what this change does, is to force use of openssl for sftp.
> So, I tweeaked the commit title and log to reflect that.
Committed to 2022.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-01-29 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 17:37 [Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl Fabrice Fontaine
2023-01-18 21:08 ` Yann E. MORIN
2023-01-29 21:06 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrd3vb2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=matthew.weber@collins.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox