[Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl

[Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl

[Fabrice Fontaine]

sftp doesn't build with libressl >= 3.5.0 resulting in the following
build failure since commit 8b216927db080b38fdbf1f8b025b6f90a89d4bc2:

mac.c: In function 'init_mac':
mac.c:189:3: warning: implicit declaration of function 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'? [-Wimplicit-function-declaration]
  189 |   HMAC_CTX_init(hmac_ctx);
      |   ^~~~~~~~~~~~~
      |   HMAC_CTX_new
mac.c: In function 'set_mac_key':
mac.c:435:14: error: storage size of 'ctx' isn't known
  435 |   EVP_MD_CTX ctx;
      |              ^~~

So disable sftp with libressl as no feedback was received on
https://github.com/proftpd/proftpd/pull/1481

Fixes:
 - http://autobuild.buildroot.org/results/a16ccd7cc78eb63de06a6d738fccc6b947da13e7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/proftpd/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/proftpd/Config.in b/package/proftpd/Config.in
index 83094028a0..aed1958b8d 100644
--- a/package/proftpd/Config.in
+++ b/package/proftpd/Config.in
@@ -29,7 +29,8 @@ config BR2_PACKAGE_PROFTPD_MOD_REDIS
 config BR2_PACKAGE_PROFTPD_MOD_SFTP
 	bool "mod_sftp support"
 	select BR2_PACKAGE_OPENSSL
-	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160 if BR2_PACKAGE_LIBOPENSSL
+	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160
 	help
 	  Compile ProFTPD with mod_sftp support
 
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl

[Yann E. MORIN]

Fabrice, All,

On 2023-01-18 18:37 +0100, Fabrice Fontaine spake thusly:
> sftp doesn't build with libressl >= 3.5.0 resulting in the following
> build failure since commit 8b216927db080b38fdbf1f8b025b6f90a89d4bc2:
> 
> mac.c: In function 'init_mac':
> mac.c:189:3: warning: implicit declaration of function 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'? [-Wimplicit-function-declaration]
>   189 |   HMAC_CTX_init(hmac_ctx);
>       |   ^~~~~~~~~~~~~
>       |   HMAC_CTX_new
> mac.c: In function 'set_mac_key':
> mac.c:435:14: error: storage size of 'ctx' isn't known
>   435 |   EVP_MD_CTX ctx;
>       |              ^~~
> 
> So disable sftp with libressl

This, and the commit title, are misleading: sftp is not _disabled_ with
libressl; if you had done that, then the code would have looked like:

    config BR2_PACKAGE_PROFTPD_MOD_SFTP
        bool "mod_sftp"
        depends on !BR2_PACKAGE_LIBRESSL

Realy, what this change does, is to force use of openssl for sftp.

So, I tweeaked the commit title and log to reflect that.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> as no feedback was received on
> https://github.com/proftpd/proftpd/pull/1481
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/a16ccd7cc78eb63de06a6d738fccc6b947da13e7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/proftpd/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/proftpd/Config.in b/package/proftpd/Config.in
> index 83094028a0..aed1958b8d 100644
> --- a/package/proftpd/Config.in
> +++ b/package/proftpd/Config.in
> @@ -29,7 +29,8 @@ config BR2_PACKAGE_PROFTPD_MOD_REDIS
>  config BR2_PACKAGE_PROFTPD_MOD_SFTP
>  	bool "mod_sftp support"
>  	select BR2_PACKAGE_OPENSSL
> -	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160 if BR2_PACKAGE_LIBOPENSSL
> +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
> +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160
>  	help
>  	  Compile ProFTPD with mod_sftp support
>  

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/proftpd: disable sftp with libressl

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fabrice, All,
 > On 2023-01-18 18:37 +0100, Fabrice Fontaine spake thusly:
 >> sftp doesn't build with libressl >= 3.5.0 resulting in the following
 >> build failure since commit 8b216927db080b38fdbf1f8b025b6f90a89d4bc2:
 >> 
 >> mac.c: In function 'init_mac':
 >> mac.c:189:3: warning: implicit declaration of function
 >> 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'?
 >> [-Wimplicit-function-declaration]
 >> 189 |   HMAC_CTX_init(hmac_ctx);
 >> |   ^~~~~~~~~~~~~
 >> |   HMAC_CTX_new
 >> mac.c: In function 'set_mac_key':
 >> mac.c:435:14: error: storage size of 'ctx' isn't known
 >> 435 |   EVP_MD_CTX ctx;
 >> |              ^~~
 >> 
 >> So disable sftp with libressl

 > This, and the commit title, are misleading: sftp is not _disabled_ with
 > libressl; if you had done that, then the code would have looked like:

 >     config BR2_PACKAGE_PROFTPD_MOD_SFTP
 >         bool "mod_sftp"
 >         depends on !BR2_PACKAGE_LIBRESSL

 > Realy, what this change does, is to force use of openssl for sftp.

 > So, I tweeaked the commit title and log to reflect that.

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot