* [Buildroot] [PATCH 1/1] qemu: fix host virtfs option
@ 2019-08-01 9:27 Vincent Stehlé
2019-08-01 16:02 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Vincent Stehlé @ 2019-08-01 9:27 UTC (permalink / raw)
To: buildroot
Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
conditional and add a dependency on host-libcap.
The virtfs configuration option was added by commit e0f49e648401
("package/qemu: add option to enable virtual filesystem in host qemu").
Signed-off-by: Vincent Stehl? <vincent.stehle@arm.com>
Cc: Etienne Carriere <etienne.carriere@linaro.org>
---
Hi,
I build-tested this with a number of architectures[1], with VIRTFS=y/n and
this looks fine.
During testing I remarked that VIRTFS=n is somewhat "weak", as it does
not forcibly disable virtfs. This means qemu can still auto-detect libcap
and libattr, and decide to auto-enable virtfs. I think this does not harm,
but we could also add an explicit --disable-virtfs if preferred. Do not
hesitate to let me know if I should respin with this change.
...et au passage un petit coucou ? Etienne :)
Vincent.
[1]: aarch64, arm, i386, m68k, microblaze, microblazeel, mips, mips64,
mips64el, mipsel, ppc, ppc64, riscv32, riscv64, sh4, sh4eb, sparc and
x86_64.
package/qemu/qemu.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 73e0778d73..eff4bb6213 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -271,8 +271,9 @@ HOST_QEMU_OPTS += --enable-vde
HOST_QEMU_DEPENDENCIES += host-vde2
endif
-ifdef ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
+ifeq ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
HOST_QEMU_OPTS += --enable-virtfs
+HOST_QEMU_DEPENDENCIES += host-libcap
endif
# Override CPP, as it expects to be able to call it like it'd
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] qemu: fix host virtfs option
2019-08-01 9:27 [Buildroot] [PATCH 1/1] qemu: fix host virtfs option Vincent Stehlé
@ 2019-08-01 16:02 ` Thomas Petazzoni
2019-08-01 17:09 ` [Buildroot] [PATCH v2] " Vincent Stehlé
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-08-01 16:02 UTC (permalink / raw)
To: buildroot
Hello Vincent,
On Thu, 1 Aug 2019 11:27:01 +0200
Vincent Stehl? <vincent.stehle@arm.com> wrote:
> Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
> conditional and add a dependency on host-libcap.
>
> The virtfs configuration option was added by commit e0f49e648401
> ("package/qemu: add option to enable virtual filesystem in host qemu").
>
> Signed-off-by: Vincent Stehl? <vincent.stehle@arm.com>
> Cc: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>
>
> Hi,
>
> I build-tested this with a number of architectures[1], with VIRTFS=y/n and
> this looks fine.
> During testing I remarked that VIRTFS=n is somewhat "weak", as it does
> not forcibly disable virtfs. This means qemu can still auto-detect libcap
> and libattr, and decide to auto-enable virtfs. I think this does not harm,
> but we could also add an explicit --disable-virtfs if preferred. Do not
> hesitate to let me know if I should respin with this change.
Yes, we like to explicitly disable features, when possible.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] qemu: fix host virtfs option
2019-08-01 16:02 ` Thomas Petazzoni
@ 2019-08-01 17:09 ` Vincent Stehlé
2019-08-01 17:55 ` Peter Korsgaard
2019-08-21 12:38 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Vincent Stehlé @ 2019-08-01 17:09 UTC (permalink / raw)
To: buildroot
Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
conditional and add a dependency on host-libcap.
The virtfs configuration option was added by commit e0f49e648401
("package/qemu: add option to enable virtual filesystem in host qemu").
Signed-off-by: Vincent Stehl? <vincent.stehle@arm.com>
Cc: Etienne Carriere <etienne.carriere@linaro.org>
---
Changes v1 -> v2:
- Forcibly disable virtfs when config option is =n rather than letting
qemu auto-detect (as per Thomas' feedback)
package/qemu/qemu.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 73e0778d73..2c11f64ad0 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -271,8 +271,11 @@ HOST_QEMU_OPTS += --enable-vde
HOST_QEMU_DEPENDENCIES += host-vde2
endif
-ifdef ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
+ifeq ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
HOST_QEMU_OPTS += --enable-virtfs
+HOST_QEMU_DEPENDENCIES += host-libcap
+else
+HOST_QEMU_OPTS += --disable-virtfs
endif
# Override CPP, as it expects to be able to call it like it'd
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] qemu: fix host virtfs option
2019-08-01 17:09 ` [Buildroot] [PATCH v2] " Vincent Stehlé
@ 2019-08-01 17:55 ` Peter Korsgaard
2019-08-21 12:38 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-08-01 17:55 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Stehl? <vincent.stehle@arm.com> writes:
> Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
> conditional and add a dependency on host-libcap.
> The virtfs configuration option was added by commit e0f49e648401
> ("package/qemu: add option to enable virtual filesystem in host qemu").
> Signed-off-by: Vincent Stehl? <vincent.stehle@arm.com>
> Cc: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> Changes v1 -> v2:
> - Forcibly disable virtfs when config option is =n rather than letting
> qemu auto-detect (as per Thomas' feedback)
> package/qemu/qemu.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 73e0778d73..2c11f64ad0 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -271,8 +271,11 @@ HOST_QEMU_OPTS += --enable-vde
> HOST_QEMU_DEPENDENCIES += host-vde2
> endif
> -ifdef ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
> +ifeq ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
> HOST_QEMU_OPTS += --enable-virtfs
> +HOST_QEMU_DEPENDENCIES += host-libcap
I was going to say that we also need host-attr, but looking closer at
the configure step I see that the xattr support in glibc is also
accepted.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] qemu: fix host virtfs option
2019-08-01 17:09 ` [Buildroot] [PATCH v2] " Vincent Stehlé
2019-08-01 17:55 ` Peter Korsgaard
@ 2019-08-21 12:38 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-08-21 12:38 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Stehl? <vincent.stehle@arm.com> writes:
> Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
> conditional and add a dependency on host-libcap.
> The virtfs configuration option was added by commit e0f49e648401
> ("package/qemu: add option to enable virtual filesystem in host qemu").
> Signed-off-by: Vincent Stehl? <vincent.stehle@arm.com>
> Cc: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> Changes v1 -> v2:
> - Forcibly disable virtfs when config option is =n rather than letting
> qemu auto-detect (as per Thomas' feedback)
Committed to 2019.02.x and 2019.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-21 12:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-01 9:27 [Buildroot] [PATCH 1/1] qemu: fix host virtfs option Vincent Stehlé
2019-08-01 16:02 ` Thomas Petazzoni
2019-08-01 17:09 ` [Buildroot] [PATCH v2] " Vincent Stehlé
2019-08-01 17:55 ` Peter Korsgaard
2019-08-21 12:38 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox