* [Buildroot] [PATCH 1/3] gnuchess: fix license
@ 2019-01-10 17:59 Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2019-01-10 17:59 UTC (permalink / raw)
To: buildroot
gnuchess is licensed under GPL-3.0+ not GPL-2.0+, also add hash for
license file
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/gnuchess/gnuchess.hash | 1 +
package/gnuchess/gnuchess.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/gnuchess/gnuchess.hash b/package/gnuchess/gnuchess.hash
index 064a845eda..e0a1c4c418 100644
--- a/package/gnuchess/gnuchess.hash
+++ b/package/gnuchess/gnuchess.hash
@@ -1,2 +1,3 @@
# sha256 locally computed
sha256 3c425c0264f253fc5cc2ba969abe667d77703c728770bd4b23c456cbe5e082ef gnuchess-6.2.4.tar.gz
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
diff --git a/package/gnuchess/gnuchess.mk b/package/gnuchess/gnuchess.mk
index 1465ab0a00..0abdab5ba5 100644
--- a/package/gnuchess/gnuchess.mk
+++ b/package/gnuchess/gnuchess.mk
@@ -6,7 +6,7 @@
GNUCHESS_VERSION = 6.2.4
GNUCHESS_SITE = $(BR2_GNU_MIRROR)/chess
-GNUCHESS_LICENSE = GPL-2.0+
+GNUCHESS_LICENSE = GPL-3.0+
GNUCHESS_LICENSE_FILES = COPYING
GNUCHESS_DEPENDENCIES = host-flex flex
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus
2019-01-10 17:59 [Buildroot] [PATCH 1/3] gnuchess: fix license Fabrice Fontaine
@ 2019-01-10 17:59 ` Fabrice Fontaine
2019-01-10 19:59 ` Thomas Petazzoni
2019-01-10 17:59 ` [Buildroot] [PATCH 3/3] gnuchess: bump to version 6.2.5 Fabrice Fontaine
2019-01-10 20:41 ` [Buildroot] [PATCH 1/3] gnuchess: fix license Thomas Petazzoni
2 siblings, 1 reply; 9+ messages in thread
From: Fabrice Fontaine @ 2019-01-10 17:59 UTC (permalink / raw)
To: buildroot
When building with -O2 (or -O3), link fails on:
/home/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/arm-linux-g++ -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wl,-elf2flt -static -Wl,-elf2flt -static -Wl,-elf2flt -static -o gnuchess main.o components.o frontend/libfrontend.a adapter/libadapter.a engine/libengine.a -lreadline -lncurses
ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
To fix this, replace -O2 or -O3 by -Os
Fixes:
- http://autobuild.buildroot.org/results/7918757b255ed41609609d2083c2d8904ff3136e
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/gnuchess/gnuchess.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/gnuchess/gnuchess.mk b/package/gnuchess/gnuchess.mk
index 0abdab5ba5..b2fbcff864 100644
--- a/package/gnuchess/gnuchess.mk
+++ b/package/gnuchess/gnuchess.mk
@@ -13,4 +13,11 @@ GNUCHESS_DEPENDENCIES = host-flex flex
GNUCHESS_DEPENDENCIES += $(if $(BR2_PACKAGE_READLINE),readline) \
$(TARGET_NLS_DEPENDENCIES)
+# Workaround a build issue with -O2 or -03 for ARM Cortex-M cpus
+ifeq ($(BR2_ARM_CPU_ARMV7M):$(BR2_OPTIMIZE_2)$(BR2_OPTIMIZE_3),y:y)
+GNUCHESS_CONF_ENV += \
+ CFLAGS="$(TARGET_CFLAGS) -Os" \
+ CXXFLAGS="$(TARGET_CXXFLAGS) -Os"
+endif
+
$(eval $(autotools-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus
2019-01-10 17:59 ` [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus Fabrice Fontaine
@ 2019-01-10 19:59 ` Thomas Petazzoni
2019-01-12 17:53 ` Fabrice Fontaine
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2019-01-10 19:59 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 10 Jan 2019 18:59:54 +0100, Fabrice Fontaine wrote:
> When building with -O2 (or -O3), link fails on:
>
> /home/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/arm-linux-g++ -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wl,-elf2flt -static -Wl,-elf2flt -static -Wl,-elf2flt -static -o gnuchess main.o components.o frontend/libfrontend.a adapter/libadapter.a engine/libengine.a -lreadline -lncurses
> ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
Interesting. In commit
https://git.buildroot.net/buildroot/commit/?id=49f574237983ae2e69e4a4c43df7be98902a63be,
we are doing exactly the opposite: when -Os is used, we pass -O2.
Romain reported the issue at
https://sourceware.org/bugzilla/show_bug.cgi?id=20552, and as you can
see, we got a tremendous amount of feedback from the binutils
developers :-)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus
2019-01-10 19:59 ` Thomas Petazzoni
@ 2019-01-12 17:53 ` Fabrice Fontaine
0 siblings, 0 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2019-01-12 17:53 UTC (permalink / raw)
To: buildroot
Dear Thomas,
Le jeu. 10 janv. 2019 ? 20:59, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello,
>
> On Thu, 10 Jan 2019 18:59:54 +0100, Fabrice Fontaine wrote:
> > When building with -O2 (or -O3), link fails on:
> >
> > /home/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/arm-linux-g++ -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wl,-elf2flt -static -Wl,-elf2flt -static -Wl,-elf2flt -static -o gnuchess main.o components.o frontend/libfrontend.a adapter/libadapter.a engine/libengine.a -lreadline -lncurses
> > ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVT_ABS unsupported in this context
> > ERROR: reloc type R_ARM_THM_MOVW_ABS_NC unsupported in this context
>
> Interesting. In commit
> https://git.buildroot.net/buildroot/commit/?id=49f574237983ae2e69e4a4c43df7be98902a63be,
> we are doing exactly the opposite: when -Os is used, we pass -O2.
>
> Romain reported the issue at
> https://sourceware.org/bugzilla/show_bug.cgi?id=20552, and as you can
> see, we got a tremendous amount of feedback from the binutils
> developers :-)
After fixing sunxi-cedarx, I found a better solution for gnuchess,
passing -fPIC in addition to -O2 fix the build failure. I'll send a
v2.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] gnuchess: bump to version 6.2.5
2019-01-10 17:59 [Buildroot] [PATCH 1/3] gnuchess: fix license Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus Fabrice Fontaine
@ 2019-01-10 17:59 ` Fabrice Fontaine
2019-01-12 16:56 ` Thomas Petazzoni
2019-01-10 20:41 ` [Buildroot] [PATCH 1/3] gnuchess: fix license Thomas Petazzoni
2 siblings, 1 reply; 9+ messages in thread
From: Fabrice Fontaine @ 2019-01-10 17:59 UTC (permalink / raw)
To: buildroot
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/gnuchess/gnuchess.hash | 2 +-
package/gnuchess/gnuchess.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/gnuchess/gnuchess.hash b/package/gnuchess/gnuchess.hash
index e0a1c4c418..9342fc3eb7 100644
--- a/package/gnuchess/gnuchess.hash
+++ b/package/gnuchess/gnuchess.hash
@@ -1,3 +1,3 @@
# sha256 locally computed
-sha256 3c425c0264f253fc5cc2ba969abe667d77703c728770bd4b23c456cbe5e082ef gnuchess-6.2.4.tar.gz
+sha256 9a99e963355706cab32099d140b698eda9de164ebce40a5420b1b9772dd04802 gnuchess-6.2.5.tar.gz
sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
diff --git a/package/gnuchess/gnuchess.mk b/package/gnuchess/gnuchess.mk
index b2fbcff864..0c8c3b836c 100644
--- a/package/gnuchess/gnuchess.mk
+++ b/package/gnuchess/gnuchess.mk
@@ -4,7 +4,7 @@
#
################################################################################
-GNUCHESS_VERSION = 6.2.4
+GNUCHESS_VERSION = 6.2.5
GNUCHESS_SITE = $(BR2_GNU_MIRROR)/chess
GNUCHESS_LICENSE = GPL-3.0+
GNUCHESS_LICENSE_FILES = COPYING
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] gnuchess: fix license
2019-01-10 17:59 [Buildroot] [PATCH 1/3] gnuchess: fix license Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 3/3] gnuchess: bump to version 6.2.5 Fabrice Fontaine
@ 2019-01-10 20:41 ` Thomas Petazzoni
2019-01-11 10:48 ` Peter Korsgaard
2019-01-24 15:28 ` Peter Korsgaard
2 siblings, 2 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2019-01-10 20:41 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 10 Jan 2019 18:59:53 +0100, Fabrice Fontaine wrote:
> gnuchess is licensed under GPL-3.0+ not GPL-2.0+, also add hash for
> license file
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/gnuchess/gnuchess.hash | 1 +
> package/gnuchess/gnuchess.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Applied to master, thanks.
Peter: I checked, and the gnuchess version in 2018.02.x is also under
GPL-3.0+, so the patch should be backported to 2018.02.x.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] gnuchess: fix license
2019-01-10 20:41 ` [Buildroot] [PATCH 1/3] gnuchess: fix license Thomas Petazzoni
@ 2019-01-11 10:48 ` Peter Korsgaard
2019-01-24 15:28 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2019-01-11 10:48 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello,
> On Thu, 10 Jan 2019 18:59:53 +0100, Fabrice Fontaine wrote:
>> gnuchess is licensed under GPL-3.0+ not GPL-2.0+, also add hash for
>> license file
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/gnuchess/gnuchess.hash | 1 +
>> package/gnuchess/gnuchess.mk | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
> Applied to master, thanks.
> Peter: I checked, and the gnuchess version in 2018.02.x is also under
> GPL-3.0+, so the patch should be backported to 2018.02.x.
Ok, thanks for the heads up!
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] gnuchess: fix license
2019-01-10 20:41 ` [Buildroot] [PATCH 1/3] gnuchess: fix license Thomas Petazzoni
2019-01-11 10:48 ` Peter Korsgaard
@ 2019-01-24 15:28 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2019-01-24 15:28 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello,
> On Thu, 10 Jan 2019 18:59:53 +0100, Fabrice Fontaine wrote:
>> gnuchess is licensed under GPL-3.0+ not GPL-2.0+, also add hash for
>> license file
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/gnuchess/gnuchess.hash | 1 +
>> package/gnuchess/gnuchess.mk | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
> Applied to master, thanks.
> Peter: I checked, and the gnuchess version in 2018.02.x is also under
> GPL-3.0+, so the patch should be backported to 2018.02.x.
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-24 15:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-10 17:59 [Buildroot] [PATCH 1/3] gnuchess: fix license Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 2/3] gnuchess: disable -O2 and -O3 for ARM cortex-M cpus Fabrice Fontaine
2019-01-10 19:59 ` Thomas Petazzoni
2019-01-12 17:53 ` Fabrice Fontaine
2019-01-10 17:59 ` [Buildroot] [PATCH 3/3] gnuchess: bump to version 6.2.5 Fabrice Fontaine
2019-01-12 16:56 ` Thomas Petazzoni
2019-01-10 20:41 ` [Buildroot] [PATCH 1/3] gnuchess: fix license Thomas Petazzoni
2019-01-11 10:48 ` Peter Korsgaard
2019-01-24 15:28 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox