* [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency
@ 2019-01-20 9:47 Fabrice Fontaine
2019-01-20 9:47 ` [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF Fabrice Fontaine
2019-01-20 19:16 ` [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2019-01-20 9:47 UTC (permalink / raw)
To: buildroot
Commit 9b551dacf74445d58aaefef349e2817e009c9d5d added support for
libupnp18 but without updating LIBUPNPP_DEPENDENCIES
Fixes:
- http://autobuild.buildroot.org/results/aa734318b9ad318d25e772585c8794429cc0f489
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libupnpp/libupnpp.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk
index 69ce0768a9..31a066a648 100644
--- a/package/libupnpp/libupnpp.mk
+++ b/package/libupnpp/libupnpp.mk
@@ -9,7 +9,8 @@ LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
LIBUPNPP_LICENSE = LGPL-2.1+
LIBUPNPP_LICENSE_FILES = COPYING
LIBUPNPP_INSTALL_STAGING = YES
-LIBUPNPP_DEPENDENCIES = expat libcurl libupnp
+LIBUPNPP_DEPENDENCIES = expat libcurl \
+ $(if $(BR2_PACKAGE_LIBUPNP),libupnp,libupnp18)
# We're patching configure.ac
LIBUPNPP_AUTORECONF = YES
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF
2019-01-20 9:47 [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Fabrice Fontaine
@ 2019-01-20 9:47 ` Fabrice Fontaine
2019-01-20 19:16 ` Peter Korsgaard
2019-01-20 19:16 ` [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2019-01-20 9:47 UTC (permalink / raw)
To: buildroot
Commit 9b551dacf74445d58aaefef349e2817e009c9d5d removed patch on
configure.ac so remove uneeded LIBUPNPP_AUTORECONF
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libupnpp/libupnpp.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk
index 31a066a648..3619050f10 100644
--- a/package/libupnpp/libupnpp.mk
+++ b/package/libupnpp/libupnpp.mk
@@ -11,8 +11,6 @@ LIBUPNPP_LICENSE_FILES = COPYING
LIBUPNPP_INSTALL_STAGING = YES
LIBUPNPP_DEPENDENCIES = expat libcurl \
$(if $(BR2_PACKAGE_LIBUPNP),libupnp,libupnp18)
-# We're patching configure.ac
-LIBUPNPP_AUTORECONF = YES
# configure script fails to link against the dependencies of libupnp
# and libcurl causing detection to fail when statically linking
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency
2019-01-20 9:47 [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Fabrice Fontaine
2019-01-20 9:47 ` [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF Fabrice Fontaine
@ 2019-01-20 19:16 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-01-20 19:16 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit 9b551dacf74445d58aaefef349e2817e009c9d5d added support for
> libupnp18 but without updating LIBUPNPP_DEPENDENCIES
> Fixes:
> - http://autobuild.buildroot.org/results/aa734318b9ad318d25e772585c8794429cc0f489
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF
2019-01-20 9:47 ` [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF Fabrice Fontaine
@ 2019-01-20 19:16 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-01-20 19:16 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit 9b551dacf74445d58aaefef349e2817e009c9d5d removed patch on
> configure.ac so remove uneeded LIBUPNPP_AUTORECONF
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-20 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-20 9:47 [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Fabrice Fontaine
2019-01-20 9:47 ` [Buildroot] [PATCH 2/2] libupnpp: remove AUTORECONF Fabrice Fontaine
2019-01-20 19:16 ` Peter Korsgaard
2019-01-20 19:16 ` [Buildroot] [PATCH 1/2] libupnpp: fix libupnp dependency Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox