Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library
@ 2019-01-18 22:05 Fabrice Fontaine
  2019-01-19 21:41 ` Peter Korsgaard
  2019-01-29 16:29 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-01-18 22:05 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/1036ee061ce7f7747d5514c61866da60bcfae769

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/qt/Config.sql.in   | 4 ++++
 package/unixodbc/Config.in | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/package/qt/Config.sql.in b/package/qt/Config.sql.in
index 1e7f6ba799..71a198242f 100644
--- a/package/qt/Config.sql.in
+++ b/package/qt/Config.sql.in
@@ -16,11 +16,15 @@ config BR2_PACKAGE_QT_MYSQL
 
 config BR2_PACKAGE_QT_ODBC
 	bool "ODBC Driver"
+	depends on !BR2_STATIC_LIBS # unixodbc
 	select BR2_PACKAGE_UNIXODBC
 	help
 	  Build ODBC driver
 	  If unsure, say n.
 
+comment "ODBC driver needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
+
 config BR2_PACKAGE_QT_PSQL
 	bool "PostgreSQL Driver"
 	depends on !BR2_STATIC_LIBS
diff --git a/package/unixodbc/Config.in b/package/unixodbc/Config.in
index d5434d1ef1..eb0ad9c541 100644
--- a/package/unixodbc/Config.in
+++ b/package/unixodbc/Config.in
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_UNIXODBC
 	bool "unixodbc"
+	depends on !BR2_STATIC_LIBS # dlopen()
 	help
 	  The unixODBC Project goals are to develop and promote
 	  unixODBC to be the definitive standard for ODBC on non MS
 	  Windows platforms.
 
 	  http://www.unixodbc.org
+
+comment "unixodbc needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library
  2019-01-18 22:05 [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library Fabrice Fontaine
@ 2019-01-19 21:41 ` Peter Korsgaard
  2019-01-29 16:29 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-01-19 21:41 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/1036ee061ce7f7747d5514c61866da60bcfae769

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/qt/Config.sql.in   | 4 ++++
 >  package/unixodbc/Config.in | 4 ++++
 >  2 files changed, 8 insertions(+)

You forgot to also propagate to the php unixodbc driver. Committed with
that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library
  2019-01-18 22:05 [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library Fabrice Fontaine
  2019-01-19 21:41 ` Peter Korsgaard
@ 2019-01-29 16:29 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-01-29 16:29 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/1036ee061ce7f7747d5514c61866da60bcfae769

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-29 16:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-18 22:05 [Buildroot] [PATCH 1/1] unixodbc: needs dynamic library Fabrice Fontaine
2019-01-19 21:41 ` Peter Korsgaard
2019-01-29 16:29 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox