* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-06 20:52 Sven Neumann
@ 2011-12-06 20:52 ` Sven Neumann
2011-12-07 6:57 ` Thomas De Schampheleire
0 siblings, 1 reply; 12+ messages in thread
From: Sven Neumann @ 2011-12-06 20:52 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
package/sqlite/Config.in | 8 ++++++++
package/sqlite/sqlite.mk | 4 ++++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
index f9b12ae..b7b17c6 100644
--- a/package/sqlite/Config.in
+++ b/package/sqlite/Config.in
@@ -14,3 +14,11 @@ config BR2_PACKAGE_SQLITE_READLINE
help
Enable command-line editing. This requires ncurses and readline.
+config BR2_PACKAGE_SQLITE_STAT3
+ bool "Additional query optimizations (stat3)"
+ depends on BR2_PACKAGE_SQLITE
+ help
+ Adds additional logic to the ANALYZE command and to the query
+ planner that can help SQLite to chose a better query plan under
+ certain situations.
+
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index 0bee337..042c7f9 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -16,6 +16,10 @@ ifneq ($(BR2_LARGEFILE),y)
SQLITE_CFLAGS += -DSQLITE_DISABLE_LFS
endif
+ifeq ($(BR2_PACKAGE_SQLITE_STAT3),y)
+SQLITE_CFLAGS += -DSQLITE_ENABLE_STAT3
+endif
+
SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) $(SQLITE_CFLAGS)"
SQLITE_CONF_OPT = \
--
1.7.5.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-06 20:52 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
@ 2011-12-07 6:57 ` Thomas De Schampheleire
2011-12-07 7:03 ` Thomas De Schampheleire
2011-12-07 18:55 ` Sven Neumann
0 siblings, 2 replies; 12+ messages in thread
From: Thomas De Schampheleire @ 2011-12-07 6:57 UTC (permalink / raw)
To: buildroot
On Tue, Dec 6, 2011 at 9:52 PM, Sven Neumann <s.neumann@raumfeld.com> wrote:
> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
> ---
> ?package/sqlite/Config.in | ? ?8 ++++++++
> ?package/sqlite/sqlite.mk | ? ?4 ++++
> ?2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
> index f9b12ae..b7b17c6 100644
> --- a/package/sqlite/Config.in
> +++ b/package/sqlite/Config.in
> @@ -14,3 +14,11 @@ config BR2_PACKAGE_SQLITE_READLINE
> ? ? ? ?help
> ? ? ? ? ?Enable command-line editing. This requires ncurses and readline.
>
> +config BR2_PACKAGE_SQLITE_STAT3
> + ? ? ? bool "Additional query optimizations (stat3)"
> + ? ? ? depends on BR2_PACKAGE_SQLITE
> + ? ? ? help
> + ? ? ? ? Adds additional logic to the ANALYZE command and to the query
> + ? ? ? ? planner that can help SQLite to chose a better query plan under
s/chose/choose/
> + ? ? ? ? certain situations.
> +
> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> index 0bee337..042c7f9 100644
> --- a/package/sqlite/sqlite.mk
> +++ b/package/sqlite/sqlite.mk
> @@ -16,6 +16,10 @@ ifneq ($(BR2_LARGEFILE),y)
> ?SQLITE_CFLAGS += -DSQLITE_DISABLE_LFS
> ?endif
>
> +ifeq ($(BR2_PACKAGE_SQLITE_STAT3),y)
> +SQLITE_CFLAGS += -DSQLITE_ENABLE_STAT3
> +endif
> +
> ?SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) $(SQLITE_CFLAGS)"
>
> ?SQLITE_CONF_OPT = \
> --
> 1.7.5.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-07 6:57 ` Thomas De Schampheleire
@ 2011-12-07 7:03 ` Thomas De Schampheleire
2011-12-07 18:55 ` Sven Neumann
1 sibling, 0 replies; 12+ messages in thread
From: Thomas De Schampheleire @ 2011-12-07 7:03 UTC (permalink / raw)
To: buildroot
On Wed, Dec 7, 2011 at 7:57 AM, Thomas De Schampheleire
<patrickdepinguin+buildroot@gmail.com> wrote:
> On Tue, Dec 6, 2011 at 9:52 PM, Sven Neumann <s.neumann@raumfeld.com> wrote:
>> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
>> ---
>> ?package/sqlite/Config.in | ? ?8 ++++++++
>> ?package/sqlite/sqlite.mk | ? ?4 ++++
>> ?2 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
>> index f9b12ae..b7b17c6 100644
>> --- a/package/sqlite/Config.in
>> +++ b/package/sqlite/Config.in
>> @@ -14,3 +14,11 @@ config BR2_PACKAGE_SQLITE_READLINE
>> ? ? ? ?help
>> ? ? ? ? ?Enable command-line editing. This requires ncurses and readline.
>>
>> +config BR2_PACKAGE_SQLITE_STAT3
>> + ? ? ? bool "Additional query optimizations (stat3)"
>> + ? ? ? depends on BR2_PACKAGE_SQLITE
>> + ? ? ? help
>> + ? ? ? ? Adds additional logic to the ANALYZE command and to the query
>> + ? ? ? ? planner that can help SQLite to chose a better query plan under
>
> s/chose/choose/
>
>> + ? ? ? ? certain situations.
>> +
>> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
>> index 0bee337..042c7f9 100644
>> --- a/package/sqlite/sqlite.mk
>> +++ b/package/sqlite/sqlite.mk
>> @@ -16,6 +16,10 @@ ifneq ($(BR2_LARGEFILE),y)
>> ?SQLITE_CFLAGS += -DSQLITE_DISABLE_LFS
>> ?endif
>>
>> +ifeq ($(BR2_PACKAGE_SQLITE_STAT3),y)
>> +SQLITE_CFLAGS += -DSQLITE_ENABLE_STAT3
>> +endif
>> +
>> ?SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) $(SQLITE_CFLAGS)"
>>
>> ?SQLITE_CONF_OPT = \
I'm not using sqlite myself, so cannot comment on the technical
correctness of your changes. But, besides the typo I mentioned, your
series looks fine to me, so as far as I'm concerned you can add
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
to the entire series.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-07 6:57 ` Thomas De Schampheleire
2011-12-07 7:03 ` Thomas De Schampheleire
@ 2011-12-07 18:55 ` Sven Neumann
1 sibling, 0 replies; 12+ messages in thread
From: Sven Neumann @ 2011-12-07 18:55 UTC (permalink / raw)
To: buildroot
On Wed, 2011-12-07 at 07:57 +0100, Thomas De Schampheleire wrote:
> On Tue, Dec 6, 2011 at 9:52 PM, Sven Neumann <s.neumann@raumfeld.com> wrote:
> > +config BR2_PACKAGE_SQLITE_STAT3
> > + bool "Additional query optimizations (stat3)"
> > + depends on BR2_PACKAGE_SQLITE
> > + help
> > + Adds additional logic to the ANALYZE command and to the query
> > + planner that can help SQLite to chose a better query plan under
>
> s/chose/choose/
Actually that typo should be fixed upstream in the sqlite documentation
then ;-)
Thanks for the review, I'll resubmit the patch-set with the typo fixed
and your Reviewed-by: added.
Sven
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9
@ 2011-12-07 19:00 Sven Neumann
2011-12-07 19:00 ` [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options Sven Neumann
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Sven Neumann @ 2011-12-07 19:00 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
package/sqlite/sqlite.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index 10fe9fe..5391d86 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -4,7 +4,7 @@
#
#############################################################
-SQLITE_VERSION = 3070800
+SQLITE_VERSION = 3070900
SQLITE_SOURCE = sqlite-autoconf-$(SQLITE_VERSION).tar.gz
SQLITE_SITE = http://www.sqlite.org
SQLITE_INSTALL_STAGING = YES
--
1.7.5.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options
2011-12-07 19:00 [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Sven Neumann
@ 2011-12-07 19:00 ` Sven Neumann
2011-12-11 21:15 ` Peter Korsgaard
2011-12-07 19:00 ` [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script Sven Neumann
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Sven Neumann @ 2011-12-07 19:00 UTC (permalink / raw)
To: buildroot
Drop options that are unknown to the configure script.
Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/sqlite/sqlite.mk | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index 5391d86..f587f47 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -16,11 +16,9 @@ ifneq ($(BR2_LARGEFILE),y)
SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DSQLITE_DISABLE_LFS"
endif
-SQLITE_CONF_OPT = --enable-tempstore=yes \
- --enable-threadsafe \
- --enable-releasemode \
- --disable-tcl \
- --localstatedir=/var
+SQLITE_CONF_OPT = \
+ --enable-threadsafe \
+ --localstatedir=/var
ifeq ($(BR2_PACKAGE_SQLITE_READLINE),y)
SQLITE_DEPENDENCIES += ncurses readline
--
1.7.5.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script
2011-12-07 19:00 [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Sven Neumann
2011-12-07 19:00 ` [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options Sven Neumann
@ 2011-12-07 19:00 ` Sven Neumann
2011-12-11 21:16 ` Peter Korsgaard
2011-12-07 19:00 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
2011-12-11 21:14 ` [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Peter Korsgaard
3 siblings, 1 reply; 12+ messages in thread
From: Sven Neumann @ 2011-12-07 19:00 UTC (permalink / raw)
To: buildroot
Change the way the SQLITE_CONF_ENV variable is constructed in
preparation of passing other CFLAGS to the configure script.
Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/sqlite/sqlite.mk | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index f587f47..0bee337 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -13,9 +13,11 @@ ifneq ($(BR2_LARGEFILE),y)
# the sqlite configure script fails to define SQLITE_DISABLE_LFS when
# --disable-largefile is passed, breaking the build. Work around it by
# simply adding it to CFLAGS for configure instead
-SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DSQLITE_DISABLE_LFS"
+SQLITE_CFLAGS += -DSQLITE_DISABLE_LFS
endif
+SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) $(SQLITE_CFLAGS)"
+
SQLITE_CONF_OPT = \
--enable-threadsafe \
--localstatedir=/var
--
1.7.5.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-07 19:00 [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Sven Neumann
2011-12-07 19:00 ` [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options Sven Neumann
2011-12-07 19:00 ` [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script Sven Neumann
@ 2011-12-07 19:00 ` Sven Neumann
2011-12-11 21:18 ` Peter Korsgaard
2011-12-11 21:14 ` [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Peter Korsgaard
3 siblings, 1 reply; 12+ messages in thread
From: Sven Neumann @ 2011-12-07 19:00 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/sqlite/Config.in | 8 ++++++++
package/sqlite/sqlite.mk | 4 ++++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
index f9b12ae..b7b17c6 100644
--- a/package/sqlite/Config.in
+++ b/package/sqlite/Config.in
@@ -14,3 +14,11 @@ config BR2_PACKAGE_SQLITE_READLINE
help
Enable command-line editing. This requires ncurses and readline.
+config BR2_PACKAGE_SQLITE_STAT3
+ bool "Additional query optimizations (stat3)"
+ depends on BR2_PACKAGE_SQLITE
+ help
+ Adds additional logic to the ANALYZE command and to the query
+ planner that can help SQLite to choose a better query plan under
+ certain situations.
+
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index 0bee337..042c7f9 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -16,6 +16,10 @@ ifneq ($(BR2_LARGEFILE),y)
SQLITE_CFLAGS += -DSQLITE_DISABLE_LFS
endif
+ifeq ($(BR2_PACKAGE_SQLITE_STAT3),y)
+SQLITE_CFLAGS += -DSQLITE_ENABLE_STAT3
+endif
+
SQLITE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) $(SQLITE_CFLAGS)"
SQLITE_CONF_OPT = \
--
1.7.5.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9
2011-12-07 19:00 [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Sven Neumann
` (2 preceding siblings ...)
2011-12-07 19:00 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
@ 2011-12-11 21:14 ` Peter Korsgaard
3 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2011-12-11 21:14 UTC (permalink / raw)
To: buildroot
>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
Sven> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options
2011-12-07 19:00 ` [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options Sven Neumann
@ 2011-12-11 21:15 ` Peter Korsgaard
0 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2011-12-11 21:15 UTC (permalink / raw)
To: buildroot
>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
Sven> Drop options that are unknown to the configure script.
Sven> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Sven> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script
2011-12-07 19:00 ` [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script Sven Neumann
@ 2011-12-11 21:16 ` Peter Korsgaard
0 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2011-12-11 21:16 UTC (permalink / raw)
To: buildroot
>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
Sven> Change the way the SQLITE_CONF_ENV variable is constructed in
Sven> preparation of passing other CFLAGS to the configure script.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3)
2011-12-07 19:00 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
@ 2011-12-11 21:18 ` Peter Korsgaard
0 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2011-12-11 21:18 UTC (permalink / raw)
To: buildroot
>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
Sven> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
Sven> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-12-11 21:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-07 19:00 [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Sven Neumann
2011-12-07 19:00 ` [Buildroot] [PATCH 2/4] sqlite: remove obsolete configure options Sven Neumann
2011-12-11 21:15 ` Peter Korsgaard
2011-12-07 19:00 ` [Buildroot] [PATCH 3/4] sqlite: refactor how CFLAGS are passed to the configure script Sven Neumann
2011-12-11 21:16 ` Peter Korsgaard
2011-12-07 19:00 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
2011-12-11 21:18 ` Peter Korsgaard
2011-12-11 21:14 ` [Buildroot] [PATCH 1/4] sqlite: bump to version 3.7.9 Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2011-12-06 20:52 Sven Neumann
2011-12-06 20:52 ` [Buildroot] [PATCH 4/4] sqlite: add option to enable additional query optimizations (stat3) Sven Neumann
2011-12-07 6:57 ` Thomas De Schampheleire
2011-12-07 7:03 ` Thomas De Schampheleire
2011-12-07 18:55 ` Sven Neumann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox