[Buildroot] [RFC] Gerrit for BR

[Buildroot] [RFC] Gerrit for BR

[Yegor Yefremov]

What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

http://review.cyanogenmod.com
http://openocd.zylin.com

Yegor

[Buildroot] [RFC] Gerrit for BR

[C.A, Subramaniam]

+1 Good idea!

On Thu, Oct 20, 2011 at 9:11 AM, Yegor Yefremov
<yegor_sub1@visionsystems.de> wrote:
> What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.
>
> http://review.cyanogenmod.com
> http://openocd.zylin.com
>
> Yegor
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>



-- 

Thank you and Regards
Subbu

[Buildroot] [RFC] Gerrit for BR

[Thomas Petazzoni]

Le Thu, 20 Oct 2011 16:11:54 +0200,
Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :

> What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

How does it compare to patchwork (http://patchwork.ozlabs.org/) ?
Patchwork works in relation to a mailing-list, from which it
automatically picks up patches and related review comments, and it
allows maintainers to track which patches have been applied/not applied.

How does Gerrit work in that respect?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [RFC] Gerrit for BR

[Bryan Hundven]

On Thu, Oct 20, 2011 at 11:57 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Thu, 20 Oct 2011 16:11:54 +0200,
> Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :
>
>> What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.
>
> How does it compare to patchwork (http://patchwork.ozlabs.org/) ?
> Patchwork works in relation to a mailing-list, from which it
> automatically picks up patches and related review comments, and it
> allows maintainers to track which patches have been applied/not applied.
>
> How does Gerrit work in that respect?

Just supplying some background on how gerrit is used with android:

http://source.android.com/source/life-of-a-bug.html
http://source.android.com/source/life-of-a-patch.html

> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-Bryan

[Buildroot] [RFC] Gerrit for BR

[Bryan Hundven]

On Fri, Oct 21, 2011 at 12:38 AM, Bryan Hundven <bryanhundven@gmail.com> wrote:
> On Thu, Oct 20, 2011 at 11:57 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Le Thu, 20 Oct 2011 16:11:54 +0200,
>> Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :
>>
>>> What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.
>>
>> How does it compare to patchwork (http://patchwork.ozlabs.org/) ?
>> Patchwork works in relation to a mailing-list, from which it
>> automatically picks up patches and related review comments, and it
>> allows maintainers to track which patches have been applied/not applied.
>>
>> How does Gerrit work in that respect?
>
> Just supplying some background on how gerrit is used with android:
>
> http://source.android.com/source/life-of-a-bug.html
> http://source.android.com/source/life-of-a-patch.html

imo, it's what works for the project.
It seems to me that patchwork works for this project. Unless there is
a problem wrt using patchwork.

>> Thomas
>> --
>> Thomas Petazzoni, Free Electrons
>> Kernel, drivers, real-time and embedded Linux
>> development, consulting, training and support.
>> http://free-electrons.com
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> -Bryan
>

[Buildroot] [RFC] Gerrit for BR

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> What do you think about using Gerrit
 >> (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects
 >> seem to switch to this system.

 Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
 Thomas> ?  Patchwork works in relation to a mailing-list, from which it
 Thomas> automatically picks up patches and related review comments, and
 Thomas> it allows maintainers to track which patches have been
 Thomas> applied/not applied.

 Thomas> How does Gerrit work in that respect?

I don't have any hands on experience (but I am following the openocd
list, so I see it used), and my initial feeling is that something like
patchwork would fit better our current way of working.

But that's just an initial feeling, let's discuss at ELC and/or here on
the list.

-- 
Bye, Peter Korsgaard

[Buildroot] [RFC] Gerrit for BR

[Yegor Yefremov]

Am 21.10.2011 09:49, schrieb Peter Korsgaard:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> 
> Hi,
> 
>  >> What do you think about using Gerrit
>  >> (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects
>  >> seem to switch to this system.
> 
>  Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
>  Thomas> ?  Patchwork works in relation to a mailing-list, from which it
>  Thomas> automatically picks up patches and related review comments, and
>  Thomas> it allows maintainers to track which patches have been
>  Thomas> applied/not applied.
> 
>  Thomas> How does Gerrit work in that respect?
> 
> I don't have any hands on experience (but I am following the openocd
> list, so I see it used), and my initial feeling is that something like
> patchwork would fit better our current way of working.
> 
> But that's just an initial feeling, let's discuss at ELC and/or here on
> the list.

Peter, you just mentioned yourself, that you're following openocd list. Please see this thread for pros contra etc.
http://www.mail-archive.com/openocd-development at lists.berlios.de/msg18509.html

As far as I understand Gerrit integrates very good with Git and when used properly and by all contributors, you'll have all the patches in one place. The patches can be then commented online and you'll also get history for reworked patches. As soon as patches are verified, maintainer (you :-) ) can merge them with one click. These were the benefits Gerrit would bring Buidroot community. I think such approach makes sense, since lots of patches will be sent almost every day.

And as far as I understand from the openocd list thread mentioned above, patchwork still requires more handwork from maintainer than Gerrit.

Yegor

[Buildroot] [RFC] Gerrit for BR

[Thomas De Schampheleire]

Hi,

On Fri, Oct 21, 2011 at 9:49 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> Hi,
>
> ?>> What do you think about using Gerrit
> ?>> (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects
> ?>> seem to switch to this system.
>
> ?Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
> ?Thomas> ? ?Patchwork works in relation to a mailing-list, from which it
> ?Thomas> automatically picks up patches and related review comments, and
> ?Thomas> it allows maintainers to track which patches have been
> ?Thomas> applied/not applied.
>
> ?Thomas> How does Gerrit work in that respect?
>
> I don't have any hands on experience (but I am following the openocd
> list, so I see it used), and my initial feeling is that something like
> patchwork would fit better our current way of working.
>
> But that's just an initial feeling, let's discuss at ELC and/or here on
> the list.

Whatever system chosen, if any, should be capable of importing patches
from the mailing list.

The gerrit documentation does not seem to mention this feature. It
suggests that every developer creates a git repository and pushes to
the gerrit system.
Personally, I don't use git, nor would I like to be forced to. I'm
using Mercurial. Stable buildroot versions are imported into a
Mercurial repository. I make changes in that repository and prepare
patches from that, which I check on the latest buildroot snapshot.
These patches are sent to the mailing list.
I prefer being able to continue working in this way, also with a
review system in place.

~Thomas

[Buildroot] [RFC] Gerrit for BR

[Thomas Petazzoni]

Le Fri, 21 Oct 2011 13:19:53 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> Whatever system chosen, if any, should be capable of importing patches
> from the mailing list.

Not only importing, but also sending the review comments on the mailing
list. Mails can be read offline, while reading things in a web
interface needs a network connection.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com