Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix nbd compile
Date: Wed, 18 Jun 2008 17:09:24 +0200	[thread overview]
Message-ID: <87ej6u2317.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d6cda7730806180745s329ee330of0fdfaf7fb7a8397@mail.gmail.com> ("Thiago A. Corrêa"'s message of "Wed\, 18 Jun 2008 11\:45\:51 -0300")

>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:

 Thiago> This will fix nbd compile, since all versions after 2.8 now
 Thiago> depends on glib.

Thanks, committed.

The only issue I saw was:

-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client

which doesn't work for parallel builds (libglib's staging install
might not have completed before the configure step of nbd
runs). Unfortunately this isn't easy to do with Makefile.autootools.in
as the libglib version number is part of the .stamp_staging_installed
path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
libglib2.mk gets parsed later than nbd.mk.

Perhaps we should get rid of the package version in the stamp files?
That would ofcause break if you changed package version, but it might
be preferable to what we have now - E.G.:

$(BUILD_DIR)/libglib2_stamp_staging_installed

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-06-18 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 14:45 [Buildroot] [PATCH] Fix nbd compile Thiago A. Corrêa
2008-06-18 15:09 ` Peter Korsgaard [this message]
2008-06-18 15:16   ` Bernhard Fischer
2008-06-18 15:29     ` Thiago A. Corrêa
2008-06-18 15:48       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ej6u2317.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox