[Buildroot] [PATCH] Fix nbd compile

[Buildroot] [PATCH] Fix nbd compile

[Thiago A. Corrêa]

This will fix nbd compile, since all versions after 2.8 now depends on glib.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-ndb-compile.patch
Type: application/octet-stream
Size: 1602 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20080618/684a2be2/attachment.obj 

[Buildroot] [PATCH] Fix nbd compile

[Peter Korsgaard]

>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:

 Thiago> This will fix nbd compile, since all versions after 2.8 now
 Thiago> depends on glib.

Thanks, committed.

The only issue I saw was:

-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client

which doesn't work for parallel builds (libglib's staging install
might not have completed before the configure step of nbd
runs). Unfortunately this isn't easy to do with Makefile.autootools.in
as the libglib version number is part of the .stamp_staging_installed
path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
libglib2.mk gets parsed later than nbd.mk.

Perhaps we should get rid of the package version in the stamp files?
That would ofcause break if you changed package version, but it might
be preferable to what we have now - E.G.:

$(BUILD_DIR)/libglib2_stamp_staging_installed

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] Fix nbd compile

[Bernhard Fischer]

On Wed, Jun 18, 2008 at 05:09:24PM +0200, Peter Korsgaard wrote:
>>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:
>
> Thiago> This will fix nbd compile, since all versions after 2.8 now
> Thiago> depends on glib.
>
>Thanks, committed.
>
>The only issue I saw was:
>
>-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
>+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client
>
>which doesn't work for parallel builds (libglib's staging install
>might not have completed before the configure step of nbd
>runs). Unfortunately this isn't easy to do with Makefile.autootools.in
>as the libglib version number is part of the .stamp_staging_installed
>path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
>libglib2.mk gets parsed later than nbd.mk.
>
>Perhaps we should get rid of the package version in the stamp files?
>That would ofcause break if you changed package version, but it might
>be preferable to what we have now - E.G.:
>
>$(BUILD_DIR)/libglib2_stamp_staging_installed


echo the current package version into a .test_ver file in the toplevel
builddir, then cmp(1) .test_ver
$(BUILD_DIR)/$(PACK)_stamp_staging_installed. If cmp returns !0 then
rebuild and update the current version into the stamp-file

[Buildroot] [PATCH] Fix nbd compile

[Thiago A. Corrêa]

Or libraries could provide a variable that we could use on depends.

At least this way, packages won't be broken if we decide to revamp
some library makefile.

On Wed, Jun 18, 2008 at 12:16 PM, Bernhard Fischer
<rep.dot.nop@gmail.com> wrote:
> On Wed, Jun 18, 2008 at 05:09:24PM +0200, Peter Korsgaard wrote:
>>>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:
>>
>> Thiago> This will fix nbd compile, since all versions after 2.8 now
>> Thiago> depends on glib.
>>
>>Thanks, committed.
>>
>>The only issue I saw was:
>>
>>-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
>>+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client
>>
>>which doesn't work for parallel builds (libglib's staging install
>>might not have completed before the configure step of nbd
>>runs). Unfortunately this isn't easy to do with Makefile.autootools.in
>>as the libglib version number is part of the .stamp_staging_installed
>>path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
>>libglib2.mk gets parsed later than nbd.mk.
>>
>>Perhaps we should get rid of the package version in the stamp files?
>>That would ofcause break if you changed package version, but it might
>>be preferable to what we have now - E.G.:
>>
>>$(BUILD_DIR)/libglib2_stamp_staging_installed
>
>
> echo the current package version into a .test_ver file in the toplevel
> builddir, then cmp(1) .test_ver
> $(BUILD_DIR)/$(PACK)_stamp_staging_installed. If cmp returns !0 then
> rebuild and update the current version into the stamp-file
>

[Buildroot] [PATCH] Fix nbd compile

[Peter Korsgaard]

>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:

 Thiago> Or libraries could provide a variable that we could use on depends.
 Thiago> At least this way, packages won't be broken if we decide to revamp
 Thiago> some library makefile.

That would only work if we would be careful to let make parse the
library .mk files before applications - And we would also need to get
the order correct for libraries using other libraries.

-- 
Bye, Peter Korsgaard