Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] board/broadcom/northstar: fix building custom images
@ 2024-01-03  6:32 Rafał Miłecki
  2024-01-13 21:04 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2024-01-03  6:32 UTC (permalink / raw)
  To: buildroot; +Cc: Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Custom Northstar images allow installing (flashing) them using vendor UI
or CFE bootloader. Change of DTS files paths ("broadcom/" prefix
introduction) prevented post script from generating them.

Adjust post-image.sh to deal with new paths.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 board/broadcom/northstar/post-image.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/broadcom/northstar/post-image.sh b/board/broadcom/northstar/post-image.sh
index b6150fc539..559ed8bf4b 100755
--- a/board/broadcom/northstar/post-image.sh
+++ b/board/broadcom/northstar/post-image.sh
@@ -27,8 +27,9 @@ build_trx() {
 	rm -f $images/zImage.$device.lzma
 }
 
-devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
+devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([^"]*\)"$/\1/p' ${BR2_CONFIG})"
 for device in $devices; do
+	device="${device#broadcom/}"
 	case "$device" in
 		"bcm4708-smartrg-sr400ac")
 			build_trx "$1" "$device"
-- 
2.35.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] board/broadcom/northstar: fix building custom images
  2024-01-03  6:32 [Buildroot] [PATCH] board/broadcom/northstar: fix building custom images Rafał Miłecki
@ 2024-01-13 21:04 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2024-01-13 21:04 UTC (permalink / raw)
  To: Rafał Miłecki; +Cc: Rafał Miłecki, buildroot

>>>>> "Rafał" == Rafał Miłecki <zajec5@gmail.com> writes:

 > From: Rafał Miłecki <rafal@milecki.pl>
 > Custom Northstar images allow installing (flashing) them using vendor UI
 > or CFE bootloader. Change of DTS files paths ("broadcom/" prefix
 > introduction) prevented post script from generating them.

 > Adjust post-image.sh to deal with new paths.

I was a bit confused what this was about, but I guess it is just about
the addition of the broadcom/ subdir in kernel 6.5+. I've slightly
reworded the commit description and applied, thanks.

 > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
 > ---
 >  board/broadcom/northstar/post-image.sh | 3 ++-
 >  1 file changed, 2 insertions(+), 1 deletion(-)

 > diff --git a/board/broadcom/northstar/post-image.sh b/board/broadcom/northstar/post-image.sh
 > index b6150fc539..559ed8bf4b 100755
 > --- a/board/broadcom/northstar/post-image.sh
 > +++ b/board/broadcom/northstar/post-image.sh
 > @@ -27,8 +27,9 @@ build_trx() {
 >  	rm -f $images/zImage.$device.lzma
 >  }
 
 > -devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
 > +devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([^"]*\)"$/\1/p' ${BR2_CONFIG})"
 >  for device in $devices; do
 > +	device="${device#broadcom/}"
 >  	case "$device" in
 >  		"bcm4708-smartrg-sr400ac")
 >  			build_trx "$1" "$device"
 > -- 

 > 2.35.3

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-13 21:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03  6:32 [Buildroot] [PATCH] board/broadcom/northstar: fix building custom images Rafał Miłecki
2024-01-13 21:04 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox