From: Peter Korsgaard <peter@korsgaard.com>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: Kory Maincent <kory.maincent@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/arm-trusted-firmware: set CFLAGS from environment, not override
Date: Tue, 13 Sep 2022 16:35:15 +0200 [thread overview]
Message-ID: <87fsgvtk9o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220729210444.1787668-1-arnout@mind.be> (Arnout Vandecappelle's message of "Fri, 29 Jul 2022 23:04:44 +0200")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> Older versions of TF-A don't support setting CFLAGS on the make command
> line. They use 'CFLAGS += ...' in the Makefile, which is still
> overridden by the CFLAGS on the command line.
> Fix this by moving the CFLAGS setting to the environment. Both older and
> newer versions of TF-A handle this correctly.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/2781800954
> and a large number of other defconfigs
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Kory Maincent <kory.maincent@bootlin.com>
> ---
> v2: updated commit message to show that it's fine for new versions as
> well.
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-13 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 21:04 [Buildroot] [PATCH] boot/arm-trusted-firmware: set CFLAGS from environment, not override Arnout Vandecappelle (Essensium/Mind)
2022-07-30 15:02 ` Yann E. MORIN
2022-09-13 14:35 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-29 21:02 Arnout Vandecappelle (Essensium/Mind)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsgvtk9o.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox