From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Matt Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
Date: Sun, 03 Jul 2022 19:02:29 +0300 [thread overview]
Message-ID: <87fsjitc82.fsf@tarshish> (raw)
In-Reply-To: <20220703155356.1356910-1-fontaine.fabrice@gmail.com>
Hi Fabrice,
On Sun, Jul 03 2022, Fabrice Fontaine wrote:
> Fix the following build failure without sched_yield raised since bump to
> version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
>
> In file included from easy.c:89:
> easy_lock.h: In function 'curl_simple_lock_lock':
> easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
> 56 | sched_yield();
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> ...de-sched-h-if-available-to-fix-build.patch | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
>
> diff --git a/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> new file mode 100644
> index 0000000000..b5f0a87218
> --- /dev/null
> +++ b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> @@ -0,0 +1,30 @@
> +From e2e7f54b7bea521fa8373095d0f43261a720cda0 Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Mon, 27 Jun 2022 08:46:21 +0200
> +Subject: [PATCH] easy_lock.h: include sched.h if available to fix build
> +
> +Patched-by: Harry Sintonen
> +
> +Closes #9054
> +
> +[Retrieved from:
> +https://github.com/curl/curl/commit/e2e7f54b7bea521fa8373095d0f43261a720cda0]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + lib/easy_lock.h | 3 +++
> + 1 file changed, 3 insertions(+)
> +
> +diff --git a/lib/easy_lock.h b/lib/easy_lock.h
> +index 819f50ce815b8..1f54289ceb2d3 100644
> +--- a/lib/easy_lock.h
> ++++ b/lib/easy_lock.h
> +@@ -36,6 +36,9 @@
> +
> + #elif defined (HAVE_ATOMIC)
> + #include <stdatomic.h>
> ++#if defined(HAVE_SCHED_YIELD)
> ++#include <sched.h>
> ++#endif
> +
> + #define curl_simple_lock atomic_bool
> + #define CURL_SIMPLE_LOCK_INIT false
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-03 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
2022-07-03 16:02 ` Baruch Siach via buildroot [this message]
2022-07-06 22:05 ` Giulio Benetti
2022-07-08 7:33 ` Peter Korsgaard
2022-07-22 7:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsjitc82.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=fontaine.fabrice@gmail.com \
--cc=matthew.weber@collins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox