* [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
@ 2022-07-03 15:53 Fabrice Fontaine
2022-07-03 16:02 ` Baruch Siach via buildroot
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2022-07-03 15:53 UTC (permalink / raw)
To: buildroot; +Cc: Matt Weber, Fabrice Fontaine
Fix the following build failure without sched_yield raised since bump to
version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
In file included from easy.c:89:
easy_lock.h: In function 'curl_simple_lock_lock':
easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
56 | sched_yield();
| ^~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...de-sched-h-if-available-to-fix-build.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
diff --git a/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
new file mode 100644
index 0000000000..b5f0a87218
--- /dev/null
+++ b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
@@ -0,0 +1,30 @@
+From e2e7f54b7bea521fa8373095d0f43261a720cda0 Mon Sep 17 00:00:00 2001
+From: Daniel Stenberg <daniel@haxx.se>
+Date: Mon, 27 Jun 2022 08:46:21 +0200
+Subject: [PATCH] easy_lock.h: include sched.h if available to fix build
+
+Patched-by: Harry Sintonen
+
+Closes #9054
+
+[Retrieved from:
+https://github.com/curl/curl/commit/e2e7f54b7bea521fa8373095d0f43261a720cda0]
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ lib/easy_lock.h | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/lib/easy_lock.h b/lib/easy_lock.h
+index 819f50ce815b8..1f54289ceb2d3 100644
+--- a/lib/easy_lock.h
++++ b/lib/easy_lock.h
+@@ -36,6 +36,9 @@
+
+ #elif defined (HAVE_ATOMIC)
+ #include <stdatomic.h>
++#if defined(HAVE_SCHED_YIELD)
++#include <sched.h>
++#endif
+
+ #define curl_simple_lock atomic_bool
+ #define CURL_SIMPLE_LOCK_INIT false
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
@ 2022-07-03 16:02 ` Baruch Siach via buildroot
2022-07-06 22:05 ` Giulio Benetti
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Baruch Siach via buildroot @ 2022-07-03 16:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Matt Weber, buildroot
Hi Fabrice,
On Sun, Jul 03 2022, Fabrice Fontaine wrote:
> Fix the following build failure without sched_yield raised since bump to
> version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
>
> In file included from easy.c:89:
> easy_lock.h: In function 'curl_simple_lock_lock':
> easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
> 56 | sched_yield();
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> ...de-sched-h-if-available-to-fix-build.patch | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
>
> diff --git a/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> new file mode 100644
> index 0000000000..b5f0a87218
> --- /dev/null
> +++ b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> @@ -0,0 +1,30 @@
> +From e2e7f54b7bea521fa8373095d0f43261a720cda0 Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Mon, 27 Jun 2022 08:46:21 +0200
> +Subject: [PATCH] easy_lock.h: include sched.h if available to fix build
> +
> +Patched-by: Harry Sintonen
> +
> +Closes #9054
> +
> +[Retrieved from:
> +https://github.com/curl/curl/commit/e2e7f54b7bea521fa8373095d0f43261a720cda0]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + lib/easy_lock.h | 3 +++
> + 1 file changed, 3 insertions(+)
> +
> +diff --git a/lib/easy_lock.h b/lib/easy_lock.h
> +index 819f50ce815b8..1f54289ceb2d3 100644
> +--- a/lib/easy_lock.h
> ++++ b/lib/easy_lock.h
> +@@ -36,6 +36,9 @@
> +
> + #elif defined (HAVE_ATOMIC)
> + #include <stdatomic.h>
> ++#if defined(HAVE_SCHED_YIELD)
> ++#include <sched.h>
> ++#endif
> +
> + #define curl_simple_lock atomic_bool
> + #define CURL_SIMPLE_LOCK_INIT false
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
2022-07-03 16:02 ` Baruch Siach via buildroot
@ 2022-07-06 22:05 ` Giulio Benetti
2022-07-08 7:33 ` Peter Korsgaard
2022-07-22 7:39 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2022-07-06 22:05 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Matt Weber
Hi Fabrice,
On 03/07/22 17:53, Fabrice Fontaine wrote:
> Fix the following build failure without sched_yield raised since bump to
> version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
>
> In file included from easy.c:89:
> easy_lock.h: In function 'curl_simple_lock_lock':
> easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
> 56 | sched_yield();
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> ...de-sched-h-if-available-to-fix-build.patch | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
>
> diff --git a/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> new file mode 100644
> index 0000000000..b5f0a87218
> --- /dev/null
> +++ b/package/libcurl/0001-easy_lock-h-include-sched-h-if-available-to-fix-build.patch
> @@ -0,0 +1,30 @@
> +From e2e7f54b7bea521fa8373095d0f43261a720cda0 Mon Sep 17 00:00:00 2001
> +From: Daniel Stenberg <daniel@haxx.se>
> +Date: Mon, 27 Jun 2022 08:46:21 +0200
> +Subject: [PATCH] easy_lock.h: include sched.h if available to fix build
> +
> +Patched-by: Harry Sintonen
> +
> +Closes #9054
> +
> +[Retrieved from:
> +https://github.com/curl/curl/commit/e2e7f54b7bea521fa8373095d0f43261a720cda0]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + lib/easy_lock.h | 3 +++
> + 1 file changed, 3 insertions(+)
> +
> +diff --git a/lib/easy_lock.h b/lib/easy_lock.h
> +index 819f50ce815b8..1f54289ceb2d3 100644
> +--- a/lib/easy_lock.h
> ++++ b/lib/easy_lock.h
> +@@ -36,6 +36,9 @@
> +
> + #elif defined (HAVE_ATOMIC)
> + #include <stdatomic.h>
> ++#if defined(HAVE_SCHED_YIELD)
> ++#include <sched.h>
> ++#endif
> +
> + #define curl_simple_lock atomic_bool
> + #define CURL_SIMPLE_LOCK_INIT false
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
2022-07-03 16:02 ` Baruch Siach via buildroot
2022-07-06 22:05 ` Giulio Benetti
@ 2022-07-08 7:33 ` Peter Korsgaard
2022-07-22 7:39 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-07-08 7:33 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Matt Weber, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure without sched_yield raised since bump to
> version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
> In file included from easy.c:89:
> easy_lock.h: In function 'curl_simple_lock_lock':
> easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
> 56 | sched_yield();
> | ^~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
` (2 preceding siblings ...)
2022-07-08 7:33 ` Peter Korsgaard
@ 2022-07-22 7:39 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-07-22 7:39 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Matt Weber, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure without sched_yield raised since bump to
> version 7.84.0 in commit b034109dd60a429690acf9c5501c6658c53eae13:
> In file included from easy.c:89:
> easy_lock.h: In function 'curl_simple_lock_lock':
> easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [-Werror=implicit-function-declaration]
> 56 | sched_yield();
> | ^~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/fbc80a0002d640210c81a4c518856c02669059b7
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-22 7:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-03 15:53 [Buildroot] [PATCH 1/1] package/libcurl: fix build without sched_yield Fabrice Fontaine
2022-07-03 16:02 ` Baruch Siach via buildroot
2022-07-06 22:05 ` Giulio Benetti
2022-07-08 7:33 ` Peter Korsgaard
2022-07-22 7:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox