* [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC
@ 2019-01-12 9:24 Fabrice Fontaine
2019-01-12 13:55 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-01-12 9:24 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/sunxi-cedarx/sunxi-cedarx.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/sunxi-cedarx/sunxi-cedarx.mk b/package/sunxi-cedarx/sunxi-cedarx.mk
index 219f1bc74b..5b99f04181 100644
--- a/package/sunxi-cedarx/sunxi-cedarx.mk
+++ b/package/sunxi-cedarx/sunxi-cedarx.mk
@@ -19,7 +19,7 @@ SUNXI_CEDARX_BIN_DIR = $(@D)/libcedarv/linux-armel2
endif
define SUNXI_CEDARX_BUILD_AVHEAP
- $(TARGET_CC) $(TARGET_CFLAGS) \
+ $(TARGET_CC) $(TARGET_CFLAGS) -fPIC \
-c $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap/avheap.c \
-o $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap/avheap.o \
-I $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap \
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC
2019-01-12 9:24 [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC Fabrice Fontaine
@ 2019-01-12 13:55 ` Thomas Petazzoni
2019-01-12 15:49 ` Fabrice Fontaine
2019-01-16 12:09 ` Peter Korsgaard
2019-01-24 19:05 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-01-12 13:55 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 12 Jan 2019 10:24:59 +0100, Fabrice Fontaine wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Could you explain why we are seeing such build errors since December
5th, 2018, while the package hasn't been touched since 2016 ? What
changed that makes those errors visible now ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC
2019-01-12 13:55 ` Thomas Petazzoni
@ 2019-01-12 15:49 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-01-12 15:49 UTC (permalink / raw)
To: buildroot
Dear Thomas,
Le sam. 12 janv. 2019 ? 14:55, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello,
>
> On Sat, 12 Jan 2019 10:24:59 +0100, Fabrice Fontaine wrote:
> > Fixes:
> > - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Could you explain why we are seeing such build errors since December
> 5th, 2018, while the package hasn't been touched since 2016 ? What
> changed that makes those errors visible now ?
Yes, the issue is raised only when BR2_OPTIMIZE_2 is set and
autobuilders test -O2 only since December 3rd:
https://git.buildroot.net/buildroot/commit/?id=aa556e2035c023d4328185a46e15df532e566067.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC
2019-01-12 9:24 [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC Fabrice Fontaine
2019-01-12 13:55 ` Thomas Petazzoni
@ 2019-01-16 12:09 ` Peter Korsgaard
2019-01-24 19:05 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-01-16 12:09 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fixes:
> - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC
2019-01-12 9:24 [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC Fabrice Fontaine
2019-01-12 13:55 ` Thomas Petazzoni
2019-01-16 12:09 ` Peter Korsgaard
@ 2019-01-24 19:05 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-01-24 19:05 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fixes:
> - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-24 19:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-12 9:24 [Buildroot] [PATCH 1/1] sunxi-cedarx: needs -fPIC Fabrice Fontaine
2019-01-12 13:55 ` Thomas Petazzoni
2019-01-12 15:49 ` Fabrice Fontaine
2019-01-16 12:09 ` Peter Korsgaard
2019-01-24 19:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox