[Buildroot] [PATCH] linux: change Device Tree prompt

[Buildroot] [PATCH] linux: change Device Tree prompt

[Yann E. MORIN]

The current prompt seems to imply that we want to add Device Tree
support to the Linux kernel:

    [*] Device tree support

But what it really means is that Buildroot will build a DTB.

Change the prompt so that it is obvious that this is the intended
behaviour, and users do not get mislead as to why Device Tree support is
not automatically added to their Linux kernel.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Changes v1 -> v2:
  - tweak help entry to state this can be multiple DTBs  (Thomas)
---
 linux/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux/Config.in b/linux/Config.in
index ba4b574..bf30426 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -269,10 +269,10 @@ config BR2_LINUX_KERNEL_UIMAGE_LOADADDR
 	  If unsure, let this option empty.
 
 config BR2_LINUX_KERNEL_DTS_SUPPORT
-	bool "Device tree support"
+	bool "Build a Device Tree Blob (DTB)"
 	help
-	  Compile a device tree source into a device tree blob.
-	  Select the dts file to compile in the options below.
+	  Compile one or more device tree sources into device tree blobs.
+	  Select the dts files to compile in the options below.
 
 if BR2_LINUX_KERNEL_DTS_SUPPORT
 
-- 
1.9.1

[Buildroot] [PATCH] linux: change Device Tree prompt

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The current prompt seems to imply that we want to add Device Tree
 > support to the Linux kernel:

 >     [*] Device tree support

 > But what it really means is that Buildroot will build a DTB.

 > Change the prompt so that it is obvious that this is the intended
 > behaviour, and users do not get mislead as to why Device Tree support is
 > not automatically added to their Linux kernel.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

 > ---
 > Changes v1 -> v2:
 >   - tweak help entry to state this can be multiple DTBs  (Thomas)

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] linux: change DEvice Tree prompt

[Yann E. MORIN]

The current prompt seem to imp[ly that we want to add Device Tree
support to the Linux kernel:

    [*] Device tree support

But what it really means is that Buildroot will build a DTB.

Change the prompt so that it is obvious that this is the intended
behaviour, and users do not get mislead as to why Device Tree support is
not automatically added to their Linux kernel.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 linux/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux/Config.in b/linux/Config.in
index ba4b574..541002e 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -269,7 +269,7 @@ config BR2_LINUX_KERNEL_UIMAGE_LOADADDR
 	  If unsure, let this option empty.
 
 config BR2_LINUX_KERNEL_DTS_SUPPORT
-	bool "Device tree support"
+	bool "Build a Device Tree Blob (DTB)"
 	help
 	  Compile a device tree source into a device tree blob.
 	  Select the dts file to compile in the options below.
-- 
1.9.1

[Buildroot] [PATCH] linux: change DEvice Tree prompt

[Thomas Petazzoni]

Dear Yann E. MORIN,

Minor typo in title, but another comment below.

On Thu,  1 Jan 2015 23:08:19 +0100, Yann E. MORIN wrote:

>  config BR2_LINUX_KERNEL_DTS_SUPPORT
> -	bool "Device tree support"
> +	bool "Build a Device Tree Blob (DTB)"

We can actually build several DTBs. Is this worth caring about in the
phrasing of the option prompt?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] linux: change DEvice Tree prompt

[Yann E. MORIN]

Thomas, All,

On 2015-01-01 23:14 +0100, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> Minor typo in title, but another comment below.
> 
> On Thu,  1 Jan 2015 23:08:19 +0100, Yann E. MORIN wrote:
> 
> >  config BR2_LINUX_KERNEL_DTS_SUPPORT
> > -	bool "Device tree support"
> > +	bool "Build a Device Tree Blob (DTB)"
> 
> We can actually build several DTBs. Is this worth caring about in the
> phrasing of the option prompt?

Yes, I pondered that for, like, two seconds, and decided to not care.
So, I don't care if you make that a plural before comitting. ;-)

However, making that a "one or more DTBs" thingy would be pretty much
less intelligible, I believe.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'