Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
@ 2008-12-21 17:11 ulf at uclibc.org
  2008-12-23 10:25 ` Peter Korsgaard
  0 siblings, 1 reply; 7+ messages in thread
From: ulf at uclibc.org @ 2008-12-21 17:11 UTC (permalink / raw)
  To: buildroot

Author: ulf
Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
New Revision: 24480

Log:
Allow creating a script for external use of Buildroot toolchain

Added:
   trunk/buildroot/toolchain/export-toolchain/
   trunk/buildroot/toolchain/export-toolchain/Config.in
   trunk/buildroot/toolchain/export-toolchain/Makefile.in

Modified:
   trunk/buildroot/toolchain/Config.in
   trunk/buildroot/toolchain/Makefile.in
   trunk/buildroot/toolchain/uClibc/Config.in


Changeset:
Modified: trunk/buildroot/toolchain/Config.in
===================================================================
--- trunk/buildroot/toolchain/Config.in	2008-12-21 15:34:38 UTC (rev 24479)
+++ trunk/buildroot/toolchain/Config.in	2008-12-21 17:11:33 UTC (rev 24480)
@@ -26,6 +26,8 @@
 	default y if BR2_TOOLCHAIN_BUILDROOT || BR2_TOOLCHAIN_EXTERNAL_SOURCE
 	default n if BR2_TOOLCHAIN_EXTERNAL
 
+source "toolchain/export-toolchain/Config.in"
+
 source "target/device/Config.in.toolchain"
 
 source "toolchain/Config.in.1"

Modified: trunk/buildroot/toolchain/Makefile.in
===================================================================
--- trunk/buildroot/toolchain/Makefile.in	2008-12-21 15:34:38 UTC (rev 24479)
+++ trunk/buildroot/toolchain/Makefile.in	2008-12-21 17:11:33 UTC (rev 24480)
@@ -47,3 +47,5 @@
 # gcc has a bunch of needed stuff....
 include toolchain/gcc/Makefile.in
 
+include toolchain/export-toolchain/Makefile.in
+

Added: trunk/buildroot/toolchain/export-toolchain/Config.in
===================================================================
--- trunk/buildroot/toolchain/export-toolchain/Config.in	                        (rev 0)
+++ trunk/buildroot/toolchain/export-toolchain/Config.in	2008-12-21 17:11:33 UTC (rev 24480)
@@ -0,0 +1,8 @@
+config BR2_EXPORT_TOOLCHAIN
+	bool "Create script exporting toolchain to home directory"
+	default n
+	help
+	  This will generate a batchfile which, if run
+	  will add the Buildroot toolchain to the user PATH
+	  The file is called "$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh"
+

Added: trunk/buildroot/toolchain/export-toolchain/Makefile.in
===================================================================
--- trunk/buildroot/toolchain/export-toolchain/Makefile.in	                        (rev 0)
+++ trunk/buildroot/toolchain/export-toolchain/Makefile.in	2008-12-21 17:11:33 UTC (rev 24480)
@@ -0,0 +1,28 @@
+# This generates a script which exports the toolchain
+# using a shell script
+
+GCC_SCRIPT:=$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh
+GCC_SCRIPT_TEMP:=$(BINARIES_DIR)/$(GCC_SCRIPT)
+
+~/$(GCC_SCRIPT): cross_compiler
+	@echo	"#!/bin/sh"						>	$(GCC_SCRIPT_TEMP)
+	@echo	"# $(ARCH) cross compiler toolchain created $(DATE)"	>>	$(GCC_SCRIPT_TEMP)
+	@echo	"# gcc-$(GCC_VERSION)"					>>	$(GCC_SCRIPT_TEMP)
+	@echo	"# binutils-$(BINUTILS_VERSION)"			>>	$(GCC_SCRIPT_TEMP)
+	@echo	"# uClibc-$(UCLIBC_VERSION)"				>>	$(GCC_SCRIPT_TEMP)
+	@echo	"export	GCCROOT=$(STAGING_DIR)/usr"			>>	$(GCC_SCRIPT_TEMP)
+	@echo	"export	PATH=\$$PATH:\$$GCCROOT/bin"			>>	$(GCC_SCRIPT_TEMP)
+	@echo	"export	CROSS_COMPILE=$(REAL_GNU_TARGET_NAME)-"		>>	$(GCC_SCRIPT_TEMP)
+	@cp	$(GCC_SCRIPT_TEMP) ~/$(GCC_SCRIPT)
+	@cat	~/$(GCC_SCRIPT)
+
+export-toolchain: ~/$(GCC_SCRIPT)
+
+export-toolchain-clean:
+	rm	-f ~/$(GCC_SCRIPT)
+	rm	-f $(GCC_SCRIPT_TEMP)
+
+ifeq ($(BR2_EXPORT_TOOLCHAIN),y)
+TARGETS+=export-toolchain
+endif
+

Modified: trunk/buildroot/toolchain/uClibc/Config.in
===================================================================
--- trunk/buildroot/toolchain/uClibc/Config.in	2008-12-21 15:34:38 UTC (rev 24479)
+++ trunk/buildroot/toolchain/uClibc/Config.in	2008-12-21 17:11:33 UTC (rev 24480)
@@ -27,6 +27,12 @@
 
 endchoice
 
+config UCLIBC_VERSION
+	string
+	default "0.9.28.3"	if BR2_UCLIBC_VERSION_0_9_28_3
+	default "0.9.29"	if BR2_UCLIBC_VERSION_0_9_29
+	default "0.9.30"	if BR2_UCLIBC_VERSION_0_9_30
+	default "snapshot"	if BR2_UCLIBC_VERSION_SNAPSHOT
 
 config BR2_USE_UCLIBC_SNAPSHOT
 	string "Date (yyyymmdd) of snapshot or 'snapshot' for latest"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
  2008-12-21 17:11 [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc ulf at uclibc.org
@ 2008-12-23 10:25 ` Peter Korsgaard
  2009-01-02 20:37   ` Peter Korsgaard
  2009-01-02 22:23   ` Ulf Samuelsson
  0 siblings, 2 replies; 7+ messages in thread
From: Peter Korsgaard @ 2008-12-23 10:25 UTC (permalink / raw)
  To: buildroot

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:

 ulf> Author: ulf
 ulf> Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
 ulf> New Revision: 24480

 ulf> Log:
 ulf> Allow creating a script for external use of Buildroot toolchain

 ulf> Added:
 ulf>    trunk/buildroot/toolchain/export-toolchain/
 ulf>    trunk/buildroot/toolchain/export-toolchain/Config.in
 ulf>    trunk/buildroot/toolchain/export-toolchain/Makefile.in

That seems very specific - What's wrong with the currently documented
way of adding build_$ARCH/staging_dir/usr/bin to the path? Where's the
documentation of this thing?

 ulf> Modified:
 ulf>    trunk/buildroot/toolchain/Config.in
 ulf>    trunk/buildroot/toolchain/Makefile.in
 ulf>    trunk/buildroot/toolchain/uClibc/Config.in

 ulf> +++ trunk/buildroot/toolchain/Makefile.in	2008-12-21 17:11:33 UTC (rev 24480)
 ulf> @@ -47,3 +47,5 @@
 ulf>  # gcc has a bunch of needed stuff....
 ulf>  include toolchain/gcc/Makefile.in
 
 ulf> +include toolchain/export-toolchain/Makefile.in
 ulf> +

This seems to break the build as the dependencies target isn't
executed before the other toolchain stuff - I've disabled it in
r24519.

 ulf> +config BR2_EXPORT_TOOLCHAIN
 ulf> +	bool "Create script exporting toolchain to home directory"
 ulf> +	default n
 ulf> +	help
 ulf> +	  This will generate a batchfile which, if run
 ulf> +	  will add the Buildroot toolchain to the user PATH
 ulf> +	  The file is called "$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh"
 ulf> +

Batchfile? shell script? I take it that you need to source the file
for the changes to take effect?

 ulf> +~/$(GCC_SCRIPT): cross_compiler

I'm not sure ~ in make targets are a good idea.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
@ 2009-01-02 20:31 jacmet at uclibc.org
  0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2009-01-02 20:31 UTC (permalink / raw)
  To: buildroot

Author: jacmet
Date: 2009-01-02 20:31:01 +0000 (Fri, 02 Jan 2009)
New Revision: 24650

Log:
toolchain: revert "Allow creating a script for external use of Buildroot toolchain"

It's been 10 days now without any reply from Ulf, so revert r24480+r24481.

Removed:
   trunk/buildroot/toolchain/export-toolchain/Config.in
   trunk/buildroot/toolchain/export-toolchain/Makefile.in

Modified:
   trunk/buildroot/toolchain/Config.in
   trunk/buildroot/toolchain/Makefile.in
   trunk/buildroot/toolchain/uClibc/Config.in


Changeset:
Modified: trunk/buildroot/toolchain/Config.in
===================================================================
--- trunk/buildroot/toolchain/Config.in	2009-01-02 20:30:54 UTC (rev 24649)
+++ trunk/buildroot/toolchain/Config.in	2009-01-02 20:31:01 UTC (rev 24650)
@@ -26,8 +26,6 @@
 	default y if BR2_TOOLCHAIN_BUILDROOT || BR2_TOOLCHAIN_EXTERNAL_SOURCE
 	default n if BR2_TOOLCHAIN_EXTERNAL
 
-source "toolchain/export-toolchain/Config.in"
-
 source "target/device/Config.in.toolchain"
 
 source "toolchain/Config.in.1"

Modified: trunk/buildroot/toolchain/Makefile.in
===================================================================
--- trunk/buildroot/toolchain/Makefile.in	2009-01-02 20:30:54 UTC (rev 24649)
+++ trunk/buildroot/toolchain/Makefile.in	2009-01-02 20:31:01 UTC (rev 24650)
@@ -46,5 +46,3 @@
 
 # gcc has a bunch of needed stuff....
 include toolchain/gcc/Makefile.in
-# breaks the build
-#include toolchain/export-toolchain/Makefile.in

Deleted: trunk/buildroot/toolchain/export-toolchain/Config.in
===================================================================
--- trunk/buildroot/toolchain/export-toolchain/Config.in	2009-01-02 20:30:54 UTC (rev 24649)
+++ trunk/buildroot/toolchain/export-toolchain/Config.in	2009-01-02 20:31:01 UTC (rev 24650)
@@ -1,8 +0,0 @@
-config BR2_EXPORT_TOOLCHAIN
-	bool "Create script exporting toolchain to home directory"
-	default n
-	help
-	  This will generate a batchfile which, if run
-	  will add the Buildroot toolchain to the user PATH
-	  The file is called "$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh"
-

Deleted: trunk/buildroot/toolchain/export-toolchain/Makefile.in
===================================================================
--- trunk/buildroot/toolchain/export-toolchain/Makefile.in	2009-01-02 20:30:54 UTC (rev 24649)
+++ trunk/buildroot/toolchain/export-toolchain/Makefile.in	2009-01-02 20:31:01 UTC (rev 24650)
@@ -1,29 +0,0 @@
-# This generates a script which exports the toolchain
-# using a shell script
-
-GCC_SCRIPT:=$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh
-GCC_SCRIPT_TEMP:=$(BINARIES_DIR)/$(GCC_SCRIPT)
-
-~/$(GCC_SCRIPT): cross_compiler
-	@echo	"#!/bin/sh"						>	$(GCC_SCRIPT_TEMP)
-	@echo	"# $(ARCH) cross compiler toolchain created $(DATE)"	>>	$(GCC_SCRIPT_TEMP)
-	@echo	"# gcc-$(GCC_VERSION)"					>>	$(GCC_SCRIPT_TEMP)
-	@echo	"# binutils-$(BINUTILS_VERSION)"			>>	$(GCC_SCRIPT_TEMP)
-	@echo	"# uClibc-$(UCLIBC_VERSION)"				>>	$(GCC_SCRIPT_TEMP)
-	@echo	"export	GCCROOT=$(STAGING_DIR)/usr"			>>	$(GCC_SCRIPT_TEMP)
-	@echo	"export	PATH=\$$PATH:\$$GCCROOT/bin"			>>	$(GCC_SCRIPT_TEMP)
-	@echo	"export	CROSS_COMPILE=$(REAL_GNU_TARGET_NAME)-"		>>	$(GCC_SCRIPT_TEMP)
-	@chmod	a+x $(GCC_SCRIPT_TEMP)
-	@cp	$(GCC_SCRIPT_TEMP) ~/$(GCC_SCRIPT)
-	@cat	~/$(GCC_SCRIPT)
-
-export-toolchain: ~/$(GCC_SCRIPT)
-
-export-toolchain-clean:
-	rm	-f ~/$(GCC_SCRIPT)
-	rm	-f $(GCC_SCRIPT_TEMP)
-
-ifeq ($(BR2_EXPORT_TOOLCHAIN),y)
-TARGETS+=export-toolchain
-endif
-

Modified: trunk/buildroot/toolchain/uClibc/Config.in
===================================================================
--- trunk/buildroot/toolchain/uClibc/Config.in	2009-01-02 20:30:54 UTC (rev 24649)
+++ trunk/buildroot/toolchain/uClibc/Config.in	2009-01-02 20:31:01 UTC (rev 24650)
@@ -27,12 +27,6 @@
 
 endchoice
 
-config UCLIBC_VERSION
-	string
-	default "0.9.28.3"	if BR2_UCLIBC_VERSION_0_9_28_3
-	default "0.9.29"	if BR2_UCLIBC_VERSION_0_9_29
-	default "0.9.30"	if BR2_UCLIBC_VERSION_0_9_30
-	default "snapshot"	if BR2_UCLIBC_VERSION_SNAPSHOT
 
 config BR2_USE_UCLIBC_SNAPSHOT
 	string "Date (yyyymmdd) of snapshot or 'snapshot' for latest"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
  2008-12-23 10:25 ` Peter Korsgaard
@ 2009-01-02 20:37   ` Peter Korsgaard
  2009-01-02 21:52     ` Ulf Samuelsson
  2009-01-02 22:23   ` Ulf Samuelsson
  1 sibling, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2009-01-02 20:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:
 ulf> Author: ulf
 ulf> Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
 ulf> New Revision: 24480

 ulf> Log:
 ulf> Allow creating a script for external use of Buildroot toolchain

It's been 10 days now, and it has been disabled in Kconfig since then,
so I'll revert the commit.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
  2009-01-02 20:37   ` Peter Korsgaard
@ 2009-01-02 21:52     ` Ulf Samuelsson
  2009-01-02 22:20       ` Peter Korsgaard
  0 siblings, 1 reply; 7+ messages in thread
From: Ulf Samuelsson @ 2009-01-02 21:52 UTC (permalink / raw)
  To: buildroot

> ulf> Author: ulf
> ulf> Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
> ulf> New Revision: 24480
>
> ulf> Log:
> ulf> Allow creating a script for external use of Buildroot toolchain
>
> It's been 10 days now, and it has been disabled in Kconfig since then,
> so I'll revert the commit.

Why disable it?
I find this pretty useful.

>
> -- 
> Bye, Peter Korsgaard
>


Best Regards
Ulf Samuelsson                ulf at atmel.com
Atmel Nordic AB
Mail:  Box 2033, 174 02 Sundbyberg, Sweden
Visit:  Kavalleriv?gen 24, 174 58 Sundbyberg, Sweden
Phone +46 (8) 441 54 22     Fax +46 (8) 441 54 29
GSM    +46 (706) 22 44 57

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
  2009-01-02 21:52     ` Ulf Samuelsson
@ 2009-01-02 22:20       ` Peter Korsgaard
  0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2009-01-02 22:20 UTC (permalink / raw)
  To: buildroot

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

 ulf> Author: ulf
 ulf> Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
 ulf> New Revision: 24480
 >> 
 ulf> Log:
 ulf> Allow creating a script for external use of Buildroot toolchain
 >> 
 >> It's been 10 days now, and it has been disabled in Kconfig since then,
 >> so I'll revert the commit.

 Ulf> Why disable it?
 Ulf> I find this pretty useful.

Because it broke the build, see the mail I sent on the 23th + svn.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc
  2008-12-23 10:25 ` Peter Korsgaard
  2009-01-02 20:37   ` Peter Korsgaard
@ 2009-01-02 22:23   ` Ulf Samuelsson
  1 sibling, 0 replies; 7+ messages in thread
From: Ulf Samuelsson @ 2009-01-02 22:23 UTC (permalink / raw)
  To: buildroot

tis 2008-12-23 klockan 11:25 +0100 skrev Peter Korsgaard:
> >>>>> "ulf" == ulf  <ulf@uclibc.org> writes:
> 
>  ulf> Author: ulf
>  ulf> Date: 2008-12-21 17:11:33 +0000 (Sun, 21 Dec 2008)
>  ulf> New Revision: 24480
> 
>  ulf> Log:
>  ulf> Allow creating a script for external use of Buildroot toolchain
> 
>  ulf> Added:
>  ulf>    trunk/buildroot/toolchain/export-toolchain/
>  ulf>    trunk/buildroot/toolchain/export-toolchain/Config.in
>  ulf>    trunk/buildroot/toolchain/export-toolchain/Makefile.in
> 
> That seems very specific - What's wrong with the currently documented
> way of adding build_$ARCH/staging_dir/usr/bin to the path? Where's the
> documentation of this thing?

Sorry about the late answer.
Have had a disk crash and did not install the account
for reading buildroot mail until after the holidays.

Adding a path is manual and error prone.
This is more productive since you can with a single 
click create something that works.

You can of course also have several toolchains, 
and select which you want at a specific time.

> 
>  ulf> Modified:
>  ulf>    trunk/buildroot/toolchain/Config.in
>  ulf>    trunk/buildroot/toolchain/Makefile.in
>  ulf>    trunk/buildroot/toolchain/uClibc/Config.in
> 
>  ulf> +++ trunk/buildroot/toolchain/Makefile.in	2008-12-21 17:11:33 UTC (rev 24480)
>  ulf> @@ -47,3 +47,5 @@
>  ulf>  # gcc has a bunch of needed stuff....
>  ulf>  include toolchain/gcc/Makefile.in
>  
>  ulf> +include toolchain/export-toolchain/Makefile.in
>  ulf> +
> 
> This seems to break the build as the dependencies target isn't
> executed before the other toolchain stuff - I've disabled it in
> r24519.


What exactly is broken?
"Seems do" != "does".
Have you tested and found that you cannot build a toolchain or what??


> 
>  ulf> +config BR2_EXPORT_TOOLCHAIN
>  ulf> +	bool "Create script exporting toolchain to home directory"
>  ulf> +	default n
>  ulf> +	help
>  ulf> +	  This will generate a batchfile which, if run
>  ulf> +	  will add the Buildroot toolchain to the user PATH
>  ulf> +	  The file is called "$(ARCH)-uclibc-gcc-$(GCC_VERSION).sh"
>  ulf> +
> 
> Batchfile? shell script? I take it that you need to source the file
> for the changes to take effect?

Exactly.


> 
>  ulf> +~/$(GCC_SCRIPT): cross_compiler
> 
> I'm not sure ~ in make targets are a good idea.
> 

If you want to have a script file in your top directory, why not?
It is a possibility to fix so that it gets built in a subdirectory
to ~ as well or by defining a BUILDROOT_<XXX> shell variable 
and install it in $(BUILDROOT_XXX)/?$(GCC_SCRIPT).

/Ulf

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-01-02 22:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-21 17:11 [Buildroot] svn commit: trunk/buildroot/toolchain: export-toolchain uClibc ulf at uclibc.org
2008-12-23 10:25 ` Peter Korsgaard
2009-01-02 20:37   ` Peter Korsgaard
2009-01-02 21:52     ` Ulf Samuelsson
2009-01-02 22:20       ` Peter Korsgaard
2009-01-02 22:23   ` Ulf Samuelsson
  -- strict thread matches above, loose matches on Subject: below --
2009-01-02 20:31 jacmet at uclibc.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox