Re: [Buildroot] [PATCH v4 RESEND 2/3] package/python-snappy: bump version to 0.7.2

From: Peter Korsgaard <peter@korsgaard.com>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Julien Olivain <ju.o@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 RESEND 2/3] package/python-snappy: bump version to 0.7.2
Date: Wed, 14 Oct 2026 18:44:09 +0200	[thread overview]
Message-ID: <87h5ios04m.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20261013185348.7666-1-flaviu.nistor@gmail.com> (Flaviu Nistor's message of "Tue, 13 Oct 2026 21:53:48 +0300")

>>>>> "Flaviu" == Flaviu Nistor <flaviu.nistor@gmail.com> writes:

 > On Sun, Oct 11, 2026 at 1:12 PM, Peter Korsgaard wrote:
 >>> Even if there is a 0.7.3 on Pypi, there is no 0.7.3 release
 >>> on the project homepage, hence the bump to 0.7.2.
 >> 
 >> How about contacting the author about the 0.7.3 tag?

 > I will try to contact. In previous situations when I send out a bump
 > it was indicated that I should use a Pypi release only if the tag is
 > released also on the repo. I think also in this case is better to have
 > the bump to 0.7.2 until 0.7.3 is released in the maintainer repo. 

Sure, but we can do both, E.G. use 0.7.2 for now but also make 0.7.3
available for the future.

 >> It is good that you add yourself to DEVELOPERS, but the
 >> click/rich/smmap2 additions belong in a separate commit.
 >> 

 > I just wanted to avoid some "noise" caused by separate patch, but yes,
 > you are right this would be the better approach. I will change this in v5.

Great!

 >>> -PYTHON_SNAPPY_VERSION = 0.6.1
 >>> -PYTHON_SNAPPY_SITE =
 >>> https://files.pythonhosted.org/packages/98/7a/44a24bad98335b2c72e4cadcdecf79f50197d1bab9f22f863a274f104b96
 >>> +PYTHON_SNAPPY_VERSION = 0.7.2
 >>> +PYTHON_SNAPPY_SOURCE = python_snappy-$(PYTHON_SNAPPY_VERSION).tar.gz
 >>> +PYTHON_SNAPPY_SITE =
 >>> https://files.pythonhosted.org/packages/cb/52/acd87583175fa930e4385f8a6164eb5909acd683c0e62ee01d41de8195a2
 >>> PYTHON_SNAPPY_SETUP_TYPE = setuptools
 >>> PYTHON_SNAPPY_LICENSE = BSD-3-Clause
 >>> PYTHON_SNAPPY_LICENSE_FILES = LICENSE
 >>> -PYTHON_SNAPPY_DEPENDENCIES = snappy
 >>> +PYTHON_SNAPPY_DEPENDENCIES = host-python-cramjam python-cramjam
 >> 
 >> Why do we need host-python-cramjam? Please describe that in the commit message.

 > This is a setup_requires in the setup.py (cramjam>=2.6.0). There is a build fail without it.

OK, why is this? Is something generated at build time?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot