* [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal
@ 2017-05-06 0:51 Danomi Manchego
2017-05-06 8:55 ` Peter Korsgaard
2017-05-15 9:43 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Danomi Manchego @ 2017-05-06 0:51 UTC (permalink / raw)
To: buildroot
There was already a post-build hook to delete the /var/lib/dbus symlink
created by buildroot after the package's own installation, to prevent
a dbus installation error during "make dbus-rebuild". However, this
misses the case for when one might delete the .stamp_target_installed
file manually, outside of dbus-rebuild. This can be fixed by changing
the post-build hook to a pre-install hook. This seems appropriate,
since it is really addressing an installation issue, not a build issue.
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
package/dbus/dbus.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dbus/dbus.mk b/package/dbus/dbus.mk
index d333b20..ce40329 100644
--- a/package/dbus/dbus.mk
+++ b/package/dbus/dbus.mk
@@ -82,7 +82,7 @@ define DBUS_REMOVE_VAR_LIB_DBUS
rm -rf $(TARGET_DIR)/var/lib/dbus
endef
-DBUS_POST_BUILD_HOOKS += DBUS_REMOVE_VAR_LIB_DBUS
+DBUS_PRE_INSTALL_TARGET_HOOKS += DBUS_REMOVE_VAR_LIB_DBUS
define DBUS_REMOVE_DEVFILES
rm -rf $(TARGET_DIR)/usr/lib/dbus-1.0
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal
2017-05-06 0:51 [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal Danomi Manchego
@ 2017-05-06 8:55 ` Peter Korsgaard
2017-05-15 9:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-05-06 8:55 UTC (permalink / raw)
To: buildroot
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:
> There was already a post-build hook to delete the /var/lib/dbus symlink
> created by buildroot after the package's own installation, to prevent
> a dbus installation error during "make dbus-rebuild". However, this
> misses the case for when one might delete the .stamp_target_installed
> file manually, outside of dbus-rebuild. This can be fixed by changing
> the post-build hook to a pre-install hook. This seems appropriate,
> since it is really addressing an installation issue, not a build issue.
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal
2017-05-06 0:51 [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal Danomi Manchego
2017-05-06 8:55 ` Peter Korsgaard
@ 2017-05-15 9:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-05-15 9:43 UTC (permalink / raw)
To: buildroot
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:
> There was already a post-build hook to delete the /var/lib/dbus symlink
> created by buildroot after the package's own installation, to prevent
> a dbus installation error during "make dbus-rebuild". However, this
> misses the case for when one might delete the .stamp_target_installed
> file manually, outside of dbus-rebuild. This can be fixed by changing
> the post-build hook to a pre-install hook. This seems appropriate,
> since it is really addressing an installation issue, not a build issue.
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-15 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-06 0:51 [Buildroot] [PATCH 1/1] dbus: fix dbus symlink removal Danomi Manchego
2017-05-06 8:55 ` Peter Korsgaard
2017-05-15 9:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox