[Buildroot] [PATCH 0/2] Fix build of shared libraries

[Buildroot] [PATCH 0/2] Fix build of shared libraries

[Luca Ceresoli]

Hi,

009d8fceab4 and 0a5e5534cbf8 broke shared library building for those AUTOTOOLS
packaged that override _CONFIGURE_CMDS.

According to my grep'ing, the affetced packages should be only ffmpeg and
berkeleydb. These two patched fixes them.

Please note I only could test ffmpeg, but the change is pretty trivial so
hopefully it works for berkeleydb as well.

Luca

Luca Ceresoli (2):
  ffmpeg: fix build of shared libraries
  berkeleydb: fix build of shared libraries

 package/berkeleydb/berkeleydb.mk    |    1 +
 package/multimedia/ffmpeg/ffmpeg.mk |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

-- 
1.7.4.1

[Buildroot] [PATCH 1/2] ffmpeg: fix build of shared libraries

[Luca Ceresoli]

009d8fceab4 and 0a5e5534cbf8 moved the --enable-static configure flag
from package files to the default _CONFIGURE_CMDS in
package/Makefile.autotools.in.
This broke Autotools packages that override _CONFIGURE_CMDS.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/multimedia/ffmpeg/ffmpeg.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/multimedia/ffmpeg/ffmpeg.mk b/package/multimedia/ffmpeg/ffmpeg.mk
index babb16a..b50503b 100644
--- a/package/multimedia/ffmpeg/ffmpeg.mk
+++ b/package/multimedia/ffmpeg/ffmpeg.mk
@@ -167,6 +167,7 @@ define FFMPEG_CONFIGURE_CMDS
 		--arch=$(BR2_ARCH) \
 		--target-os=linux \
 		--extra-cflags=-fPIC \
+		$(SHARED_STATIC_LIBS_OPTS) \
 		$(FFMPEG_CONF_OPT) \
 	)
 endef
-- 
1.7.4.1

[Buildroot] [PATCH 2/2] berkeleydb: fix build of shared libraries

[Luca Ceresoli]

009d8fceab4 and 0a5e5534cbf8 moved the --enable-static configure flag
from package files to the default _CONFIGURE_CMDS in
package/Makefile.autotools.in.
This broke Autotools packages that override _CONFIGURE_CMDS.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/berkeleydb/berkeleydb.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk
index 1bac745..e80f66f 100644
--- a/package/berkeleydb/berkeleydb.mk
+++ b/package/berkeleydb/berkeleydb.mk
@@ -38,6 +38,7 @@ define BERKELEYDB_CONFIGURE_CMDS
 		--disable-rpc \
 		--disable-tcl \
 		--disable-compat185 \
+		$(SHARED_STATIC_LIBS_OPTS) \
 		--with-pic \
 	)
 	$(SED) 's/\.lo/.o/g' $(@D)/build_unix/Makefile
-- 
1.7.4.1

[Buildroot] [PATCH 0/2] Fix build of shared libraries

[Peter Korsgaard]

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 Luca> Hi,

 Luca> 009d8fceab4 and 0a5e5534cbf8 broke shared library building for
 Luca> those AUTOTOOLS packaged that override _CONFIGURE_CMDS.

 Luca> According to my grep'ing, the affetced packages should be only ffmpeg and
 Luca> berkeleydb. These two patched fixes them.

 Luca> Please note I only could test ffmpeg, but the change is pretty trivial so
 Luca> hopefully it works for berkeleydb as well.

Good catch - Committed both, thanks!

-- 
Bye, Peter Korsgaard