* [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix
@ 2009-12-15 11:08 Thomas Petazzoni
2009-12-15 11:08 ` [Buildroot] [PATCH 1/1] gcc: do not pass --with-pkgversion to gcc < 4.3 Thomas Petazzoni
2009-12-15 11:39 ` [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2009-12-15 11:08 UTC (permalink / raw)
To: buildroot
The following changes since commit 687d0958a31f6aee8e8e4d26360961327049d9a8:
Peter Korsgaard (1):
toolchain/uClibc: avr32 patch should apply to 0.9.30.1
are available in the git repository at:
git://git.busybox.net/~tpetazzoni/git/buildroot gcc-pkgversion-fix
Thomas Petazzoni (1):
gcc: do not pass --with-pkgversion to gcc < 4.3
toolchain/gcc/gcc-uclibc-4.x.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Thanks,
--
Thomas Petazzoni
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] gcc: do not pass --with-pkgversion to gcc < 4.3
2009-12-15 11:08 [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Thomas Petazzoni
@ 2009-12-15 11:08 ` Thomas Petazzoni
2009-12-15 11:39 ` [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2009-12-15 11:08 UTC (permalink / raw)
To: buildroot
Commit 09c181f2891276c458de327d241151bab38bde0f added new options
passed to gcc configure to set --with-pkgversion and --with-bugurl, to
gcc >= gcc 4.3. To check this, it was checking that the GCC_VERSION
string does not contain 4.2.
Unfortunately, the test is bogus. It does a findstring on x4.2. (with
a final dot) but compares the result with x4.2 (without the final
dot).
The result is that even with 4.2 versions, the test was true, leading
--with-pkgversion and --with-bugurl being passed to gcc's configure
script.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
toolchain/gcc/gcc-uclibc-4.x.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
index 32f7a1e..6f65cb3 100644
--- a/toolchain/gcc/gcc-uclibc-4.x.mk
+++ b/toolchain/gcc/gcc-uclibc-4.x.mk
@@ -45,7 +45,7 @@ GCC_NO_MPFR:=y
endif
# Branding works on >= 4.3
-ifneq ($(findstring x4.2.,x$(GCC_VERSION)),x4.2)
+ifneq ($(findstring x4.2.,x$(GCC_VERSION)),x4.2.)
BUILDROOT_VERSION_STRING=$(call qstrip,$(BR2_VERSION))
EXTRA_GCC_CONFIG_OPTIONS+=--with-pkgversion="Buildroot $(BUILDROOT_VERSION_STRING)" \
--with-bugurl="http://bugs.buildroot.net/"
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix
2009-12-15 11:08 [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Thomas Petazzoni
2009-12-15 11:08 ` [Buildroot] [PATCH 1/1] gcc: do not pass --with-pkgversion to gcc < 4.3 Thomas Petazzoni
@ 2009-12-15 11:39 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2009-12-15 11:39 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> The following changes since commit 687d0958a31f6aee8e8e4d26360961327049d9a8:
Thomas> Peter Korsgaard (1):
Thomas> toolchain/uClibc: avr32 patch should apply to 0.9.30.1
Pulled and pushed, thanks!
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-15 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 11:08 [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Thomas Petazzoni
2009-12-15 11:08 ` [Buildroot] [PATCH 1/1] gcc: do not pass --with-pkgversion to gcc < 4.3 Thomas Petazzoni
2009-12-15 11:39 ` [Buildroot] [pull request] Pull request for branch gcc-pkgversion-fix Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox