[Buildroot] svn commit: [26202] trunk/buildroot/toolchain/uClibc

[Buildroot] svn commit: [26202] trunk/buildroot/toolchain/uClibc

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-04-24 18:42:18 +0000 (Fri, 24 Apr 2009)
New Revision: 26202

Log:
toolchain/uClibc: 0.9.30.1 getaddrinfo fix for intfs without address

From uClibc r24336.

Added:
   trunk/buildroot/toolchain/uClibc/uClibc-0.9.30.1-fix-getaddrinfo.patch


Changeset:
Added: trunk/buildroot/toolchain/uClibc/uClibc-0.9.30.1-fix-getaddrinfo.patch
===================================================================
--- trunk/buildroot/toolchain/uClibc/uClibc-0.9.30.1-fix-getaddrinfo.patch	                        (rev 0)
+++ trunk/buildroot/toolchain/uClibc/uClibc-0.9.30.1-fix-getaddrinfo.patch	2009-04-24 18:42:18 UTC (rev 26202)
@@ -0,0 +1,13 @@
+[PATCH]: runp->ifa_addr can be NULL. Backport of r24336.
+diff -Narup uClibc-0.9.30.1.orig/libc/inet/getaddrinfo.c uClibc-0.9.30.1/libc/inet/getaddrinfo.c
+--- uClibc-0.9.30.1.orig/libc/inet/getaddrinfo.c	2009-02-26 21:49:14.000000000 +0900
++++ uClibc-0.9.30.1/libc/inet/getaddrinfo.c	2009-03-06 00:59:23.000000000 +0900
+@@ -187,6 +187,8 @@ static unsigned __check_pf(void)
+ 		}
+ 
+ 		for (runp = ifa; runp != NULL; runp = runp->ifa_next) {
++			if (runp->ifa_addr == NULL)
++				continue;
+ #if defined __UCLIBC_HAS_IPV4__
+ 			if (runp->ifa_addr->sa_family == PF_INET)
+ 				seen |= SEEN_IPV4;

[Buildroot] svn commit: [26202] trunk/buildroot/toolchain/uClibc

[Sven Neumann]

Hi,

On Fri, 2009-04-24 at 18:42 +0000, jacmet at uclibc.org wrote:
> Author: jacmet
> Date: 2009-04-24 18:42:18 +0000 (Fri, 24 Apr 2009)
> New Revision: 26202
> 
> Log:
> toolchain/uClibc: 0.9.30.1 getaddrinfo fix for intfs without address

Does this fix the issues that are the reason for
UCLIBC_SUPPORT_AI_ADDRCONFIG not being enabled by default or is this
unrelated? Otherwise perhaps the default could be changed now, which
would us allow to get the gupnp stack into buildroot (see
https://bugs.busybox.net/show_bug.cgi?id=35).


Sven

[Buildroot] svn commit: [26202] trunk/buildroot/toolchain/uClibc

[Peter Korsgaard]

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

 Sven> Hi,
 Sven> On Fri, 2009-04-24 at 18:42 +0000, jacmet at uclibc.org wrote:
 >> Author: jacmet
 >> Date: 2009-04-24 18:42:18 +0000 (Fri, 24 Apr 2009)
 >> New Revision: 26202
 >> 
 >> Log:
 >> toolchain/uClibc: 0.9.30.1 getaddrinfo fix for intfs without address

 Sven> Does this fix the issues that are the reason for
 Sven> UCLIBC_SUPPORT_AI_ADDRCONFIG not being enabled by default or is this
 Sven> unrelated? Otherwise perhaps the default could be changed now, which
 Sven> would us allow to get the gupnp stack into buildroot (see
 Sven> https://bugs.busybox.net/show_bug.cgi?id=35).

I don't think so. This fixes a runtime crash with interfaces without a
configured address, and the SUPPORT_AI_ADDRCONFIG thing was a build
time breakage.

But I'll give it a test.

-- 
Bye, Peter Korsgaard