[Buildroot] [PATCH 01/31] package/busybox: move the hush config in a fragment

[Buildroot] [PATCH 01/31] package/busybox: move the hush config in a fragment

[Francois Perrad]

by this way, the busybox-minimal.config becomes more widely usable

at this time, busybox-minimal.config is the default for no-mmu
so, busybox-hush.fragment must be also a default for no-mmu

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/busybox/Config.in              |   1 +
 package/busybox/busybox-hush.fragment  |  51 ++++++++++++
 package/busybox/busybox-minimal.config | 109 +++++++++++++------------
 3 files changed, 107 insertions(+), 54 deletions(-)
 create mode 100644 package/busybox/busybox-hush.fragment

diff --git a/package/busybox/Config.in b/package/busybox/Config.in
index 3c2aa515f..819cc2c4c 100644
--- a/package/busybox/Config.in
+++ b/package/busybox/Config.in
@@ -25,6 +25,7 @@ config BR2_PACKAGE_BUSYBOX_CONFIG
 
 config BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES
 	string "Additional BusyBox configuration fragment files"
+	default "package/busybox/busybox-hush.fragment" if !BR2_USE_MMU
 	help
 	  A space-separated list of configuration fragment files,
 	  that will be merged to the main BusyBox configuration file.
diff --git a/package/busybox/busybox-hush.fragment b/package/busybox/busybox-hush.fragment
new file mode 100644
index 000000000..e1ac47cce
--- /dev/null
+++ b/package/busybox/busybox-hush.fragment
@@ -0,0 +1,51 @@
+# this fragment allows to switch from `ash` to `hush`
+#   - `ash` is the most complete, it's a derivative of the Debian `dash`
+#   - `hush` works on no-mmu systems, but its syntax is not "standard"
+
+# CONFIG_SH_IS_ASH is not set
+CONFIG_SH_IS_HUSH=y
+# CONFIG_SH_IS_NONE is not set
+
+# CONFIG_BASH_IS_ASH is not set
+# CONFIG_BASH_IS_HUSH is not set
+CONFIG_BASH_IS_NONE=y
+
+# CONFIG_SHELL_ASH is not set
+
+CONFIG_HUSH=y
+CONFIG_SHELL_HUSH=y
+CONFIG_HUSH_BASH_COMPAT=y
+CONFIG_HUSH_BRACE_EXPANSION=y
+# CONFIG_HUSH_BASH_SOURCE_CURDIR is not set
+CONFIG_HUSH_LINENO_VAR=y
+CONFIG_HUSH_INTERACTIVE=y
+CONFIG_HUSH_SAVEHISTORY=y
+CONFIG_HUSH_JOB=y
+CONFIG_HUSH_TICK=y
+CONFIG_HUSH_IF=y
+CONFIG_HUSH_LOOPS=y
+CONFIG_HUSH_CASE=y
+CONFIG_HUSH_FUNCTIONS=y
+CONFIG_HUSH_LOCAL=y
+CONFIG_HUSH_RANDOM_SUPPORT=y
+CONFIG_HUSH_MODE_X=y
+CONFIG_HUSH_ECHO=y
+CONFIG_HUSH_PRINTF=y
+CONFIG_HUSH_TEST=y
+CONFIG_HUSH_HELP=y
+CONFIG_HUSH_EXPORT=y
+CONFIG_HUSH_EXPORT_N=y
+CONFIG_HUSH_READONLY=y
+CONFIG_HUSH_KILL=y
+CONFIG_HUSH_WAIT=y
+CONFIG_HUSH_COMMAND=y
+CONFIG_HUSH_TRAP=y
+CONFIG_HUSH_TYPE=y
+CONFIG_HUSH_TIMES=y
+CONFIG_HUSH_READ=y
+CONFIG_HUSH_SET=y
+CONFIG_HUSH_UNSET=y
+CONFIG_HUSH_ULIMIT=y
+CONFIG_HUSH_UMASK=y
+CONFIG_HUSH_GETOPTS=y
+# CONFIG_HUSH_MEMLEAK is not set
diff --git a/package/busybox/busybox-minimal.config b/package/busybox/busybox-minimal.config
index 1e7ad1d35..cf53c1598 100644
--- a/package/busybox/busybox-minimal.config
+++ b/package/busybox/busybox-minimal.config
@@ -1115,68 +1115,69 @@ CONFIG_SVOK=y
 #
 # Shells
 #
-# CONFIG_SH_IS_ASH is not set
-CONFIG_SH_IS_HUSH=y
+CONFIG_SH_IS_ASH=y
+# CONFIG_SH_IS_HUSH is not set
 # CONFIG_SH_IS_NONE is not set
 # CONFIG_BASH_IS_ASH is not set
 # CONFIG_BASH_IS_HUSH is not set
 CONFIG_BASH_IS_NONE=y
-# CONFIG_SHELL_ASH is not set
-# CONFIG_ASH is not set
-# CONFIG_ASH_OPTIMIZE_FOR_SIZE is not set
-# CONFIG_ASH_INTERNAL_GLOB is not set
-# CONFIG_ASH_BASH_COMPAT is not set
+CONFIG_SHELL_ASH=y
+CONFIG_ASH=y
+CONFIG_ASH_OPTIMIZE_FOR_SIZE=y
+CONFIG_ASH_INTERNAL_GLOB=y
+CONFIG_ASH_BASH_COMPAT=y
 # CONFIG_ASH_BASH_SOURCE_CURDIR is not set
-# CONFIG_ASH_BASH_NOT_FOUND_HOOK is not set
-# CONFIG_ASH_JOB_CONTROL is not set
-# CONFIG_ASH_ALIAS is not set
-# CONFIG_ASH_RANDOM_SUPPORT is not set
-# CONFIG_ASH_EXPAND_PRMT is not set
-# CONFIG_ASH_IDLE_TIMEOUT is not set
+CONFIG_ASH_BASH_NOT_FOUND_HOOK=y
+CONFIG_ASH_JOB_CONTROL=y
+CONFIG_ASH_ALIAS=y
+CONFIG_ASH_RANDOM_SUPPORT=y
+CONFIG_ASH_EXPAND_PRMT=y
+CONFIG_ASH_IDLE_TIMEOUT=y
 # CONFIG_ASH_MAIL is not set
-# CONFIG_ASH_ECHO is not set
-# CONFIG_ASH_PRINTF is not set
-# CONFIG_ASH_TEST is not set
-# CONFIG_ASH_HELP is not set
-# CONFIG_ASH_GETOPTS is not set
-# CONFIG_ASH_CMDCMD is not set
+CONFIG_ASH_ECHO=y
+CONFIG_ASH_PRINTF=y
+CONFIG_ASH_TEST=y
+CONFIG_ASH_SLEEP=y
+CONFIG_ASH_HELP=y
+CONFIG_ASH_GETOPTS=y
+CONFIG_ASH_CMDCMD=y
 # CONFIG_CTTYHACK is not set
-CONFIG_HUSH=y
-CONFIG_SHELL_HUSH=y
-CONFIG_HUSH_BASH_COMPAT=y
-CONFIG_HUSH_BRACE_EXPANSION=y
+# CONFIG_HUSH is not set
+# CONFIG_SHELL_HUSH is not set
+# CONFIG_HUSH_BASH_COMPAT is not set
+# CONFIG_HUSH_BRACE_EXPANSION is not set
 # CONFIG_HUSH_BASH_SOURCE_CURDIR is not set
-CONFIG_HUSH_LINENO_VAR=y
-CONFIG_HUSH_INTERACTIVE=y
-CONFIG_HUSH_SAVEHISTORY=y
-CONFIG_HUSH_JOB=y
-CONFIG_HUSH_TICK=y
-CONFIG_HUSH_IF=y
-CONFIG_HUSH_LOOPS=y
-CONFIG_HUSH_CASE=y
-CONFIG_HUSH_FUNCTIONS=y
-CONFIG_HUSH_LOCAL=y
-CONFIG_HUSH_RANDOM_SUPPORT=y
-CONFIG_HUSH_MODE_X=y
-CONFIG_HUSH_ECHO=y
-CONFIG_HUSH_PRINTF=y
-CONFIG_HUSH_TEST=y
-CONFIG_HUSH_HELP=y
-CONFIG_HUSH_EXPORT=y
-CONFIG_HUSH_EXPORT_N=y
-CONFIG_HUSH_READONLY=y
-CONFIG_HUSH_KILL=y
-CONFIG_HUSH_WAIT=y
-CONFIG_HUSH_COMMAND=y
-CONFIG_HUSH_TRAP=y
-CONFIG_HUSH_TYPE=y
-CONFIG_HUSH_TIMES=y
-CONFIG_HUSH_READ=y
-CONFIG_HUSH_SET=y
-CONFIG_HUSH_UNSET=y
-CONFIG_HUSH_ULIMIT=y
-CONFIG_HUSH_UMASK=y
-CONFIG_HUSH_GETOPTS=y
+# CONFIG_HUSH_LINENO_VAR is not set
+# CONFIG_HUSH_INTERACTIVE is not set
+# CONFIG_HUSH_SAVEHISTORY is not set
+# CONFIG_HUSH_JOB is not set
+# CONFIG_HUSH_TICK is not set
+# CONFIG_HUSH_IF is not set
+# CONFIG_HUSH_LOOPS is not set
+# CONFIG_HUSH_CASE is not set
+# CONFIG_HUSH_FUNCTIONS is not set
+# CONFIG_HUSH_LOCAL is not set
+# CONFIG_HUSH_RANDOM_SUPPORT is not set
+# CONFIG_HUSH_MODE_X is not set
+# CONFIG_HUSH_ECHO is not set
+# CONFIG_HUSH_PRINTF is not set
+# CONFIG_HUSH_TEST is not set
+# CONFIG_HUSH_HELP is not set
+# CONFIG_HUSH_EXPORT is not set
+# CONFIG_HUSH_EXPORT_N is not set
+# CONFIG_HUSH_READONLY is not set
+# CONFIG_HUSH_KILL is not set
+# CONFIG_HUSH_WAIT is not set
+# CONFIG_HUSH_COMMAND is not set
+# CONFIG_HUSH_TRAP is not set
+# CONFIG_HUSH_TYPE is not set
+# CONFIG_HUSH_TIMES is not set
+# CONFIG_HUSH_READ is not set
+# CONFIG_HUSH_SET is not set
+# CONFIG_HUSH_UNSET is not set
+# CONFIG_HUSH_ULIMIT is not set
+# CONFIG_HUSH_UMASK is not set
+# CONFIG_HUSH_GETOPTS is not set
 # CONFIG_HUSH_MEMLEAK is not set
 
 #
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 02/31] package/busybox: handle LIBFOO_BUSYBOX_CONFIG_FIXUPS

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 docs/manual/adding-packages-generic.adoc | 6 ++++++
 package/busybox/busybox.mk               | 1 +
 package/pkg-generic.mk                   | 3 +++
 3 files changed, 10 insertions(+)

diff --git a/docs/manual/adding-packages-generic.adoc b/docs/manual/adding-packages-generic.adoc
index 9d365a10c..71712d465 100644
--- a/docs/manual/adding-packages-generic.adoc
+++ b/docs/manual/adding-packages-generic.adoc
@@ -631,6 +631,12 @@ different steps of the build process.
   This is seldom used, as package usually have no strict requirements on
   the kernel options.
 
+* +LIBFOO_BUSYBOX_CONFIG_FIXUPS+ lists the Busybox configuration
+  options that are needed to use this package especially in some scripts,
+  or at contrario the useless options. This shall be a set of
+  calls to one of the kconfig tweaking option: `KCONFIG_ENABLE_OPT`,
+  `KCONFIG_DISABLE_OPT`, or `KCONFIG_SET_OPT`.
+
 The preferred way to define these variables is:
 
 ----------------------
diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index eb5e7ad92..fea925b50 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -384,6 +384,7 @@ define BUSYBOX_KCONFIG_FIXUP_CMDS
 	$(BUSYBOX_SET_SELINUX)
 	$(BUSYBOX_SET_LESS_FLAGS)
 	$(BUSYBOX_SET_INDIVIDUAL_BINARIES)
+	$(PACKAGES_BUSYBOX_CONFIG_FIXUPS)
 endef
 
 define BUSYBOX_BUILD_CMDS
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 577a148c1..d08c0eb32 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -1221,6 +1221,9 @@ endif
 ifneq ($$($(2)_USERS),)
 PACKAGES_USERS += $$($(2)_USERS)$$(sep)
 endif
+ifneq ($$($(2)_BUSYBOX_CONFIG_FIXUPS),)
+PACKAGES_BUSYBOX_CONFIG_FIXUPS += $$($(2)_BUSYBOX_CONFIG_FIXUPS)$$(sep)
+endif
 ifneq ($$($(2)_LINUX_CONFIG_FIXUPS),)
 PACKAGES_LINUX_CONFIG_FIXUPS += $$($(2)_LINUX_CONFIG_FIXUPS)$$(sep)
 endif
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 03/31] package/dcron: disable busybox crond & crontab

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/dcron/dcron.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/dcron/dcron.mk b/package/dcron/dcron.mk
index f0c3efbf8..d4dd48e77 100644
--- a/package/dcron/dcron.mk
+++ b/package/dcron/dcron.mk
@@ -33,4 +33,9 @@ define DCRON_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/usr/lib/systemd/system/dcron.service
 endef
 
+define DCRON_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_CROND)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_CRONTAB)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 03/31] package/dcron: disable busybox crond & crontab

[Baruch Siach via buildroot]

Hi Francois,

On Wed, Mar 13 2024, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/dcron/dcron.mk | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/package/dcron/dcron.mk b/package/dcron/dcron.mk
> index f0c3efbf8..d4dd48e77 100644
> --- a/package/dcron/dcron.mk
> +++ b/package/dcron/dcron.mk
> @@ -33,4 +33,9 @@ define DCRON_INSTALL_INIT_SYSTEMD
>  		$(TARGET_DIR)/usr/lib/systemd/system/dcron.service
>  endef
>  
> +define DCRON_BUSYBOX_CONFIG_FIXUPS
> +	$(call KCONFIG_DISABLE_OPT,CONFIG_CROND)
> +	$(call KCONFIG_DISABLE_OPT,CONFIG_CRONTAB)
> +endef

Do we still need dcron in BUSYBOX_DEPENDENCIES then?

Same question for other patches in this series.

baruch

> +
>  $(eval $(generic-package))


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 03/31] package/dcron: disable busybox crond & crontab

[François Perrad]

[-- Attachment #1.1: Type: text/plain, Size: 1595 bytes --]

Le mer. 13 mars 2024 à 10:48, Baruch Siach via buildroot <
buildroot@buildroot.org> a écrit :

> Hi Francois,
>
> On Wed, Mar 13 2024, Francois Perrad wrote:
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >  package/dcron/dcron.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/package/dcron/dcron.mk b/package/dcron/dcron.mk
> > index f0c3efbf8..d4dd48e77 100644
> > --- a/package/dcron/dcron.mk
> > +++ b/package/dcron/dcron.mk
> > @@ -33,4 +33,9 @@ define DCRON_INSTALL_INIT_SYSTEMD
> >               $(TARGET_DIR)/usr/lib/systemd/system/dcron.service
> >  endef
> >
> > +define DCRON_BUSYBOX_CONFIG_FIXUPS
> > +     $(call KCONFIG_DISABLE_OPT,CONFIG_CROND)
> > +     $(call KCONFIG_DISABLE_OPT,CONFIG_CRONTAB)
> > +endef
>
> Do we still need dcron in BUSYBOX_DEPENDENCIES then?
>
> Same question for other patches in this series.
>
> baruch
>
>
Hi Baruch,

you are right, these kind of dependencies in busybox.mk become useless (the
conflict between the Busybox applet and the full application is gone).

So, I'll remove them in v2.

François



> > +
> >  $(eval $(generic-package))
>
>
> --
>                                                      ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>

[-- Attachment #1.2: Type: text/html, Size: 3045 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 04/31] package/diffutils: disable busybox diff

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/diffutils/diffutils.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk
index 111926686..fe20a0e67 100644
--- a/package/diffutils/diffutils.mk
+++ b/package/diffutils/diffutils.mk
@@ -18,4 +18,8 @@ ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
 DIFFUTILS_CONF_ENV += gl_cv_func_getopt_gnu=yes
 endif
 
+define DIFFUTILS_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_DIFF)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 04/31] package/diffutils: disable busybox diff

[Arnout Vandecappelle via buildroot]

  Hi Francois,

On 13/03/2024 10:13, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>   package/diffutils/diffutils.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk
> index 111926686..fe20a0e67 100644
> --- a/package/diffutils/diffutils.mk
> +++ b/package/diffutils/diffutils.mk
> @@ -18,4 +18,8 @@ ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
>   DIFFUTILS_CONF_ENV += gl_cv_func_getopt_gnu=yes
>   endif
>   
> +define DIFFUTILS_BUSYBOX_CONFIG_FIXUPS
> +	$(call KCONFIG_DISABLE_OPT,CONFIG_DIFF)

  I don't understand the point of this series. In general, there is no reason to 
disable applets from busybox just because there's a "full" alternative installed 
on the system. Usually the busybox size difference is completely negligible 
compared to the the "full" installation size. And the busybox one can still be 
useful in some cases (when called as 'busybox diff' instead of 'diff').

  If you really care about removing the redundant busybox options, you can 
easily supply a custom busybox config.

  Is there a really good reason for all this?

  Regards,
  Arnout

> +endef
> +
>   $(eval $(autotools-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 04/31] package/diffutils: disable busybox diff

[François Perrad]

[-- Attachment #1.1: Type: text/plain, Size: 2210 bytes --]

Le ven. 15 mars 2024 à 20:57, Arnout Vandecappelle via buildroot <
buildroot@buildroot.org> a écrit :

>   Hi Francois,
>
> On 13/03/2024 10:13, Francois Perrad wrote:
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >   package/diffutils/diffutils.mk | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/package/diffutils/diffutils.mk b/package/diffutils/
> diffutils.mk
> > index 111926686..fe20a0e67 100644
> > --- a/package/diffutils/diffutils.mk
> > +++ b/package/diffutils/diffutils.mk
> > @@ -18,4 +18,8 @@ ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> >   DIFFUTILS_CONF_ENV += gl_cv_func_getopt_gnu=yes
> >   endif
> >
> > +define DIFFUTILS_BUSYBOX_CONFIG_FIXUPS
> > +     $(call KCONFIG_DISABLE_OPT,CONFIG_DIFF)
>
>   I don't understand the point of this series. In general, there is no
> reason to
> disable applets from busybox just because there's a "full" alternative
> installed
> on the system. Usually the busybox size difference is completely
> negligible
> compared to the the "full" installation size. And the busybox one can
> still be
> useful in some cases (when called as 'busybox diff' instead of 'diff').
>
>   If you really care about removing the redundant busybox options, you can
> easily supply a custom busybox config.
>
>   Is there a really good reason for all this?
>
>
In fact, in this serie, the only important patches are the 2 first.

I wrote the nexts, like this one, in order to show an use case of the 2nd
patch "package/busybox: handle LIBFOO_BUSYBOX_CONFIG_FIXUPS".
But it was a bad idea.

Note that my goal is not to reducing the image size, but to reducing the
attack surface (from a cyber security point of view).

Busybox uses the Kconfig infrastructure.
Currently, it could be configured via a full custom defconfig or via
fragments.
But, I think that altering the configuration by fixups could be also useful.

Francois


>   Regards,
>   Arnout
>
> > +endef
> > +
> >   $(eval $(autotools-package))
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>

[-- Attachment #1.2: Type: text/html, Size: 3495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 04/31] package/diffutils: disable busybox diff

[Yann E. MORIN]

François, All,

On 2024-03-16 11:59 +0100, François Perrad spake thusly:
> Le ven. 15 mars 2024 à 20:57, Arnout Vandecappelle via buildroot <[1]
> buildroot@buildroot.org> a écrit :
>     On 13/03/2024 10:13, Francois Perrad wrote:
>     > Signed-off-by: Francois Perrad <[2]francois.perrad@gadz.org>
>     > ---
>     >   package/diffutils/[3]diffutils.mk | 4 ++++
>     >   1 file changed, 4 insertions(+)
>     >
>     > diff --git a/package/diffutils/[4]diffutils.mk b/package/diffutils/[5]
>     diffutils.mk
>     > index 111926686..fe20a0e67 100644
>     > --- a/package/diffutils/[6]diffutils.mk
>     > +++ b/package/diffutils/[7]diffutils.mk
>     > @@ -18,4 +18,8 @@ ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
>     >   DIFFUTILS_CONF_ENV += gl_cv_func_getopt_gnu=yes
>     >   endif
>     >   
>     > +define DIFFUTILS_BUSYBOX_CONFIG_FIXUPS
>     > +     $(call KCONFIG_DISABLE_OPT,CONFIG_DIFF)
> 
>       I don't understand the point of this series. In general, there is no
>     reason to
>     disable applets from busybox just because there's a "full" alternative
>     installed
>     on the system. Usually the busybox size difference is completely negligible
>     compared to the the "full" installation size. And the busybox one can still
>     be
>     useful in some cases (when called as 'busybox diff' instead of 'diff').
> 
>       If you really care about removing the redundant busybox options, you can
>     easily supply a custom busybox config.
> 
>       Is there a really good reason for all this?
> 
> In fact, in this serie, the only important patches are the 2 first.

I didn't understand what was so important in the first patch, so you'd
have to extend the commit log with a bit more explanations, should you
respin it later. Also, it seems totally unrelated to the rest of the
series, so it should probably be sent separately.

> I wrote the nexts, like this one, in order to show an use case of the 2nd patch
> "package/busybox: handle LIBFOO_BUSYBOX_CONFIG_FIXUPS".

As for patch 2, I see that it is modelled after the similar feature we
have for the linux kernel. It would seem reasonable to have in the first
place. However, I still fail to see what the point really is.

Indeed, for the kernel, the feature is there because packages need a
feature from the kerenl, so we want to allo them to enable it, very
seldom to disable them [0].

But for busybox, there is not need to explicitly disable options: the
install order guarantees that the full-blown variant win over the
busybox applets.

Also, as Arnout pointed out, it is still possible and interesting to
keep the applets in busybox even when the ful-blown variant is enabled.
Indeed, it is possible to build an initramfs that only contains busybox,
which applets are used until the final root is mounted and swithroot-ed
into.

So, we do not ned a feature to _disable_ options in Busybox.

Now, on the other side of the coin, do we need a feature that allows
packages to _enable_ options in Busybox? Unlike the kernel, it is
possible to have a generic Busybox configuration that works "almost
everywhere" (well, two: one for MMU, one for noMMU). So that's the path
we have chosen in Buildroot: we cary those two configs, and there is no
reason to automatically tweak those; a concerned user will have to
provide their own, tailored to their particular use-case.

> Note that my goal is not to reducing the image size, but to reducing the attack
> surface (from a cyber security point of view).

Although I do laud the effort, this goes against the points mentioned
above. A user who wants to address security will have to review their
Busybox config and decide whether to drop or keep options, based on
their use-case (esp. the initramfs case).

> Busybox uses the Kconfig infrastructure.
> Currently, it could be configured via a full custom defconfig or via fragments.
> But, I think that altering the configuration by fixups could be also useful.

The fact that it uses the Kconfig infra is no reason in itself to make
it behave like the kernel (otherwise we'd have to do the same for all
the other kconfig-based packages) [1]

So, given all the above, I would say that we do not need this feature at
all for busybox.

[0] we have only three packages that disable kernel options:
  - systemd disables legacy sysfs (which were entirely dropped in v6.4)
  - kernel-module-imx-gpu-viv (a driver) disables an incompatible driver
    specific to the IMX kernel fork
  - zfs which needs stuff unavailable when those options are set (like
    unused ksyms)
  Those are really special cases; usually packages need to enable
  options.

[1] and if we went that route, then there would be no reason why we
would not have to have a mechanism for packages to be able to force
--{enable,disable,with,without}-option of other, autoconf-based packages,
or -D{ENABLE,DISABLE}_OPTION for other, cmake-based packages, and
similarly for all infras. Nope; no, no, no...

Regards,
Yann E. MORIN.

> 
> Francois
>  
> 
>       Regards,
>       Arnout
> 
>     > +endef
>     > +
>     >   $(eval $(autotools-package))
>     _______________________________________________
>     buildroot mailing list
>     [8]buildroot@buildroot.org
>     [9]https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> 
> References:
> 
> [1] mailto:buildroot@buildroot.org
> [2] mailto:francois.perrad@gadz.org
> [3] http://diffutils.mk/
> [4] http://diffutils.mk/
> [5] http://diffutils.mk/
> [6] http://diffutils.mk/
> [7] http://diffutils.mk/
> [8] mailto:buildroot@buildroot.org
> [9] https://lists.buildroot.org/mailman/listinfo/buildroot

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 05/31] package/dos2unix: disable busybox dos2unix & unix2dos

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/dos2unix/dos2unix.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/dos2unix/dos2unix.mk b/package/dos2unix/dos2unix.mk
index e30fc999d..6ed9c58b2 100644
--- a/package/dos2unix/dos2unix.mk
+++ b/package/dos2unix/dos2unix.mk
@@ -35,6 +35,11 @@ define DOS2UNIX_INSTALL_TARGET_CMDS
 		$(DOS2UNIX_MAKE_OPTS) install
 endef
 
+define DOS2UNIX_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_DOS2UNIX)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_UNIX2DOS)
+endef
+
 define HOST_DOS2UNIX_BUILD_CMDS
 	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) ENABLE_NLS=
 endef
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 06/31] package/fbset: disable busybox fbset

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/fbset/fbset.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/fbset/fbset.mk b/package/fbset/fbset.mk
index 8d2a477f8..5a5cf3a0e 100644
--- a/package/fbset/fbset.mk
+++ b/package/fbset/fbset.mk
@@ -18,4 +18,8 @@ define FBSET_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 755 $(@D)/fbset $(TARGET_DIR)/usr/sbin/fbset
 endef
 
+define FBSET_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_FBSET)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 07/31] package/findutils: disable busybox find & xargs

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/findutils/findutils.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/findutils/findutils.mk b/package/findutils/findutils.mk
index 9731a3504..89ff17a42 100644
--- a/package/findutils/findutils.mk
+++ b/package/findutils/findutils.mk
@@ -22,4 +22,9 @@ else
 FINDUTILS_CONF_OPTS += --without-selinux
 endif
 
+define FINDUTILS_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_FIND)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_XARGS)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 08/31] package/gawk: disable busybox awk

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/gawk/gawk.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
index ff1b9920a..b4261d767 100644
--- a/package/gawk/gawk.mk
+++ b/package/gawk/gawk.mk
@@ -31,6 +31,10 @@ else
 GAWK_CONF_OPTS += --without-readline
 endif
 
+define GAWK_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_AWK)
+endef
+
 HOST_GAWK_CONF_OPTS = --without-readline --without-mpfr
 
 define GAWK_CREATE_SYMLINK
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 09/31] package/grep: disable busybox grep, egrep & fgrep

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/grep/grep.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/grep/grep.mk b/package/grep/grep.mk
index 61900bb95..b0602e9e7 100644
--- a/package/grep/grep.mk
+++ b/package/grep/grep.mk
@@ -45,4 +45,10 @@ else
 GREP_CONF_OPTS += --disable-perl-regexp
 endif
 
+define GREP_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_GREP)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_EGREP)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_FGREP)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 10/31] package/gzip: disable busybox gunzip & gzip

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/gzip/gzip.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/gzip/gzip.mk b/package/gzip/gzip.mk
index 330321352..3d16235b0 100644
--- a/package/gzip/gzip.mk
+++ b/package/gzip/gzip.mk
@@ -22,5 +22,10 @@ HOST_GZIP_CONF_ENV += gl_cv_func_fflush_stdin=yes
 #  "using /bin/sh, even though it may have file descriptor bugs"
 GZIP_CONF_ENV += ac_cv_path_shell=/bin/sh
 
+define GZIP_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_GUNZIP)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_GZIP)
+endef
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 11/31] package/hdparm: disable busybox hdparm

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/hdparm/hdparm.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/hdparm/hdparm.mk b/package/hdparm/hdparm.mk
index 3c8b77e5e..78132b47e 100644
--- a/package/hdparm/hdparm.mk
+++ b/package/hdparm/hdparm.mk
@@ -20,4 +20,8 @@ define HDPARM_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 0755 $(@D)/hdparm $(TARGET_DIR)/sbin/hdparm
 endef
 
+define HDPARM_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_HDPARM)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 12/31] package/i2c-tools: disable busybox ic2get, i2cset, i2cdump, i2cdetect & i2ctransfer

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/i2c-tools/i2c-tools.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index 99388d953..e0030ea74 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -65,4 +65,12 @@ define I2C_TOOLS_INSTALL_STAGING_CMDS
 		DESTDIR="$(STAGING_DIR)" PREFIX=/usr -C $(@D) install
 endef
 
+define I2C_TOOLS_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_I2CGET)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_I2CSET)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_I2CDUMP)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_I2CDETECT)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_I2CTRANSFER)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 13/31] package/ifenslave: disable busybox ifenslave

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/ifenslave/ifenslave.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/ifenslave/ifenslave.mk b/package/ifenslave/ifenslave.mk
index b51aa7205..f3cca2b52 100644
--- a/package/ifenslave/ifenslave.mk
+++ b/package/ifenslave/ifenslave.mk
@@ -16,4 +16,8 @@ define IFENSLAVE_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 0755 $(@D)/ifenslave $(TARGET_DIR)/sbin/ifenslave
 endef
 
+define IFENSLAVE_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_IFENSLAVE)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 14/31] package/ifplugd: disable busybox ifplugd

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/ifplugd/ifplugd.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/ifplugd/ifplugd.mk b/package/ifplugd/ifplugd.mk
index 6de7f1764..f841f59b3 100644
--- a/package/ifplugd/ifplugd.mk
+++ b/package/ifplugd/ifplugd.mk
@@ -32,4 +32,8 @@ define IFPLUGD_INSTALL_INIT_SYSV
 	$(SED) 's^/bin/bash^/bin/sh^g' $(TARGET_DIR)/etc/init.d/S45ifplugd
 endef
 
+define IFPLUGD_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_IFPLUGD)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 15/31] package/ifupdown: disable busybox ifup & ifdown

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/ifupdown/ifupdown.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/ifupdown/ifupdown.mk b/package/ifupdown/ifupdown.mk
index 14c36db0d..c79ba81a1 100644
--- a/package/ifupdown/ifupdown.mk
+++ b/package/ifupdown/ifupdown.mk
@@ -33,4 +33,9 @@ define IFUPDOWN_MAKE_IP_IN_SBIN
 endef
 IFUPDOWN_POST_PATCH_HOOKS += IFUPDOWN_MAKE_IP_IN_SBIN
 
+define IFUPDOWN_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_IFUP)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_IFDOWN)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 16/31] package/ipcalc: disable busybox ipcalc

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/ipcalc/ipcalc.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/ipcalc/ipcalc.mk b/package/ipcalc/ipcalc.mk
index c1eba5d59..17c819cd0 100644
--- a/package/ipcalc/ipcalc.mk
+++ b/package/ipcalc/ipcalc.mk
@@ -30,4 +30,8 @@ else
 IPCALC_CONF_OPTS += -Duse_maxminddb=disabled
 endif
 
+define IPCALC_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_IPCALC)
+endef
+
 $(eval $(meson-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 17/31] package/kmod: disable busybox depmod, insmod, lsmod, modinfo, modprobe & rmmod

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/kmod/kmod.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
index d83fb85a3..1f3bc0424 100644
--- a/package/kmod/kmod.mk
+++ b/package/kmod/kmod.mk
@@ -86,6 +86,15 @@ else
 KMOD_CONF_OPTS += --disable-tools
 endif
 
+define KMOD_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_DEPMOD)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_INSMOD)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_LSMOD)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_MODINFO)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_MODPROBE)
+	$(call KCONFIG_DISABLE_OPT,CONFIG_RMMOD)
+endef
+
 ifeq ($(BR2_PACKAGE_HOST_KMOD_GZ),y)
 HOST_KMOD_DEPENDENCIES += host-zlib
 HOST_KMOD_CONF_OPTS += --with-zlib
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 18/31] package/less: disable busybox less

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/less/less.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/less/less.mk b/package/less/less.mk
index 7431d80cc..aebd757ca 100644
--- a/package/less/less.mk
+++ b/package/less/less.mk
@@ -11,4 +11,8 @@ LESS_LICENSE_FILES = COPYING
 LESS_CPE_ID_VENDOR = gnu
 LESS_DEPENDENCIES = ncurses
 
+define LESS_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_LESS)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 19/31] package/lsof: disable busybox lsof

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/lsof/lsof.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/lsof/lsof.mk b/package/lsof/lsof.mk
index cb4e987bd..3066c142e 100644
--- a/package/lsof/lsof.mk
+++ b/package/lsof/lsof.mk
@@ -47,4 +47,8 @@ define LSOF_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 755 $(@D)/lsof $(TARGET_DIR)/usr/bin/lsof
 endef
 
+define LSOF_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_LSOF)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 20/31] package/netcat: disable busybox netcat

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/netcat/netcat.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/netcat/netcat.mk b/package/netcat/netcat.mk
index c9d7952e5..3a80a1417 100644
--- a/package/netcat/netcat.mk
+++ b/package/netcat/netcat.mk
@@ -10,4 +10,8 @@ NETCAT_LICENSE = GPL-2.0+
 NETCAT_LICENSE_FILES = COPYING
 NETCAT_CPE_ID_VALID = YES
 
+define NETCAT_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_NETCAT)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 21/31] package/netcat-openbsd: disable busybox netcat

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/netcat-openbsd/netcat-openbsd.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/netcat-openbsd/netcat-openbsd.mk b/package/netcat-openbsd/netcat-openbsd.mk
index 311f8aa81..cd1adff1f 100644
--- a/package/netcat-openbsd/netcat-openbsd.mk
+++ b/package/netcat-openbsd/netcat-openbsd.mk
@@ -28,4 +28,8 @@ define NETCAT_OPENBSD_INSTALL_TARGET_CMDS
 	$(INSTALL) -m 755 -D $(@D)/nc $(TARGET_DIR)/usr/bin/nc
 endef
 
+define NETCAT_OPENBSD_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_NETCAT)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 22/31] package/patch: disable busybox patch

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/patch/patch.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/patch/patch.mk b/package/patch/patch.mk
index 6f83d2418..8765b3b31 100644
--- a/package/patch/patch.mk
+++ b/package/patch/patch.mk
@@ -30,4 +30,8 @@ else
 PATCH_CONF_OPTS += --disable-xattr
 endif
 
+define PATCH_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_PATCH)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 23/31] package/rsyslog: disable busybox syslogd

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/rsyslog/rsyslog.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
index dc30a2edc..807caf5ce 100644
--- a/package/rsyslog/rsyslog.mk
+++ b/package/rsyslog/rsyslog.mk
@@ -176,4 +176,8 @@ endef
 
 RSYSLOG_POST_INSTALL_TARGET_HOOKS += RSYSLOG_INSTALL_CONF
 
+define RSYSLOG_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_SYSLOGD)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 24/31] package/sed: disable busybox sed

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/sed/sed.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/sed/sed.mk b/package/sed/sed.mk
index 816508365..e5a2206f8 100644
--- a/package/sed/sed.mk
+++ b/package/sed/sed.mk
@@ -21,4 +21,8 @@ SED_CONF_OPTS = \
 	--infodir=/usr/share/info \
 	--include=$(STAGING_DIR)/usr/include
 
+define SED_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_SED)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 25/31] package/start-stop-daemon: disable busybox start-stop-daemon

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/start-stop-daemon/start-stop-daemon.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/start-stop-daemon/start-stop-daemon.mk b/package/start-stop-daemon/start-stop-daemon.mk
index 9db767dd1..fb5e84c90 100644
--- a/package/start-stop-daemon/start-stop-daemon.mk
+++ b/package/start-stop-daemon/start-stop-daemon.mk
@@ -35,4 +35,8 @@ define START_STOP_DAEMON_INSTALL_TARGET_CMDS
 		$(TARGET_DIR)/sbin/start-stop-daemon
 endef
 
+define START_STOP_DAEMON_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_START_STOP_DAEMON)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 26/31] package/tar: disable busybox tar

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/tar/tar.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/tar/tar.mk b/package/tar/tar.mk
index d57d63970..ec4b7f7ad 100644
--- a/package/tar/tar.mk
+++ b/package/tar/tar.mk
@@ -33,6 +33,10 @@ else
 TAR_CONF_OPTS += --without-xattrs
 endif
 
+define TAR_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_TAR)
+endef
+
 $(eval $(autotools-package))
 
 # host-tar: use cpio.gz instead of tar.gz to prevent chicken-egg problem
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 27/31] package/tftpd: disable busybox tftpd

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/tftpd/tftpd.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/tftpd/tftpd.mk b/package/tftpd/tftpd.mk
index ceac24119..4fb77189d 100644
--- a/package/tftpd/tftpd.mk
+++ b/package/tftpd/tftpd.mk
@@ -25,4 +25,8 @@ define TFTPD_INSTALL_INIT_SYSV
 	$(INSTALL) -D -m 0755 package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d/S80tftpd-hpa
 endef
 
+define TFTPD_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_TFTPD)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 28/31] package/unzip: disable busybox unzip

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/unzip/unzip.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/unzip/unzip.mk b/package/unzip/unzip.mk
index 5effebee4..f0eee19fa 100644
--- a/package/unzip/unzip.mk
+++ b/package/unzip/unzip.mk
@@ -42,4 +42,8 @@ UNZIP_CONF_OPTS += \
 	-DCMAKE_C_FLAGS="$(UNZIP_TARGET_CFLAGS) -DLARGE_FILE_SUPPORT" \
 	-DCMAKE_CXX_FLAGS="$(UNZIP_TARGET_CXXFLAGS) -DLARGE_FILE_SUPPORT"
 
+define UNZIP_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_UNZIP)
+endef
+
 $(eval $(cmake-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 29/31] package/wget: disable busybox wget

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/wget/wget.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/wget/wget.mk b/package/wget/wget.mk
index d2d308796..24cda15fe 100644
--- a/package/wget/wget.mk
+++ b/package/wget/wget.mk
@@ -72,4 +72,8 @@ else
 WGET_CONF_OPTS += --disable-pcre --disable-pcre2
 endif
 
+define WGET_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_WGET)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 30/31] package/which: disable busybox which

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/which/which.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/which/which.mk b/package/which/which.mk
index c96e89375..fee32e5c6 100644
--- a/package/which/which.mk
+++ b/package/which/which.mk
@@ -9,4 +9,8 @@ WHICH_SITE = $(BR2_GNU_MIRROR)/which
 WHICH_LICENSE = GPL-3.0+
 WHICH_LICENSE_FILES = COPYING
 
+define WHICH_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_WHICH)
+endef
+
 $(eval $(autotools-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 31/31] package/whois: disable busybox whois

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/whois/whois.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/whois/whois.mk b/package/whois/whois.mk
index 5a85bea35..c338e080c 100644
--- a/package/whois/whois.mk
+++ b/package/whois/whois.mk
@@ -42,4 +42,8 @@ define WHOIS_INSTALL_TARGET_CMDS
 		BASEDIR="$(TARGET_DIR)" $(WHOIS_INSTALL_TARGETS) -C $(@D)
 endef
 
+define WHOIS_BUSYBOX_CONFIG_FIXUPS
+	$(call KCONFIG_DISABLE_OPT,CONFIG_WHOIS)
+endef
+
 $(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/31] package/busybox: move the hush config in a fragment

[Yann E. MORIN]

François, All,

On 2024-03-13 10:13 +0100, Francois Perrad spake thusly:
> by this way, the busybox-minimal.config becomes more widely usable
> 
> at this time, busybox-minimal.config is the default for no-mmu
> so, busybox-hush.fragment must be also a default for no-mmu

Sorry, I am not sure I see the point. Can you elaborate, and respin with
an extended commit log, please?

Regards,
Yann E. MORIN.

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/busybox/Config.in              |   1 +
>  package/busybox/busybox-hush.fragment  |  51 ++++++++++++
>  package/busybox/busybox-minimal.config | 109 +++++++++++++------------
>  3 files changed, 107 insertions(+), 54 deletions(-)
>  create mode 100644 package/busybox/busybox-hush.fragment
> 
> diff --git a/package/busybox/Config.in b/package/busybox/Config.in
> index 3c2aa515f..819cc2c4c 100644
> --- a/package/busybox/Config.in
> +++ b/package/busybox/Config.in
> @@ -25,6 +25,7 @@ config BR2_PACKAGE_BUSYBOX_CONFIG
>  
>  config BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES
>  	string "Additional BusyBox configuration fragment files"
> +	default "package/busybox/busybox-hush.fragment" if !BR2_USE_MMU
>  	help
>  	  A space-separated list of configuration fragment files,
>  	  that will be merged to the main BusyBox configuration file.
> diff --git a/package/busybox/busybox-hush.fragment b/package/busybox/busybox-hush.fragment
> new file mode 100644
> index 000000000..e1ac47cce
> --- /dev/null
> +++ b/package/busybox/busybox-hush.fragment
> @@ -0,0 +1,51 @@
> +# this fragment allows to switch from `ash` to `hush`
> +#   - `ash` is the most complete, it's a derivative of the Debian `dash`
> +#   - `hush` works on no-mmu systems, but its syntax is not "standard"
> +
> +# CONFIG_SH_IS_ASH is not set
> +CONFIG_SH_IS_HUSH=y
> +# CONFIG_SH_IS_NONE is not set
> +
> +# CONFIG_BASH_IS_ASH is not set
> +# CONFIG_BASH_IS_HUSH is not set
> +CONFIG_BASH_IS_NONE=y
> +
> +# CONFIG_SHELL_ASH is not set
> +
> +CONFIG_HUSH=y
> +CONFIG_SHELL_HUSH=y
> +CONFIG_HUSH_BASH_COMPAT=y
> +CONFIG_HUSH_BRACE_EXPANSION=y
> +# CONFIG_HUSH_BASH_SOURCE_CURDIR is not set
> +CONFIG_HUSH_LINENO_VAR=y
> +CONFIG_HUSH_INTERACTIVE=y
> +CONFIG_HUSH_SAVEHISTORY=y
> +CONFIG_HUSH_JOB=y
> +CONFIG_HUSH_TICK=y
> +CONFIG_HUSH_IF=y
> +CONFIG_HUSH_LOOPS=y
> +CONFIG_HUSH_CASE=y
> +CONFIG_HUSH_FUNCTIONS=y
> +CONFIG_HUSH_LOCAL=y
> +CONFIG_HUSH_RANDOM_SUPPORT=y
> +CONFIG_HUSH_MODE_X=y
> +CONFIG_HUSH_ECHO=y
> +CONFIG_HUSH_PRINTF=y
> +CONFIG_HUSH_TEST=y
> +CONFIG_HUSH_HELP=y
> +CONFIG_HUSH_EXPORT=y
> +CONFIG_HUSH_EXPORT_N=y
> +CONFIG_HUSH_READONLY=y
> +CONFIG_HUSH_KILL=y
> +CONFIG_HUSH_WAIT=y
> +CONFIG_HUSH_COMMAND=y
> +CONFIG_HUSH_TRAP=y
> +CONFIG_HUSH_TYPE=y
> +CONFIG_HUSH_TIMES=y
> +CONFIG_HUSH_READ=y
> +CONFIG_HUSH_SET=y
> +CONFIG_HUSH_UNSET=y
> +CONFIG_HUSH_ULIMIT=y
> +CONFIG_HUSH_UMASK=y
> +CONFIG_HUSH_GETOPTS=y
> +# CONFIG_HUSH_MEMLEAK is not set
> diff --git a/package/busybox/busybox-minimal.config b/package/busybox/busybox-minimal.config
> index 1e7ad1d35..cf53c1598 100644
> --- a/package/busybox/busybox-minimal.config
> +++ b/package/busybox/busybox-minimal.config
> @@ -1115,68 +1115,69 @@ CONFIG_SVOK=y
>  #
>  # Shells
>  #
> -# CONFIG_SH_IS_ASH is not set
> -CONFIG_SH_IS_HUSH=y
> +CONFIG_SH_IS_ASH=y
> +# CONFIG_SH_IS_HUSH is not set
>  # CONFIG_SH_IS_NONE is not set
>  # CONFIG_BASH_IS_ASH is not set
>  # CONFIG_BASH_IS_HUSH is not set
>  CONFIG_BASH_IS_NONE=y
> -# CONFIG_SHELL_ASH is not set
> -# CONFIG_ASH is not set
> -# CONFIG_ASH_OPTIMIZE_FOR_SIZE is not set
> -# CONFIG_ASH_INTERNAL_GLOB is not set
> -# CONFIG_ASH_BASH_COMPAT is not set
> +CONFIG_SHELL_ASH=y
> +CONFIG_ASH=y
> +CONFIG_ASH_OPTIMIZE_FOR_SIZE=y
> +CONFIG_ASH_INTERNAL_GLOB=y
> +CONFIG_ASH_BASH_COMPAT=y
>  # CONFIG_ASH_BASH_SOURCE_CURDIR is not set
> -# CONFIG_ASH_BASH_NOT_FOUND_HOOK is not set
> -# CONFIG_ASH_JOB_CONTROL is not set
> -# CONFIG_ASH_ALIAS is not set
> -# CONFIG_ASH_RANDOM_SUPPORT is not set
> -# CONFIG_ASH_EXPAND_PRMT is not set
> -# CONFIG_ASH_IDLE_TIMEOUT is not set
> +CONFIG_ASH_BASH_NOT_FOUND_HOOK=y
> +CONFIG_ASH_JOB_CONTROL=y
> +CONFIG_ASH_ALIAS=y
> +CONFIG_ASH_RANDOM_SUPPORT=y
> +CONFIG_ASH_EXPAND_PRMT=y
> +CONFIG_ASH_IDLE_TIMEOUT=y
>  # CONFIG_ASH_MAIL is not set
> -# CONFIG_ASH_ECHO is not set
> -# CONFIG_ASH_PRINTF is not set
> -# CONFIG_ASH_TEST is not set
> -# CONFIG_ASH_HELP is not set
> -# CONFIG_ASH_GETOPTS is not set
> -# CONFIG_ASH_CMDCMD is not set
> +CONFIG_ASH_ECHO=y
> +CONFIG_ASH_PRINTF=y
> +CONFIG_ASH_TEST=y
> +CONFIG_ASH_SLEEP=y
> +CONFIG_ASH_HELP=y
> +CONFIG_ASH_GETOPTS=y
> +CONFIG_ASH_CMDCMD=y
>  # CONFIG_CTTYHACK is not set
> -CONFIG_HUSH=y
> -CONFIG_SHELL_HUSH=y
> -CONFIG_HUSH_BASH_COMPAT=y
> -CONFIG_HUSH_BRACE_EXPANSION=y
> +# CONFIG_HUSH is not set
> +# CONFIG_SHELL_HUSH is not set
> +# CONFIG_HUSH_BASH_COMPAT is not set
> +# CONFIG_HUSH_BRACE_EXPANSION is not set
>  # CONFIG_HUSH_BASH_SOURCE_CURDIR is not set
> -CONFIG_HUSH_LINENO_VAR=y
> -CONFIG_HUSH_INTERACTIVE=y
> -CONFIG_HUSH_SAVEHISTORY=y
> -CONFIG_HUSH_JOB=y
> -CONFIG_HUSH_TICK=y
> -CONFIG_HUSH_IF=y
> -CONFIG_HUSH_LOOPS=y
> -CONFIG_HUSH_CASE=y
> -CONFIG_HUSH_FUNCTIONS=y
> -CONFIG_HUSH_LOCAL=y
> -CONFIG_HUSH_RANDOM_SUPPORT=y
> -CONFIG_HUSH_MODE_X=y
> -CONFIG_HUSH_ECHO=y
> -CONFIG_HUSH_PRINTF=y
> -CONFIG_HUSH_TEST=y
> -CONFIG_HUSH_HELP=y
> -CONFIG_HUSH_EXPORT=y
> -CONFIG_HUSH_EXPORT_N=y
> -CONFIG_HUSH_READONLY=y
> -CONFIG_HUSH_KILL=y
> -CONFIG_HUSH_WAIT=y
> -CONFIG_HUSH_COMMAND=y
> -CONFIG_HUSH_TRAP=y
> -CONFIG_HUSH_TYPE=y
> -CONFIG_HUSH_TIMES=y
> -CONFIG_HUSH_READ=y
> -CONFIG_HUSH_SET=y
> -CONFIG_HUSH_UNSET=y
> -CONFIG_HUSH_ULIMIT=y
> -CONFIG_HUSH_UMASK=y
> -CONFIG_HUSH_GETOPTS=y
> +# CONFIG_HUSH_LINENO_VAR is not set
> +# CONFIG_HUSH_INTERACTIVE is not set
> +# CONFIG_HUSH_SAVEHISTORY is not set
> +# CONFIG_HUSH_JOB is not set
> +# CONFIG_HUSH_TICK is not set
> +# CONFIG_HUSH_IF is not set
> +# CONFIG_HUSH_LOOPS is not set
> +# CONFIG_HUSH_CASE is not set
> +# CONFIG_HUSH_FUNCTIONS is not set
> +# CONFIG_HUSH_LOCAL is not set
> +# CONFIG_HUSH_RANDOM_SUPPORT is not set
> +# CONFIG_HUSH_MODE_X is not set
> +# CONFIG_HUSH_ECHO is not set
> +# CONFIG_HUSH_PRINTF is not set
> +# CONFIG_HUSH_TEST is not set
> +# CONFIG_HUSH_HELP is not set
> +# CONFIG_HUSH_EXPORT is not set
> +# CONFIG_HUSH_EXPORT_N is not set
> +# CONFIG_HUSH_READONLY is not set
> +# CONFIG_HUSH_KILL is not set
> +# CONFIG_HUSH_WAIT is not set
> +# CONFIG_HUSH_COMMAND is not set
> +# CONFIG_HUSH_TRAP is not set
> +# CONFIG_HUSH_TYPE is not set
> +# CONFIG_HUSH_TIMES is not set
> +# CONFIG_HUSH_READ is not set
> +# CONFIG_HUSH_SET is not set
> +# CONFIG_HUSH_UNSET is not set
> +# CONFIG_HUSH_ULIMIT is not set
> +# CONFIG_HUSH_UMASK is not set
> +# CONFIG_HUSH_GETOPTS is not set
>  # CONFIG_HUSH_MEMLEAK is not set
>  
>  #
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot