* [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV
@ 2024-02-11 16:12 Fabrice Fontaine
2024-02-11 17:05 ` Yann E. MORIN
2024-03-10 21:53 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-02-11 16:12 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as libdnet
uses setuptools instead of distutils since version 1.16.2 and
https://github.com/ofalk/libdnet/commit/4e4fc687953105b66bcc847a68869126ac3ec918
This will avoid the following build failure raised since commit
09de823cbc7bd50a40e25f4166b4e42be94b0c7b:
In file included from /home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/Python.h:38,
from ./dnet.c:40:
/home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
| ^~~~~
Fixes:
- No autobuilder failures (yet)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libdnet/libdnet.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libdnet/libdnet.mk b/package/libdnet/libdnet.mk
index fc2995979d..e678565bdf 100644
--- a/package/libdnet/libdnet.mk
+++ b/package/libdnet/libdnet.mk
@@ -19,7 +19,7 @@ LIBDNET_DEPENDENCIES = host-pkgconf
ifeq ($(BR2_PACKAGE_LIBDNET_PYTHON),y)
LIBDNET_DEPENDENCIES += libbsd host-python-cython python3
LIBDNET_CONF_OPTS += --with-python=$(HOST_DIR)/bin
-LIBDNET_MAKE_ENV += $(PKG_PYTHON_DISTUTILS_ENV)
+LIBDNET_MAKE_ENV += $(PKG_PYTHON_SETUPTOOLS_ENV)
LIBDNET_INSTALL_TARGET_OPTS = $(LIBDNET_MAKE_OPTS) DESTDIR=$(TARGET_DIR) INSTALL_STRIP_FLAG=-s install-exec
LIBDNET_INSTALL_STAGING_OPTS = $(LIBDNET_MAKE_OPTS) DESTDIR=$(STAGING_DIR) install
endif
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV
2024-02-11 16:12 [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
@ 2024-02-11 17:05 ` Yann E. MORIN
2024-03-10 21:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-02-11 17:05 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice, All,
On 2024-02-11 17:12 +0100, Fabrice Fontaine spake thusly:
> Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as libdnet
> uses setuptools instead of distutils since version 1.16.2 and
> https://github.com/ofalk/libdnet/commit/4e4fc687953105b66bcc847a68869126ac3ec918
>
> This will avoid the following build failure raised since commit
> 09de823cbc7bd50a40e25f4166b4e42be94b0c7b:
>
> In file included from /home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/Python.h:38,
> from ./dnet.c:40:
> /home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
> 586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
> | ^~~~~
>
> Fixes:
> - No autobuilder failures (yet)
I've also added a reference to the commit that introduced the issue.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/libdnet/libdnet.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libdnet/libdnet.mk b/package/libdnet/libdnet.mk
> index fc2995979d..e678565bdf 100644
> --- a/package/libdnet/libdnet.mk
> +++ b/package/libdnet/libdnet.mk
> @@ -19,7 +19,7 @@ LIBDNET_DEPENDENCIES = host-pkgconf
> ifeq ($(BR2_PACKAGE_LIBDNET_PYTHON),y)
> LIBDNET_DEPENDENCIES += libbsd host-python-cython python3
> LIBDNET_CONF_OPTS += --with-python=$(HOST_DIR)/bin
> -LIBDNET_MAKE_ENV += $(PKG_PYTHON_DISTUTILS_ENV)
> +LIBDNET_MAKE_ENV += $(PKG_PYTHON_SETUPTOOLS_ENV)
> LIBDNET_INSTALL_TARGET_OPTS = $(LIBDNET_MAKE_OPTS) DESTDIR=$(TARGET_DIR) INSTALL_STRIP_FLAG=-s install-exec
> LIBDNET_INSTALL_STAGING_OPTS = $(LIBDNET_MAKE_OPTS) DESTDIR=$(STAGING_DIR) install
> endif
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV
2024-02-11 16:12 [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
2024-02-11 17:05 ` Yann E. MORIN
@ 2024-03-10 21:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-03-10 21:53 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as libdnet
> uses setuptools instead of distutils since version 1.16.2 and
> https://github.com/ofalk/libdnet/commit/4e4fc687953105b66bcc847a68869126ac3ec918
> This will avoid the following build failure raised since commit
> 09de823cbc7bd50a40e25f4166b4e42be94b0c7b:
> In file included from /home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/Python.h:38,
> from ./dnet.c:40:
> /home/fabrice/buildroot/output/per-package/libdnet/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
> 586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
> | ^~~~~
> Fixes:
> - No autobuilder failures (yet)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-10 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-11 16:12 [Buildroot] [PATCH 1/1] package/libdnet: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
2024-02-11 17:05 ` Yann E. MORIN
2024-03-10 21:53 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox