[Buildroot] [PATCHv2] package/go: fix installation

[Buildroot] [PATCHv2] package/go: fix installation

[yann.morin]

From: "Yann E. MORIN" <yann.morin@orange.com>

When building for a target architecture that go does not support, the
isntallation fails with:

    $ make host-go
    [...]
    ln -sf ../lib/go/bin/go /home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/
    ln: failed to create symbolic link '/home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/': No such file or directory

Indeed, the HOST_DIR/bin is not guaranteed to exist when we install a
host package, so it needs to be explicitly created before we can create
entries in there.

Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Cc: Christian Stewart <christian@aperture.us>
Cc: Anisse Astier <anisse@astier.eu>

---
Changes v1 -> v2:
  - drop surious hunk
---
 package/go/go.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/go/go.mk b/package/go/go.mk
index aa5d7f97b5..e5195089ac 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -146,6 +146,7 @@ define HOST_GO_INSTALL_CMDS
 	$(INSTALL) -D -m 0755 $(@D)/bin/go $(HOST_GO_ROOT)/bin/go
 	$(INSTALL) -D -m 0755 $(@D)/bin/gofmt $(HOST_GO_ROOT)/bin/gofmt
 
+	mkdir -p $(HOST_DIR)/bin
 	ln -sf ../lib/go/bin/go $(HOST_DIR)/bin/
 	ln -sf ../lib/go/bin/gofmt $(HOST_DIR)/bin/
 
-- 
2.34.1

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCHv2] package/go: fix installation

[Peter Korsgaard]

>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > When building for a target architecture that go does not support, the
 > isntallation fails with:

 >     $ make host-go
 >     [...]
 >     ln -sf ../lib/go/bin/go /home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/
 >     ln: failed to create symbolic link '/home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/': No such file or directory

 > Indeed, the HOST_DIR/bin is not guaranteed to exist when we install a
 > host package, so it needs to be explicitly created before we can create
 > entries in there.

 > Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
 > Cc: Christian Stewart <christian@aperture.us>
 > Cc: Anisse Astier <anisse@astier.eu>

 > ---
 > Changes v1 -> v2:
 >   - drop surious hunk

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCHv2] package/go: fix installation

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>>   <yann.morin@orange.com> writes:
 >> From: "Yann E. MORIN" <yann.morin@orange.com>
 >> When building for a target architecture that go does not support, the
 >> isntallation fails with:

 >> $ make host-go
 >> [...]
 >> ln -sf ../lib/go/bin/go /home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/
 >> ln: failed to create symbolic link '/home/nyma7486/dev/work/5GCroCo/O/pouet/per-package/host-go/host/bin/': No such file or directory

 >> Indeed, the HOST_DIR/bin is not guaranteed to exist when we install a
 >> host package, so it needs to be explicitly created before we can create
 >> entries in there.

 >> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
 >> Cc: Christian Stewart <christian@aperture.us>
 >> Cc: Anisse Astier <anisse@astier.eu>

 >> ---
 >> Changes v1 -> v2:
 >> - drop surious hunk

 > Committed, thanks.

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot