* [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9
@ 2023-09-17 19:48 Fabrice Fontaine
2023-09-21 19:43 ` Arnout Vandecappelle via buildroot
2023-09-26 5:49 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-09-17 19:48 UTC (permalink / raw)
To: buildroot
Cc: Bernd Kuhls, Bartosz Bilas, Asaf Kahlon, James Hilliard,
Marcin Niestroj, Thomas Petazzoni, Giulio Benetti,
Fabrice Fontaine
libuv unconditionally uses stdatomic since
https://github.com/libuv/libuv/commit/2f33980a9141bd49cb2c34361854355b23b1e6fc
resulting in the following build failure with gcc < 4.9 since bump to
version 1.45.0 in commit 21764235cb7f7fb767ea4b5d825e39c711aee235:
In file included from src/fs-poll.c:23:0:
src/uv-common.h:41:24: fatal error: stdatomic.h: No such file or directory
# include <stdatomic.h>
^
Fixes:
- http://autobuild.buildroot.org/results/6b9ce25ba7e5c5602313d533f460f8829f767f81
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/Config.in | 6 ++++--
package/cmake/Config.in | 6 +++---
package/libuv/Config.in | 6 ++++--
package/luv/Config.in | 6 ++++--
package/luvi/Config.in | 6 ++++--
package/moarvm/Config.in | 6 ++++--
package/netdata/Config.in | 6 ++++--
package/python-uvloop/Config.in | 6 ++++--
package/ttyd/Config.in | 6 ++++--
package/wampcc/Config.in | 6 ++++--
package/xmrig/Config.in | 6 ++++--
11 files changed, 43 insertions(+), 23 deletions(-)
diff --git a/package/bind/Config.in b/package/bind/Config.in
index 63ccd57db7..512e948ca2 100644
--- a/package/bind/Config.in
+++ b/package/bind/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_BIND
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
depends on !BR2_STATIC_LIBS # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_OPENSSL
help
@@ -43,7 +44,8 @@ config BR2_PACKAGE_BIND_TOOLS
endif
-comment "bind needs a toolchain w/ NPTL, dynamic library"
+comment "bind needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
diff --git a/package/cmake/Config.in b/package/cmake/Config.in
index 4ef5612b57..57b1ebf9fd 100644
--- a/package/cmake/Config.in
+++ b/package/cmake/Config.in
@@ -14,7 +14,7 @@ config BR2_PACKAGE_CMAKE
config BR2_PACKAGE_CMAKE_CTEST
bool "ctest"
depends on BR2_PACKAGE_CMAKE_ARCH_SUPPORTS
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # from jsoncpp
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
depends on BR2_USE_WCHAR # libarchive
depends on BR2_INSTALL_LIBSTDCPP
depends on !BR2_STATIC_LIBS
@@ -40,10 +40,10 @@ config BR2_PACKAGE_CMAKE_CTEST
http://www.cmake.org/
-comment "ctest needs a toolchain w/ C++, wchar, dynamic library, gcc >= 4.7, NPTL"
+comment "ctest needs a toolchain w/ C++, wchar, dynamic library, gcc >= 4.9, NPTL"
depends on BR2_PACKAGE_CMAKE_ARCH_SUPPORTS
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
- BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \
+ BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
!BR2_TOOLCHAIN_HAS_THREADS_NPTL
diff --git a/package/libuv/Config.in b/package/libuv/Config.in
index cdd73a672f..e23b2c5fe0 100644
--- a/package/libuv/Config.in
+++ b/package/libuv/Config.in
@@ -4,13 +4,15 @@ config BR2_PACKAGE_LIBUV
depends on BR2_USE_MMU # fork()
depends on !BR2_STATIC_LIBS
depends on BR2_TOOLCHAIN_HAS_SYNC_4
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
help
libuv is a multi-platform support library with a focus
on asynchronous I/O.
https://github.com/libuv/libuv
-comment "libuv needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "libuv needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/luv/Config.in b/package/luv/Config.in
index 434cb3b459..d6aff8b6f7 100644
--- a/package/luv/Config.in
+++ b/package/luv/Config.in
@@ -4,13 +4,15 @@ config BR2_PACKAGE_LUV
depends on BR2_USE_MMU # libuv
depends on !BR2_STATIC_LIBS # libuv
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
help
libuv bindings for LuaJIT and Lua.
https://github.com/luvit/luv
-comment "luv needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "luv needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/luvi/Config.in b/package/luvi/Config.in
index 6e96f85f32..3a724acebb 100644
--- a/package/luvi/Config.in
+++ b/package/luvi/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_LUVI
depends on !BR2_STATIC_LIBS # libuv
depends on BR2_PACKAGE_LUAJIT
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_LUV
select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
@@ -25,8 +26,9 @@ config BR2_PACKAGE_LUVI
https://github.com/luvit/luvi
-comment "luvi needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "luvi needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/moarvm/Config.in b/package/moarvm/Config.in
index 11d8ac7ebc..6972a5f8a6 100644
--- a/package/moarvm/Config.in
+++ b/package/moarvm/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_MOARVM
depends on BR2_USE_MMU # libuv
depends on BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS # libatomic_ops
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_LIBTOMMATH
select BR2_PACKAGE_LIBATOMIC_OPS
@@ -18,8 +19,9 @@ config BR2_PACKAGE_MOARVM
http://moarvm.com
-comment "moarvm needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "moarvm needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/netdata/Config.in b/package/netdata/Config.in
index 34d139125d..d17b5e89aa 100644
--- a/package/netdata/Config.in
+++ b/package/netdata/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_NETDATA
depends on BR2_USE_MMU # fork()
depends on !BR2_STATIC_LIBS # libuv
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_LIBUUID
@@ -35,7 +36,8 @@ comment "prometheus remote write backend needs a toolchain w/ C++, gcc >= 4.8"
endif
-comment "netdata needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "netdata needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/python-uvloop/Config.in b/package/python-uvloop/Config.in
index b3fb275091..c9a05111cb 100644
--- a/package/python-uvloop/Config.in
+++ b/package/python-uvloop/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_UVLOOP
depends on BR2_USE_MMU # libuv
depends on !BR2_STATIC_LIBS # libuv
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_PYTHON3_SSL
help
@@ -11,7 +12,8 @@ config BR2_PACKAGE_PYTHON_UVLOOP
http://github.com/MagicStack/uvloop
-comment "python-uvloop needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "python-uvloop needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on BR2_USE_MMU
diff --git a/package/ttyd/Config.in b/package/ttyd/Config.in
index ecc705b17e..103a4ac4aa 100644
--- a/package/ttyd/Config.in
+++ b/package/ttyd/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_TTYD
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv, json-c
depends on BR2_USE_MMU # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_LIBWEBSOCKETS
@@ -15,7 +16,8 @@ config BR2_PACKAGE_TTYD
https://github.com/tsl0922/ttyd
-comment "ttyd needs a toolchain w/ NPTL, dynamic library"
- depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+comment "ttyd needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
+ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
index 92abc9cb25..4191936113 100644
--- a/package/wampcc/Config.in
+++ b/package/wampcc/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_WAMPCC
depends on !BR2_STATIC_LIBS # libuv
depends on BR2_TOOLCHAIN_HAS_ATOMIC
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
select BR2_PACKAGE_LIBUV
select BR2_PACKAGE_JANSSON
@@ -16,12 +17,13 @@ config BR2_PACKAGE_WAMPCC
https://github.com/darrenjs/wampcc
-comment "wampcc needs a toolchain w/ C++, NPTL, dynamic library"
+comment "wampcc needs a toolchain w/ C++, NPTL, dynamic library, gcc >= 4.9"
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_ATOMIC
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_INSTALL_LIBSTDCPP || \
- !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+ !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
comment "wampcc needs a toolchain not affected by GCC bug 64735"
depends on BR2_USE_MMU
diff --git a/package/xmrig/Config.in b/package/xmrig/Config.in
index 4dd16fa2b0..0b5f5370e4 100644
--- a/package/xmrig/Config.in
+++ b/package/xmrig/Config.in
@@ -15,6 +15,7 @@ config BR2_PACKAGE_XMRIG
# xmrig needs fenv.h which is not provided by uclibc
depends on !BR2_TOOLCHAIN_USES_UCLIBC
depends on !BR2_STATIC_LIBS # libuv
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
depends on BR2_INSTALL_LIBSTDCPP
select BR2_PACKAGE_LIBUV
help
@@ -22,10 +23,11 @@ config BR2_PACKAGE_XMRIG
https://xmrig.com
-comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library, C++"
+comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library, C++, gcc >= 4.9"
depends on BR2_PACKAGE_XMRIG_ARCH_SUPPORTS
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
BR2_TOOLCHAIN_USES_UCLIBC || BR2_STATIC_LIBS || \
- !BR2_INSTALL_LIBSTDCPP
+ !BR2_INSTALL_LIBSTDCPP || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
--
2.40.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9
2023-09-17 19:48 [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9 Fabrice Fontaine
@ 2023-09-21 19:43 ` Arnout Vandecappelle via buildroot
2023-09-26 5:49 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2023-09-21 19:43 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot
Cc: Bernd Kuhls, Bartosz Bilas, Asaf Kahlon, James Hilliard,
Marcin Niestroj, Thomas Petazzoni, Giulio Benetti
On 17/09/2023 21:48, Fabrice Fontaine wrote:
> libuv unconditionally uses stdatomic since
> https://github.com/libuv/libuv/commit/2f33980a9141bd49cb2c34361854355b23b1e6fc
> resulting in the following build failure with gcc < 4.9 since bump to
> version 1.45.0 in commit 21764235cb7f7fb767ea4b5d825e39c711aee235:
>
> In file included from src/fs-poll.c:23:0:
> src/uv-common.h:41:24: fatal error: stdatomic.h: No such file or directory
> # include <stdatomic.h>
> ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/6b9ce25ba7e5c5602313d533f460f8829f767f81
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
[snip]
> diff --git a/package/cmake/Config.in b/package/cmake/Config.in
> index 4ef5612b57..57b1ebf9fd 100644
> --- a/package/cmake/Config.in
> +++ b/package/cmake/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_CMAKE
> config BR2_PACKAGE_CMAKE_CTEST
> bool "ctest"
> depends on BR2_PACKAGE_CMAKE_ARCH_SUPPORTS
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # from jsoncpp
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv
Here, I kept jsoncpp in the comment as well. That way, if someone ever removes
the libuv dependency, they are reminded that jsoncpp also introduces a gcc
version dependency.
Note that for nodejs and uvw, the gcc version dependency comes from the
package itself; there's no way that that version dependency will ever go away,
so there's no need to track the dependencies.
Regards,
Arnout
[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9
2023-09-17 19:48 [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9 Fabrice Fontaine
2023-09-21 19:43 ` Arnout Vandecappelle via buildroot
@ 2023-09-26 5:49 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-09-26 5:49 UTC (permalink / raw)
To: Fabrice Fontaine
Cc: Bernd Kuhls, Bartosz Bilas, Asaf Kahlon, James Hilliard,
Marcin Niestroj, Thomas Petazzoni, buildroot, Giulio Benetti
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libuv unconditionally uses stdatomic since
> https://github.com/libuv/libuv/commit/2f33980a9141bd49cb2c34361854355b23b1e6fc
> resulting in the following build failure with gcc < 4.9 since bump to
> version 1.45.0 in commit 21764235cb7f7fb767ea4b5d825e39c711aee235:
> In file included from src/fs-poll.c:23:0:
> src/uv-common.h:41:24: fatal error: stdatomic.h: No such file or directory
> # include <stdatomic.h>
> ^
> Fixes:
> - http://autobuild.buildroot.org/results/6b9ce25ba7e5c5602313d533f460f8829f767f81
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-26 5:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 19:48 [Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9 Fabrice Fontaine
2023-09-21 19:43 ` Arnout Vandecappelle via buildroot
2023-09-26 5:49 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox