Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Charles Hardin <ckhardin@gmail.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] toolchain/toolchain-external: add aarch64 as a hostarch for arm tools
Date: Mon, 02 May 2022 07:49:42 +0300	[thread overview]
Message-ID: <87ilqoy1qr.fsf@tarshish> (raw)
In-Reply-To: <CAN=fXj2w7t3g2t69QgTjTMqD5pkq1zycNYUggPTBnaB8NJfM-g@mail.gmail.com>

Hi Charles,

On Sun, May 01 2022, Charles Hardin wrote:
> On Sun, May 1, 2022 at 9:16 PM Baruch Siach <baruch@tkos.co.il> wrote:
>> On Sun, May 01 2022, Charles Hardin wrote:
>> > From: Charles Hardin <ckhardin@gmail.com>
>> >
>> > The gcc toolchain is also released for an aarch64 host target and allow
>> > that configuration to be used as part of the configuration. Tested on
>> > on a aarch64 linux docker.
>> >
>> > Signed-off-by: Charles Hardin <ckhardin@gmail.com>
>>
>> [...]
>>
>> > diff --git
>> > a/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk
>> > b/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk
>> > index 4392205105..0f554953ec 100644
>> > --- a/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk
>> > +++ b/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk
>> > @@ -7,6 +7,10 @@
>> >  TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION = 2021.07
>> >  TOOLCHAIN_EXTERNAL_ARM_ARM_SITE =
>> > https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)/binrel
>> >
>> > +ifeq ($(HOSTARCH),aarch64)
>> > +TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE =
>> > gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-aarch64-arm-none-linux-gnueabihf.tar.xz
>> > +else
>> >  TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE =
>> > gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-x86_64-arm-none-linux-gnueabihf.tar.xz
>> > +endif
>>
>> Maybe just
>>
>> TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE =
>> gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-$(HOSTARCH)-arm-none-linux-gnueabihf.tar.xz
>
> Following the pattern seen in toolchain-external-linaro-arm.mk - no
> problem changing it - for reference this is what i saw in the other
> .mk
>
> ifeq ($(HOSTARCH),x86)
> TOOLCHAIN_EXTERNAL_LINARO_ARM_SOURCE =
> gcc-linaro-7.3.1-$(TOOLCHAIN_EXTERNAL_LINARO_ARM_VERSION)-i686_arm-linux-gnueabihf.tar.xz
> else
> TOOLCHAIN_EXTERNAL_LINARO_ARM_SOURCE =
> gcc-linaro-7.3.1-$(TOOLCHAIN_EXTERNAL_LINARO_ARM_VERSION)-x86_64_arm-linux-gnueabihf.tar.xz
> endif

As strings i686 != x86, so you can't use HOSTARCH directly here. But I
think we can use HOSTARCH directly where possible.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-05-02  4:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02  4:05 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: add aarch64 as a hostarch for arm tools Charles Hardin
2022-05-02  4:13 ` Baruch Siach via buildroot
2022-05-02  4:21   ` Charles Hardin
2022-05-02  4:49     ` Baruch Siach via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilqoy1qr.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=ckhardin@gmail.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox