Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] strace: fix build for x86_64
@ 2012-10-30 20:59 Arnout Vandecappelle
  2012-10-30 21:05 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2012-10-30 20:59 UTC (permalink / raw)
  To: buildroot

strace fails to build on x86_64 because stat64 is not available.  This
is because the automatic detection of stat64 in configure is overridden
by buildroot, by setting ac_cv_type_stat64.  Just remove that override -
current strace seems to detect it correctly for non-largefile platforms.

Build-tested on x86_64 (with largefile), ARM (with and without largefile),
sh4, MIPS and ppc-32 (no largefile).

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/strace/strace.mk |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/strace/strace.mk b/package/strace/strace.mk
index 7876848..ad1d042 100644
--- a/package/strace/strace.mk
+++ b/package/strace/strace.mk
@@ -9,8 +9,7 @@ STRACE_SOURCE = strace-$(STRACE_VERSION).tar.xz
 STRACE_SITE = http://downloads.sourceforge.net/project/strace/strace/$(STRACE_VERSION)
 
 STRACE_CONF_ENV = ac_cv_header_linux_if_packet_h=yes \
-		  ac_cv_header_linux_netlink_h=yes \
-	          $(if $(BR2_LARGEFILE),ac_cv_type_stat64=yes,ac_cv_type_stat64=no)
+		  ac_cv_header_linux_netlink_h=yes
 
 ifeq ($(BR2_LARGEFILE),y)
 # strace gets confused when lfs mode is forced, so don't
-- 
tg: (29266a3..) t/strace-x86_64 (depends on: master)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] strace: fix build for x86_64
  2012-10-30 20:59 [Buildroot] [PATCH] strace: fix build for x86_64 Arnout Vandecappelle
@ 2012-10-30 21:05 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2012-10-30 21:05 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> strace fails to build on x86_64 because stat64 is not
 Arnout> available.  This is because the automatic detection of stat64
 Arnout> in configure is overridden by buildroot, by setting
 Arnout> ac_cv_type_stat64.  Just remove that override - current strace
 Arnout> seems to detect it correctly for non-largefile platforms.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-30 21:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-30 20:59 [Buildroot] [PATCH] strace: fix build for x86_64 Arnout Vandecappelle
2012-10-30 21:05 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox