Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] Adding libev to buildroot
Date: Sat, 10 Sep 2011 17:13:50 +0200	[thread overview]
Message-ID: <87ipp0ig5t.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <4E3FF8DD.6070507@visionsystems.de> (Yegor Yefremov's message of "Mon, 08 Aug 2011 16:55:25 +0200")

>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:

 Yegor> Hello Bernhard,
 >> I did a patch according to Linus' description.
 >> I hope this works and describes clearly the changes I did.
 >> 
 >> Just today I was recompiling a new root filesystem and libev works just like a charm!
 >> Keep your good work going, thank you!

 Yegor> Thank you for the patch. Some remarks below:

 Yegor> 1. the patches should be sent "inline", so it is easier to comment on them
 Yegor> 2. your' Signed-off-by is still missing (see other patches on the list)
 Yegor> 3. don't use :=, use = instead
 Yegor> 4. this is autotools based package, so following template should be used http://buildroot.uclibc.org/buildroot.html#autotools-tutorial

 Yegor> I've reworked your patch. So please execute "make clean" or remove all files installed by installation of libev and test it with reworked patch.

Thanks, committed. I took the liberty to add both your signed-off-by's,
hope that's ok.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-09-10 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-07 11:10 [Buildroot] Adding libev to buildroot Bernhard Roth
2011-08-07 21:04 ` Yegor Yefremov
     [not found]   ` <4E3F79CF.40608@roth-itk.de>
     [not found]     ` <CAGm1_ktqDGmoRtbWuN8uDM3qiL00K+kS-VbyVcDV3p9sqav9Jg@mail.gmail.com>
2011-08-08 13:19       ` Bernhard Roth
2011-08-08 14:55         ` Yegor Yefremov
2011-09-10 15:13           ` Peter Korsgaard [this message]
2011-09-10 21:27             ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipp0ig5t.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox