Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Adding libev to buildroot
@ 2011-08-07 11:10 Bernhard Roth
  2011-08-07 21:04 ` Yegor Yefremov
  0 siblings, 1 reply; 6+ messages in thread
From: Bernhard Roth @ 2011-08-07 11:10 UTC (permalink / raw)
  To: buildroot

Hello all,

I am using buildroot for a while now and I always have to add the libev 
library for my projects. Libev is a lightweight and powerful alternative 
to livevent.
Maybe it's possible to add libev support to the next official version of 
buildroot.

Attached I send you the package config files for libev which I use 
(based on libevent files)
Please put them into package/libev.

Finally following line has to be added to package/Config.in just after 
libevent

source "package/libev/Config.in"

Best regards,

Bernhard Roth

-- 
____________________________________
Roth ITK Consulting GmbH
Landsberger Str. 398
81241 M?nchen
Germany

Fon: +49 89 461317-0
Fax: +49 89 461317-29
Email: broth at roth-itk.de
Web: http://www.roth-itk.de/

Gesch?ftsf?hrer: Bernhard Roth
HRB 174971, Amtsgericht M?nchen
UID: DE 261 708 872
____________________________________


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Config.in
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110807/7726e19d/attachment.in>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libev.mk
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110807/7726e19d/attachment.ksh>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] Adding libev to buildroot
  2011-08-07 11:10 [Buildroot] Adding libev to buildroot Bernhard Roth
@ 2011-08-07 21:04 ` Yegor Yefremov
       [not found]   ` <4E3F79CF.40608@roth-itk.de>
  0 siblings, 1 reply; 6+ messages in thread
From: Yegor Yefremov @ 2011-08-07 21:04 UTC (permalink / raw)
  To: buildroot

Hello Bernhard,

On Sun, Aug 7, 2011 at 1:10 PM, Bernhard Roth <broth@roth-itk.de> wrote:
> Hello all,
>
> I am using buildroot for a while now and I always have to add the libev
> library for my projects. Libev is a lightweight and powerful alternative to
> livevent.
> Maybe it's possible to add libev support to the next official version of
> buildroot.
>
> Attached I send you the package config files for libev which I use (based on
> libevent files)
> Please put them into package/libev.
>
> Finally following line has to be added to package/Config.in just after
> libevent
>
> source "package/libev/Config.in"

Please send a proper patch using git or quilt and add your Signed-off-by string.

Yegor

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] Adding libev to buildroot
       [not found]     ` <CAGm1_ktqDGmoRtbWuN8uDM3qiL00K+kS-VbyVcDV3p9sqav9Jg@mail.gmail.com>
@ 2011-08-08 13:19       ` Bernhard Roth
  2011-08-08 14:55         ` Yegor Yefremov
  0 siblings, 1 reply; 6+ messages in thread
From: Bernhard Roth @ 2011-08-08 13:19 UTC (permalink / raw)
  To: buildroot

Hello Yegor,

I did a patch according to Linus' description.
I hope this works and describes clearly the changes I did.

Just today I was recompiling a new root filesystem and libev works just 
like a charm!
Keep your good work going, thank you!

Best regards,

Bernhard


On 08/08/2011 08:34 AM, Yegor Yefremov wrote:
> Hello Bernhard,
>
> you have following ways to get to the patch:
>
> 1. see kernel documentation on how to compare two src dirs:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD
> 2. using quilt: http://en.wikipedia.org/wiki/Quilt_%28software%29. It
> requires one clean src dir, your two files you sent to the list and
> changes to package/Config.in
> 3. git: clone buildroot repository, make your changes, git add, git
> commit, http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html.
> See http://progit.org/book/ for syntax and details
>
> Yegor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libev.patch
Type: text/x-patch
Size: 3325 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110808/40cdafee/attachment.bin>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] Adding libev to buildroot
  2011-08-08 13:19       ` Bernhard Roth
@ 2011-08-08 14:55         ` Yegor Yefremov
  2011-09-10 15:13           ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Yegor Yefremov @ 2011-08-08 14:55 UTC (permalink / raw)
  To: buildroot

Hello Bernhard,

> I did a patch according to Linus' description.
> I hope this works and describes clearly the changes I did.
> 
> Just today I was recompiling a new root filesystem and libev works just like a charm!
> Keep your good work going, thank you!

Thank you for the patch. Some remarks below:

1. the patches should be sent "inline", so it is easier to comment on them
2. your' Signed-off-by is still missing (see other patches on the list)
3. don't use :=, use = instead
4. this is autotools based package, so following template should be used http://buildroot.uclibc.org/buildroot.html#autotools-tutorial

I've reworked your patch. So please execute "make clean" or remove all files installed by installation of libev and test it with reworked patch.

Yegor

---
 package/Config.in       |    1 +
 package/libev/Config.in |    6 ++++++
 package/libev/libev.mk  |   11 +++++++++++
 3 files changed, 18 insertions(+)

Index: b/package/Config.in
===================================================================
--- a/package/Config.in
+++ b/package/Config.in
@@ -341,6 +341,7 @@
 source "package/libdaemon/Config.in"
 source "package/libelf/Config.in"
 source "package/libevent/Config.in"
+source "package/libev/Config.in"
 source "package/libffi/Config.in"
 source "package/libglib2/Config.in"
 source "package/libnspr/Config.in"
Index: b/package/libev/Config.in
===================================================================
--- /dev/null
+++ b/package/libev/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBEV
+	bool "libev"
+	help
+	  Userspace library for handling asynchronous notifications
+
+	  http://software.schmorp.de/pkg/libev.html
Index: b/package/libev/libev.mk
===================================================================
--- /dev/null
+++ b/package/libev/libev.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# libev
+#
+#############################################################
+LIBEV_VERSION = 4.04
+LIBEV_SOURCE = libev-$(LIBEV_VERSION).tar.gz
+LIBEV_SITE = http://dist.schmorp.de/libev/
+LIBEV_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS,package,libev))

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] Adding libev to buildroot
  2011-08-08 14:55         ` Yegor Yefremov
@ 2011-09-10 15:13           ` Peter Korsgaard
  2011-09-10 21:27             ` Yegor Yefremov
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2011-09-10 15:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:

 Yegor> Hello Bernhard,
 >> I did a patch according to Linus' description.
 >> I hope this works and describes clearly the changes I did.
 >> 
 >> Just today I was recompiling a new root filesystem and libev works just like a charm!
 >> Keep your good work going, thank you!

 Yegor> Thank you for the patch. Some remarks below:

 Yegor> 1. the patches should be sent "inline", so it is easier to comment on them
 Yegor> 2. your' Signed-off-by is still missing (see other patches on the list)
 Yegor> 3. don't use :=, use = instead
 Yegor> 4. this is autotools based package, so following template should be used http://buildroot.uclibc.org/buildroot.html#autotools-tutorial

 Yegor> I've reworked your patch. So please execute "make clean" or remove all files installed by installation of libev and test it with reworked patch.

Thanks, committed. I took the liberty to add both your signed-off-by's,
hope that's ok.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] Adding libev to buildroot
  2011-09-10 15:13           ` Peter Korsgaard
@ 2011-09-10 21:27             ` Yegor Yefremov
  0 siblings, 0 replies; 6+ messages in thread
From: Yegor Yefremov @ 2011-09-10 21:27 UTC (permalink / raw)
  To: buildroot

On Sat, Sep 10, 2011 at 5:13 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:
>
> ?Yegor> Hello Bernhard,
> ?>> I did a patch according to Linus' description.
> ?>> I hope this works and describes clearly the changes I did.
> ?>>
> ?>> Just today I was recompiling a new root filesystem and libev works just like a charm!
> ?>> Keep your good work going, thank you!
>
> ?Yegor> Thank you for the patch. Some remarks below:
>
> ?Yegor> 1. the patches should be sent "inline", so it is easier to comment on them
> ?Yegor> 2. your' Signed-off-by is still missing (see other patches on the list)
> ?Yegor> 3. don't use :=, use = instead
> ?Yegor> 4. this is autotools based package, so following template should be used http://buildroot.uclibc.org/buildroot.html#autotools-tutorial
>
> ?Yegor> I've reworked your patch. So please execute "make clean" or remove all files installed by installation of libev and test it with reworked patch.
>
> Thanks, committed. I took the liberty to add both your signed-off-by's,
> hope that's ok.

Thanks for committing.

Yegor

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-09-10 21:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-07 11:10 [Buildroot] Adding libev to buildroot Bernhard Roth
2011-08-07 21:04 ` Yegor Yefremov
     [not found]   ` <4E3F79CF.40608@roth-itk.de>
     [not found]     ` <CAGm1_ktqDGmoRtbWuN8uDM3qiL00K+kS-VbyVcDV3p9sqav9Jg@mail.gmail.com>
2011-08-08 13:19       ` Bernhard Roth
2011-08-08 14:55         ` Yegor Yefremov
2011-09-10 15:13           ` Peter Korsgaard
2011-09-10 21:27             ` Yegor Yefremov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox