* [Buildroot] [PATCH] zlib: Replace negative logic in Makefile with positive
@ 2009-09-29 22:36 Michael Roth
2009-09-30 9:53 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Michael Roth @ 2009-09-29 22:36 UTC (permalink / raw)
To: buildroot
Positive logic is easier to read and understand than something
like 'if not option=yes then foo else bar'.
Signed-off-by: Michael Roth <mroth@nessie.de>
---
package/zlib/zlib.mk | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/package/zlib/zlib.mk b/package/zlib/zlib.mk
index 41d0632..a67a5e8 100644
--- a/package/zlib/zlib.mk
+++ b/package/zlib/zlib.mk
@@ -18,14 +18,14 @@ $(ZLIB_DIR)/.patched: $(DL_DIR)/$(ZLIB_SOURCE)
$(CONFIG_UPDATE) $(@D)
touch $@
-ifneq ($(BR2_PREFER_STATIC_LIB),y)
-ZLIB_PIC := -fPIC
-ZLIB_SHARED := --shared
-ZLIB_TARGET := $(TARGET_DIR)/usr/lib/libz.so
-else
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
ZLIB_PIC :=
ZLIB_SHARED :=
ZLIB_TARGET := $(STAGING_DIR)/usr/lib/libz.a
+else
+ZLIB_PIC := -fPIC
+ZLIB_SHARED := --shared
+ZLIB_TARGET := $(TARGET_DIR)/usr/lib/libz.so
endif
$(ZLIB_DIR)/.configured: $(ZLIB_DIR)/.patched
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] zlib: Replace negative logic in Makefile with positive
2009-09-29 22:36 [Buildroot] [PATCH] zlib: Replace negative logic in Makefile with positive Michael Roth
@ 2009-09-30 9:53 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2009-09-30 9:53 UTC (permalink / raw)
To: buildroot
>>>>> "Michael" == Michael Roth <mroth@nessie.de> writes:
Michael> Positive logic is easier to read and understand than something
Michael> like 'if not option=yes then foo else bar'.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-30 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-29 22:36 [Buildroot] [PATCH] zlib: Replace negative logic in Makefile with positive Michael Roth
2009-09-30 9:53 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox