* [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
@ 2023-09-21 20:39 ~bubu
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: ~bubu @ 2023-09-21 20:39 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Calling `setup.py` build builds and installs an empty package
after upstream changed their packaging. Calling setuptools via
`python -m build` builds the package correctly.
---
package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
index 5a6e7733be..cb8a0d8cc9 100644
--- a/package/python-minimalmodbus/python-minimalmodbus.mk
+++ b/package/python-minimalmodbus/python-minimalmodbus.mk
@@ -7,7 +7,8 @@
PYTHON_MINIMALMODBUS_VERSION = 2.1.1
PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
-PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
+PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
+PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
--
2.38.5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
2023-09-21 20:39 [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package ~bubu
@ 2024-02-05 13:38 ` Marcus Hoffmann via buildroot
2024-02-05 13:47 ` Yann E. MORIN
2024-02-05 14:39 ` Yann E. MORIN
2024-02-29 15:22 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Marcus Hoffmann via buildroot @ 2024-02-05 13:38 UTC (permalink / raw)
To: buildroot
Forgot my SoB
On 21.09.23 22:39, ~bubu wrote:
> From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
>
> Calling `setup.py` build builds and installs an empty package
> after upstream changed their packaging. Calling setuptools via
> `python -m build` builds the package correctly.
Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
> ---
> package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> index 5a6e7733be..cb8a0d8cc9 100644
> --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> @@ -7,7 +7,8 @@
> PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
@ 2024-02-05 13:47 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-02-05 13:47 UTC (permalink / raw)
To: Marcus Hoffmann; +Cc: buildroot
Marcus, All,
On 2024-02-05 14:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> Forgot my SoB
> On 21.09.23 22:39, ~bubu wrote:
> > From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> > Calling `setup.py` build builds and installs an empty package
> > after upstream changed their packaging. Calling setuptools via
> > `python -m build` builds the package correctly.
> Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Thanks. However, the SoB line needs to match the author of the commit,
and that does not match:
Author: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Regards,
Yann E. MORIN.
> > ---
> > package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> > index 5a6e7733be..cb8a0d8cc9 100644
> > --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> > @@ -7,7 +7,8 @@
> > PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> > PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> > PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> > -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> > +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> > +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> > PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> > PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
2023-09-21 20:39 [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package ~bubu
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
@ 2024-02-05 14:39 ` Yann E. MORIN
2024-02-05 17:20 ` James Hilliard
2024-02-29 15:22 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2024-02-05 14:39 UTC (permalink / raw)
To: ~bubu; +Cc: James Hilliard, buildroot
Marcus, All,
On 2023-09-21 22:39 +0200, ~bubu spake thusly:
> From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
>
> Calling `setup.py` build builds and installs an empty package
> after upstream changed their packaging. Calling setuptools via
> `python -m build` builds the package correctly.
Applied to master, after fixing the authroship and Sob as we discussed
IRL, thanks.
Regards,
Yann E. MORIN.
> ---
> package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> index 5a6e7733be..cb8a0d8cc9 100644
> --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> @@ -7,7 +7,8 @@
> PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
>
> --
> 2.38.5
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
2024-02-05 14:39 ` Yann E. MORIN
@ 2024-02-05 17:20 ` James Hilliard
0 siblings, 0 replies; 6+ messages in thread
From: James Hilliard @ 2024-02-05 17:20 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: ~bubu, buildroot
On Mon, Feb 5, 2024 at 7:39 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Marcus, All,
>
> On 2023-09-21 22:39 +0200, ~bubu spake thusly:
> > From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> >
> > Calling `setup.py` build builds and installs an empty package
> > after upstream changed their packaging. Calling setuptools via
> > `python -m build` builds the package correctly.
>
> Applied to master, after fixing the authroship and Sob as we discussed
> IRL, thanks.
FYI we should be able to revert this once we migrate setuptools infrastructure
to pep517:
https://patchwork.ozlabs.org/project/buildroot/patch/20231126180840.2081945-5-james.hilliard1@gmail.com/
>
> Regards,
> Yann E. MORIN.
>
> > ---
> > package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> > index 5a6e7733be..cb8a0d8cc9 100644
> > --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> > @@ -7,7 +7,8 @@
> > PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> > PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> > PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> > -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> > +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> > +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> > PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> > PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> >
> > --
> > 2.38.5
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
2023-09-21 20:39 [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package ~bubu
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
2024-02-05 14:39 ` Yann E. MORIN
@ 2024-02-29 15:22 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2024-02-29 15:22 UTC (permalink / raw)
To: ~bubu; +Cc: James Hilliard, ~bubu, buildroot
>>>>> "~bubu" == ~bubu <bubu@git.sr.ht> writes:
> From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> Calling `setup.py` build builds and installs an empty package
> after upstream changed their packaging. Calling setuptools via
> `python -m build` builds the package correctly.
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-29 15:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-21 20:39 [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package ~bubu
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
2024-02-05 13:47 ` Yann E. MORIN
2024-02-05 14:39 ` Yann E. MORIN
2024-02-05 17:20 ` James Hilliard
2024-02-29 15:22 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox