[Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[James Hilliard]

Remove no longer supported soup2 config option

We now build webkit with soup3 so we need to set wpe_api to 2.0 to
be compatible.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/cog/cog.hash | 8 ++++----
 package/cog/cog.mk   | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/cog/cog.hash b/package/cog/cog.hash
index 2ea3ddee08..9fb386dfa0 100644
--- a/package/cog/cog.hash
+++ b/package/cog/cog.hash
@@ -1,7 +1,7 @@
-# From https://wpewebkit.org/releases/cog-0.16.1.tar.xz.sums
-md5  1489740db6b4ea568578035c30b8b2f4  cog-0.16.1.tar.xz
-sha1  1235203085e7ccd8fc76eab6bdfcdb2e3ae38ea9  cog-0.16.1.tar.xz
-sha256  37c5f14123b8dcf077839f6c60f0d721d2a91bb37829e796f420126e6b0d38b5  cog-0.16.1.tar.xz
+# From https://wpewebkit.org/releases/cog-0.18.0.tar.xz.sums
+md5  9521458c72322e1b2e39e8b1cca93d24  cog-0.18.0.tar.xz
+sha1  73ec1684c31de7247ecbd5e852c16cf88416bedd  cog-0.18.0.tar.xz
+sha256  410bf70f9aa3812db72d75c25cefee421efa0391ab03dc3c37299dfaa388f4fd  cog-0.18.0.tar.xz
 
 # Hashes for license files:
 sha256  e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index da4bfc7ac6..f41c114fa5 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-COG_VERSION = 0.16.1
+COG_VERSION = 0.18.0
 COG_SITE = https://wpewebkit.org/releases
 COG_SOURCE = cog-$(COG_VERSION).tar.xz
 COG_INSTALL_STAGING = YES
@@ -15,7 +15,7 @@ COG_CONF_OPTS = \
 	-Ddocumentation=false \
 	-Dmanpages=false \
 	-Dprograms=true \
-	-Dsoup2=enabled \
+	-Dwpe_api=2.0 \
 	-Dcog_home_uri='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))' \
 	-Dplatforms='$(subst $(space),$(comma),$(strip $(COG_PLATFORMS_LIST)))'
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[Thomas Petazzoni via buildroot]

On Fri,  8 Sep 2023 13:27:14 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> -COG_VERSION = 0.16.1
> +COG_VERSION = 0.18.0
>  COG_SITE = https://wpewebkit.org/releases
>  COG_SOURCE = cog-$(COG_VERSION).tar.xz
>  COG_INSTALL_STAGING = YES
> @@ -15,7 +15,7 @@ COG_CONF_OPTS = \
>  	-Ddocumentation=false \
>  	-Dmanpages=false \
>  	-Dprograms=true \
> -	-Dsoup2=enabled \

Shouldn't this have been changed to -Dsoup2=disabled as part of commit
dff67170f73959e6826ec3e87e892747f8d3a5fb, which changed wpewebkit to
use libsoup3 instead of libsoup2 ?

I think it makes sense to have this separate from the cog version bump.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[James Hilliard]

On Fri, Sep 8, 2023 at 1:46 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Fri,  8 Sep 2023 13:27:14 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > -COG_VERSION = 0.16.1
> > +COG_VERSION = 0.18.0
> >  COG_SITE = https://wpewebkit.org/releases
> >  COG_SOURCE = cog-$(COG_VERSION).tar.xz
> >  COG_INSTALL_STAGING = YES
> > @@ -15,7 +15,7 @@ COG_CONF_OPTS = \
> >       -Ddocumentation=false \
> >       -Dmanpages=false \
> >       -Dprograms=true \
> > -     -Dsoup2=enabled \
>
> Shouldn't this have been changed to -Dsoup2=disabled as part of commit
> dff67170f73959e6826ec3e87e892747f8d3a5fb, which changed wpewebkit to
> use libsoup3 instead of libsoup2 ?

There were build errors, the version bump seems to be required to use libsoup3.

>
> I think it makes sense to have this separate from the cog version bump.
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[Thomas Petazzoni via buildroot]

On Fri, 8 Sep 2023 14:58:23 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> > Shouldn't this have been changed to -Dsoup2=disabled as part of commit
> > dff67170f73959e6826ec3e87e892747f8d3a5fb, which changed wpewebkit to
> > use libsoup3 instead of libsoup2 ?  
> 
> There were build errors, the version bump seems to be required to use libsoup3.

Could you provide the failing defconfig, and verify indeed that with
-Dsoup2=disabled it doesn't work, without the version bump? We want
justifications that are more convincing than "seems to be required".

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[James Hilliard]

On Sat, Sep 9, 2023 at 12:31 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Fri, 8 Sep 2023 14:58:23 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > > Shouldn't this have been changed to -Dsoup2=disabled as part of commit
> > > dff67170f73959e6826ec3e87e892747f8d3a5fb, which changed wpewebkit to
> > > use libsoup3 instead of libsoup2 ?
> >
> > There were build errors, the version bump seems to be required to use libsoup3.
>
> Could you provide the failing defconfig, and verify indeed that with
> -Dsoup2=disabled it doesn't work, without the version bump? We want
> justifications that are more convincing than "seems to be required".

I had tried using -Dsoup2=disabled before I sent the update already.

I hit a missing symbols issue related to this which was only added in
version 0.17.1:
https://github.com/Igalia/cog/commit/c7bdb9cd3991b29abe9f4574685467f79d8fed34
https://github.com/Igalia/cog/pull/522

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cog: bump to version 0.18.0

[Peter Korsgaard]

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > Remove no longer supported soup2 config option
 > We now build webkit with soup3 so we need to set wpe_api to 2.0 to
 > be compatible.

 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot