[Buildroot] [PATCH 1/1] boot/at91dataflashboot: force arm mode instead of Thumb mode

[Buildroot] [PATCH 1/1] boot/at91dataflashboot: force arm mode instead of Thumb mode

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/68b/68bf2291201ef1882d8e8d3eca2b1a5ad731e4b0/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 boot/at91dataflashboot/at91dataflashboot.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/boot/at91dataflashboot/at91dataflashboot.mk b/boot/at91dataflashboot/at91dataflashboot.mk
index c66f27e343..cb329a90df 100644
--- a/boot/at91dataflashboot/at91dataflashboot.mk
+++ b/boot/at91dataflashboot/at91dataflashboot.mk
@@ -11,9 +11,14 @@ AT91DATAFLASHBOOT_SITE = ftp://www.at91.com/pub/buildroot
 AT91DATAFLASHBOOT_INSTALL_TARGET = NO
 AT91DATAFLASHBOOT_INSTALL_IMAGES = YES
 
+AT91DATAFLASHBOOT_CFLAGS = $(TARGET_CFLAGS) -fno-stack-protector
+ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
+AT91DATAFLASHBOOT_CFLAGS += -marm
+endif
+
 define AT91DATAFLASHBOOT_BUILD_CMDS
 	make -C $(@D) CROSS_COMPILE=$(TARGET_CROSS) \
-		CFLAGS="$(TARGET_CFLAGS) -fno-stack-protector"
+		CFLAGS="$(AT91DATAFLASHBOOT_CFLAGS)"
 endef
 
 define AT91DATAFLASHBOOT_INSTALL_IMAGES_CMDS
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] boot/at91dataflashboot: force arm mode instead of Thumb mode

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Wed,  2 Aug 2023 22:31:46 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/68b/68bf2291201ef1882d8e8d3eca2b1a5ad731e4b0/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  boot/at91dataflashboot/at91dataflashboot.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

You forgot to explain in the commit since when the issue has been
occurring. So I've added some explanation about this in the commit log
when applying:

  https://gitlab.com/buildroot.org/buildroot/-/commit/07acc00add7ac09114f3c01b85d794a31c68229c

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] boot/at91dataflashboot: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Hello Bernd,
 > On Wed,  2 Aug 2023 22:31:46 +0200
 > Bernd Kuhls <bernd@kuhls.net> wrote:

 >> Fixes:
 >> http://autobuild.buildroot.net/results/68b/68bf2291201ef1882d8e8d3eca2b1a5ad731e4b0/
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 >> ---
 >> boot/at91dataflashboot/at91dataflashboot.mk | 7 ++++++-
 >> 1 file changed, 6 insertions(+), 1 deletion(-)

 > You forgot to explain in the commit since when the issue has been
 > occurring. So I've added some explanation about this in the commit log
 > when applying:

 >   https://gitlab.com/buildroot.org/buildroot/-/commit/07acc00add7ac09114f3c01b85d794a31c68229c

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot