Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] hackrf: new package
Date: Sun, 01 Apr 2018 14:32:29 +0200	[thread overview]
Message-ID: <87k1trrtsy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <87o9j3rtwe.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of "Sun, 01 Apr 2018 14:30:25 +0200")

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

Hi,

 >> +config BR2_PACKAGE_HACKRF
 >> +	bool "hackrf"
 >> +	depends on !BR2_STATIC_LIBS
 >> +	depends on BR2_TOOLCHAIN_HAS_THREADS
 >> +	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE

 > While not strictly required I think we should select BR2_PACKAGE_FFTW so
 > it cannot easily be deselected in menuconfig.

 > Committed with that fixed, thanks.

Ehh, skip that - kconf gets confused about that:

package/fftw/Config.in:24:error: recursive dependency detected!
package/fftw/Config.in:24:      choice <choice> contains symbol BR2_PACKAGE_FFTW
package/fftw/Config.in:1:       symbol BR2_PACKAGE_FFTW is selected by BR2_PACKAGE_HACKRF
package/hackrf/Config.in:1:     symbol BR2_PACKAGE_HACKRF depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE
package/fftw/Config.in:30:      symbol BR2_PACKAGE_FFTW_PRECISION_SINGLE is part of choice <choice>

grr, I hate choice options :/

Committed without the select.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-04-01 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-31 20:57 [Buildroot] [PATCH] hackrf: new package Arnout Vandecappelle
2018-04-01 12:30 ` Peter Korsgaard
2018-04-01 12:32   ` Peter Korsgaard [this message]
     [not found] ` <4717c3cb-2c10-5e7b-bc3a-3e36dcc963e4@mind.be>
2018-04-02 13:01   ` [Buildroot] Fwd: " Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1trrtsy.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox