Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] hackrf: new package
Date: Sun, 01 Apr 2018 14:30:25 +0200	[thread overview]
Message-ID: <87o9j3rtwe.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180331205758.9652-1-arnout@mind.be> (Arnout Vandecappelle's message of "Sat, 31 Mar 2018 22:57:58 +0200")

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > From: Jason Pruitt <jrspruitt@gmail.com>
 > This patch adds hackrf/host tools for HackRF, a low cost, open source
 > Software Defined Radio platform.

 > Sources of host tools are available on GitHub here:
 > https://github.com/mossmann/hackrf/tree/master/host

 > Signed-off-by: Jason Pruitt <jrspruitt@gmail.com>
 > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
 > [Arnout:
 >  - Rename package to hackrf to match upstream name;
 >  - Reorder dependencies and remove empty line (check-package);
 >  - Use only sha256 hash;
 >  - Add hash for license file;
 >  - Bump to 2018.01.1;
 >  - Use uploaded tarball rather than github-generated one;
 >  - Fix dependencies of comment (|| instead of &&)
 >  - Add UDEV_RULES_GROUP=plugdev in case the build host doesn't have
 >    this group;
 >  - Add patch fixing build without C++ compiler.
 > ]
 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > ---
 > v2: Changes by Arnout, see above

 > +config BR2_PACKAGE_HACKRF
 > +	bool "hackrf"
 > +	depends on !BR2_STATIC_LIBS
 > +	depends on BR2_TOOLCHAIN_HAS_THREADS
 > +	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE

While not strictly required I think we should select BR2_PACKAGE_FFTW so
it cannot easily be deselected in menuconfig.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-04-01 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-31 20:57 [Buildroot] [PATCH] hackrf: new package Arnout Vandecappelle
2018-04-01 12:30 ` Peter Korsgaard [this message]
2018-04-01 12:32   ` Peter Korsgaard
     [not found] ` <4717c3cb-2c10-5e7b-bc3a-3e36dcc963e4@mind.be>
2018-04-02 13:01   ` [Buildroot] Fwd: " Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9j3rtwe.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox