Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] Update crostool-NG backend
@ 2011-08-27 21:07 Yann E. MORIN
  2011-08-27 21:07 ` [Buildroot] [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files Yann E. MORIN
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Yann E. MORIN @ 2011-08-27 21:07 UTC (permalink / raw)
  To: buildroot

Hello All!

This short patch series updates the crosstool-NG backend in two ways:
 - patch 2 is the simple one, and  updates to 1.12.1, which has a few
   fixes since 1.12.0

 - patch 1 is in itself quite simple, but the reasoning behind it is a
   bit more complex, and gave me a headache for a few evenings before I
   could pin-point the issue. More explanation in the patch description.

   Of course, this would require much more love to properly fix, but not
   that close to a release. Hopefully, we can use the dev day in Prague
   to disguss the issue.

   [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files
   [PATCH 2/2] package/crosstool-NG: update version to 1.12.1

Regards,
Yann E. MORIN.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files
  2011-08-27 21:07 [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
@ 2011-08-27 21:07 ` Yann E. MORIN
  2011-08-27 21:07 ` [Buildroot] [PATCH 2/2] package/crosstool-NG: update version to 1.12.1 Yann E. MORIN
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2011-08-27 21:07 UTC (permalink / raw)
  To: buildroot

Bundled config files have architecture-specific values in them,
which may break if buildroot is configured with another architecture
that does not forcibly set these option.

For example, the bundled config files are for x86_64, and define:
    CT_ARCH_TUNE="generic"

This comes from the BR2_GCC_TARGET_TUNE config option (in buildroot) that
is set accordingly to the selected (arch,sub-arch).

But if someone configures buildroot for, say, generic ARM, then the
BR2_GCC_TARGET_TUNE config option is not set, and the crosstool-NG backend
Makefile believes it should not be pushed down to the crosstool-NG config
file.

BUT...

The crosstool-NG backend Makefile can not forcibly push BR2_GCC_TARGET_TUNE
down to the CT-NG config file. If BR2_GCC_TARGET_TUNE is empty, the user can
still set CT_ARCH_TUNE by running ctng-menuconfig.

The backend Makefile already passes such values only if they are set.


In the end, we can't push options as-is to the crosstool-NG config, but we
MUST provide sane bundled config files, which this patch does.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
 .../crosstool-ng.config-eglibc                     |    2 +-
 .../crosstool-ng.config-glibc                      |    4 ++--
 .../crosstool-ng.config-uClibc                     |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-eglibc b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-eglibc
index 3b6a2e2..66744bc 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-eglibc
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-eglibc
@@ -97,7 +97,7 @@ CT_ARCH_SUPPORT_TUNE=y
 CT_ARCH_DEFAULT_32=y
 CT_ARCH_ARCH=""
 CT_ARCH_CPU=""
-CT_ARCH_TUNE="generic"
+CT_ARCH_TUNE=""
 # CT_ARCH_32 is not set
 CT_ARCH_64=y
 CT_ARCH_BITNESS=64
diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc
index cadbb0b..9513432 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc
@@ -97,7 +97,7 @@ CT_ARCH_SUPPORT_TUNE=y
 CT_ARCH_DEFAULT_32=y
 CT_ARCH_ARCH=""
 CT_ARCH_CPU=""
-CT_ARCH_TUNE="generic"
+CT_ARCH_TUNE=""
 # CT_ARCH_32 is not set
 CT_ARCH_64=y
 CT_ARCH_BITNESS=64
@@ -137,7 +137,7 @@ CT_TOOLCHAIN_BUGURL=""
 #
 CT_TARGET_VENDOR="unknown"
 CT_TARGET_ALIAS_SED_EXPR=""
-CT_TARGET_ALIAS="x86_64-linux"
+CT_TARGET_ALIAS=""
 
 #
 # Toolchain type
diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-uClibc b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-uClibc
index 7d90e40..5296923 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.config-uClibc
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.config-uClibc
@@ -97,7 +97,7 @@ CT_ARCH_SUPPORT_TUNE=y
 CT_ARCH_DEFAULT_32=y
 CT_ARCH_ARCH=""
 CT_ARCH_CPU=""
-CT_ARCH_TUNE="generic"
+CT_ARCH_TUNE=""
 # CT_ARCH_32 is not set
 CT_ARCH_64=y
 CT_ARCH_BITNESS=64
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] package/crosstool-NG: update version to 1.12.1
  2011-08-27 21:07 [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
  2011-08-27 21:07 ` [Buildroot] [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files Yann E. MORIN
@ 2011-08-27 21:07 ` Yann E. MORIN
  2011-08-27 21:11 ` [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
  2011-08-28  8:43 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2011-08-27 21:07 UTC (permalink / raw)
  To: buildroot

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
 package/crosstool-ng/crosstool-ng.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/crosstool-ng/crosstool-ng.mk b/package/crosstool-ng/crosstool-ng.mk
index 2bbf631..076be28 100644
--- a/package/crosstool-ng/crosstool-ng.mk
+++ b/package/crosstool-ng/crosstool-ng.mk
@@ -1,4 +1,4 @@
-CROSSTOOL_NG_VERSION           = 1.12.0
+CROSSTOOL_NG_VERSION           = 1.12.1
 CROSSTOOL_NG_SOURCE            = crosstool-ng-$(CROSSTOOL_NG_VERSION).tar.bz2
 CROSSTOOL_NG_SITE              = http://crosstool-ng.org/download/crosstool-ng/
 CROSSTOOL_NG_INSTALL_STAGING   = NO
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 0/2] Update crostool-NG backend
  2011-08-27 21:07 [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
  2011-08-27 21:07 ` [Buildroot] [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files Yann E. MORIN
  2011-08-27 21:07 ` [Buildroot] [PATCH 2/2] package/crosstool-NG: update version to 1.12.1 Yann E. MORIN
@ 2011-08-27 21:11 ` Yann E. MORIN
  2011-08-28  8:43 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2011-08-27 21:11 UTC (permalink / raw)
  To: buildroot

All,

On Saturday 27 August 2011 23:07:41 Yann E. MORIN wrote:
>    Of course, this would require much more love to properly fix, but not
>    that close to a release. Hopefully, we can use the dev day in Prague
>    to disguss the issue.

s/disguss/discuss/;

I know I am a bit keyboard-dyslexic, but I really don't know what was in
my mind at that moment... Grrr...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 0/2] Update crostool-NG backend
  2011-08-27 21:07 [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
                   ` (2 preceding siblings ...)
  2011-08-27 21:11 ` [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
@ 2011-08-28  8:43 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2011-08-28  8:43 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> Hello All!
 Yann> This short patch series updates the crosstool-NG backend in two ways:
 Yann>  - patch 2 is the simple one, and  updates to 1.12.1, which has a few
 Yann>    fixes since 1.12.0

 Yann>  - patch 1 is in itself quite simple, but the reasoning behind it is a
 Yann>    bit more complex, and gave me a headache for a few evenings before I
 Yann>    could pin-point the issue. More explanation in the patch description.

 Yann>    Of course, this would require much more love to properly fix, but not
 Yann>    that close to a release. Hopefully, we can use the dev day in Prague
 Yann>    to disguss the issue.

 Yann>    [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files
 Yann>    [PATCH 2/2] package/crosstool-NG: update version to 1.12.1

Committed both, thanks!

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-08-28  8:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-27 21:07 [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
2011-08-27 21:07 ` [Buildroot] [PATCH 1/2] toolchain/crosstool-NG: fix bundled config files Yann E. MORIN
2011-08-27 21:07 ` [Buildroot] [PATCH 2/2] package/crosstool-NG: update version to 1.12.1 Yann E. MORIN
2011-08-27 21:11 ` [Buildroot] [PATCH 0/2] Update crostool-NG backend Yann E. MORIN
2011-08-28  8:43 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox