* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
@ 2011-06-24 14:08 Mike Williams
2011-06-27 7:10 ` Daniel Nyström
0 siblings, 1 reply; 6+ messages in thread
From: Mike Williams @ 2011-06-24 14:08 UTC (permalink / raw)
To: buildroot
Signed-off-by: Mike Williams <mike@mikebwilliams.com>
---
linux/linux.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index 43ca87b..fbd0fad 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -98,7 +98,7 @@ $(LINUX26_DIR)/.stamp_patched: $(LINUX26_DIR)/.stamp_extracted
if echo $$p | grep -q -E "^ftp://|^http://" ; then \
toolchain/patch-kernel.sh $(@D) $(DL_DIR) `basename $$p` ; \
elif test -d $$p ; then \
- toolchain/patch-kernel.sh $(@D) $$p linux-\*.patch ; \
+ toolchain/patch-kernel.sh $(@D) $$p \*.patch ; \
else \
toolchain/patch-kernel.sh $(@D) `dirname $$p` `basename $$p` ; \
fi \
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
2011-06-24 14:08 [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch Mike Williams
@ 2011-06-27 7:10 ` Daniel Nyström
2011-06-27 12:22 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Nyström @ 2011-06-27 7:10 UTC (permalink / raw)
To: buildroot
2011/6/24 Mike Williams <mike@mikebwilliams.com>:
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -98,7 +98,7 @@ $(LINUX26_DIR)/.stamp_patched: $(LINUX26_DIR)/.stamp_extracted
> ? ? ? ? ? ? ? ?if echo $$p | grep -q -E "^ftp://|^http://" ; then \
> ? ? ? ? ? ? ? ? ? ? ? ?toolchain/patch-kernel.sh $(@D) $(DL_DIR) `basename $$p` ; \
> ? ? ? ? ? ? ? ?elif test -d $$p ; then \
> - ? ? ? ? ? ? ? ? ? ? ? toolchain/patch-kernel.sh $(@D) $$p linux-\*.patch ; \
> + ? ? ? ? ? ? ? ? ? ? ? toolchain/patch-kernel.sh $(@D) $$p \*.patch ; \
I have to disagree on this. There might be patches for other packages
in that same dir.
And by the way;
http://spheredev.org/wiki/Git_for_the_lazy#Writing_good_commit_messages
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
2011-06-27 7:10 ` Daniel Nyström
@ 2011-06-27 12:22 ` Thomas Petazzoni
2011-06-27 13:05 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2011-06-27 12:22 UTC (permalink / raw)
To: buildroot
Hello,
Le Mon, 27 Jun 2011 09:10:02 +0200,
Daniel Nystr?m <daniel.nystrom@timeterminal.se> a ?crit :
> I have to disagree on this. There might be patches for other packages
> in that same dir.
I was initially tempted to ACK Mike's patch, because I have the same
use case than Mike's (using git format-patch and then copying patches
to the Buildroot board specific directory), but as Daniel says, there
may be patches for other components in the same directory.
Maybe we should simply document this in the option help text?
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
2011-06-27 12:22 ` Thomas Petazzoni
@ 2011-06-27 13:05 ` Peter Korsgaard
2011-06-27 13:43 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2011-06-27 13:05 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
Thomas> I was initially tempted to ACK Mike's patch, because I have the same
Thomas> use case than Mike's (using git format-patch and then copying patches
Thomas> to the Buildroot board specific directory), but as Daniel says, there
Thomas> may be patches for other components in the same directory.
Thomas> Maybe we should simply document this in the option help text?
I think so. It's easy to put the linux patches in a seperate subdir.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
2011-06-27 13:05 ` Peter Korsgaard
@ 2011-06-27 13:43 ` Thomas Petazzoni
2011-06-27 14:31 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2011-06-27 13:43 UTC (permalink / raw)
To: buildroot
Le Mon, 27 Jun 2011 15:05:59 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :
> Thomas> Maybe we should simply document this in the option help text?
>
> I think so. It's easy to put the linux patches in a seperate subdir.
So your suggestion is to apply Mike's patch ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.
2011-06-27 13:43 ` Thomas Petazzoni
@ 2011-06-27 14:31 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2011-06-27 14:31 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
Thomas> Maybe we should simply document this in the option help text?
>>
>> I think so. It's easy to put the linux patches in a seperate subdir.
Thomas> So your suggestion is to apply Mike's patch ?
Yes.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-27 14:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-24 14:08 [Buildroot] [PATCH] linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch Mike Williams
2011-06-27 7:10 ` Daniel Nyström
2011-06-27 12:22 ` Thomas Petazzoni
2011-06-27 13:05 ` Peter Korsgaard
2011-06-27 13:43 ` Thomas Petazzoni
2011-06-27 14:31 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox