[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[Thomas Petazzoni]

External toolchain C++ cross-compiler fix

package/Makefile.in resets CXX to "" in TARGET_CONFIGURE_OPTS if
BR2_GCC_CROSS_CXX is not set to 'y'. However, when using an external
toolchain, BR2_GCC_CROSS_CXX is not set even if the toolchain has a
C++ cross-compiler.

This patch adds a new BR2_GCC_CROSS_CXX option in the external
toolchain configuration menu, so that just like BR2_INET_RPC,
BR2_INET_IPV6 and the others, it can be set according to the external
toolchain configuration.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/external-toolchain/Config.in |    6 ++++++
 1 file changed, 6 insertions(+)

Index: buildroot2/toolchain/external-toolchain/Config.in
===================================================================
--- buildroot2.orig/toolchain/external-toolchain/Config.in
+++ buildroot2/toolchain/external-toolchain/Config.in
@@ -93,6 +93,12 @@
 	help
 	  Set this option if the external toolchain supports soft float.
 
+config BR2_GCC_CROSS_CXX
+	bool "Toolchain has C++ cross-compiler ?"
+	help
+	  Set this option if the external toolchain has a C++
+	  cross-compiler.
+
 config BR2_TARGET_OPTIMIZATION
 	string "Target Optimizations"
 	default "-Os -pipe"


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[hartleys]

On Friday, October 31, 2008 7:13 AM, Thomas Petazzoni wrote:
> External toolchain C++ cross-compiler fix
>
> package/Makefile.in resets CXX to "" in TARGET_CONFIGURE_OPTS if
> BR2_GCC_CROSS_CXX is not set to 'y'. However, when using an
> external toolchain, BR2_GCC_CROSS_CXX is not set even if the
> toolchain has a C++ cross-compiler.
>
> This patch adds a new BR2_GCC_CROSS_CXX option in the external
> toolchain configuration menu, so that just like BR2_INET_RPC,
> BR2_INET_IPV6 and the others, it can be set according to the
> external toolchain configuration.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Yah! Someone else had the same problem.

I posted a message about this back on 8/13/2008 with a similar fix (but
not a patch) and never got a reply. I was starting to think it was just
me.

For what it's worth:

Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[Thomas Petazzoni]

Le Fri, 31 Oct 2008 14:32:08 -0400,
"hartleys" <hartleys@visionengravers.com> a ?crit :

> I posted a message about this back on 8/13/2008 with a similar fix
> (but not a patch) and never got a reply. I was starting to think it
> was just me.

No, that's not just you. Not everybody is using Buildroot with the
external toolchain set-up (considering the number of issues faced by
people using it in this setup), and many patches remained unanswered
unfortunately.

> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> External toolchain C++ cross-compiler fix

Thanks, committed as r23910.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] External toolchain C++ cross-compiler fix

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Le Fri, 31 Oct 2008 14:32:08 -0400,
 Thomas> "hartleys" <hartleys@visionengravers.com> a ?crit :

 >> I posted a message about this back on 8/13/2008 with a similar fix
 >> (but not a patch) and never got a reply. I was starting to think it
 >> was just me.

 Thomas> No, that's not just you. Not everybody is using Buildroot with the
 Thomas> external toolchain set-up (considering the number of issues faced by
 Thomas> people using it in this setup), and many patches remained unanswered
 Thomas> unfortunately.

Yeah - It's an issue of limited man power, nothing else.

-- 
Bye, Peter Korsgaard