Re: [Buildroot] [PATCH v4 4/6] package/vulkan-tools: suppress isystem being passed

["Alex Bennée" <alex.bennee@linaro.org>]

Julien Olivain <ju.o@free.fr> writes:

> Hi Alex,
>
> Thanks for the patch!
>
> If the vulkan-tools package is known to be broken from its bump to
> 1.4.307 from the previous patch, this patch should preferably be
> squashed with the bump. We are trying to keep each commit functional
> to make git bisect easier.
>
> Could you squash this patch with the previous one, please?

After bumping the versions the build seems to work without the patch so
I can drop it now.

>
> On 03/03/2025 17:15, Alex Bennée wrote:
>> This applies NO_SYSTEM_FROM_IMPORTED 1 to the vulkaninfo build to
>> prevent -isystem being passed, breaking the build with:
>>   ... aarch64-buildroot-linux-gnu/include/c++/14.2.0/cstdlib:79:15:
>> fatal error: stdlib.h: No such file or directory
>>      79 | #include_next <stdlib.h>
>>         |               ^~~~~~~~~~
>>   compilation terminated.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  ...aninfo-suppress-isystem-being-passed.patch | 57 +++++++++++++++++++
>>  1 file changed, 57 insertions(+)
>>  create mode 100644
>> package/vulkan-tools/0001-vulkaninfo-suppress-isystem-being-passed.patch
>> diff --git
>> a/package/vulkan-tools/0001-vulkaninfo-suppress-isystem-being-passed.patch
>> b/package/vulkan-tools/0001-vulkaninfo-suppress-isystem-being-passed.patch
>> new file mode 100644
>> index 0000000000..26f8c4a55f
>> --- /dev/null
>> +++
>> b/package/vulkan-tools/0001-vulkaninfo-suppress-isystem-being-passed.patch
>> @@ -0,0 +1,57 @@
>> +From 932a9902f923aa0b6423ceee8fb0289665a1d157 Mon Sep 17 00:00:00 2001
>> +From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
>> +Date: Fri, 14 Feb 2025 10:44:58 +0000
>> +Subject: [PATCH] vulkaninfo: suppress -isystem being passed
>> +MIME-Version: 1.0
>> +Content-Type: text/plain; charset=UTF-8
>> +Content-Transfer-Encoding: 8bit
>> +
>> +During the process of updating vulkan-tools in buildroot I ran into
>> +the following build failure:
>> +
>> +  [ 50%] Building CXX object
>> vulkaninfo/CMakeFiles/vulkaninfo.dir/vulkaninfo.cpp.o
>> +  In file included from
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/host/aarch64-buildroot-linux-gnu/include/c++/14.2.0/bits/stl_algo.h:71,
>> +                   from
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/host/aarch64-buildroot-linux-gnu/include/c++/14.2.0/algorithm:61,
>> +                   from
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/build/vulkan-tools-1.4.307/vulkaninfo/./vulkaninfo.h:31,
>> +                   from
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/build/vulkan-tools-1.4.307/vulkaninfo/generated/vulkaninfo.hpp:28,
>> +                   from
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/build/vulkan-tools-1.4.307/vulkaninfo/vulkaninfo.cpp:34:
>> +
>> /home/alex/lsrc/tests/buildroot.git/builds/arm64/host/aarch64-buildroot-linux-gnu/include/c++/14.2.0/cstdlib:79:15:
>> fatal error: stdlib.h: No such file or directory
>> +     79 | #include_next <stdlib.h>
>> +        |               ^~~~~~~~~~
>> +  compilation terminated.
>> +  make[2]: *** [vulkaninfo/CMakeFiles/vulkaninfo.dir/build.make:76:
>> vulkaninfo/CMakeFiles/vulkaninfo.dir/vulkaninfo.cpp.o] Error 1
>> +  make[1]: *** [CMakeFiles/Makefile2:116:
>> vulkaninfo/CMakeFiles/vulkaninfo.dir/all] Error 2
>> +  make: *** [Makefile:136: all] Error 2
>> +
>> +The underlying reason was -isystem being passed to the build which I
>> +think resets the include path for system includes. This might be a bug
>> +in cmake but from looking at the CMake source I found some examples
>> +that set: NO_SYSTEM_FROM_IMPORTED 1 as a target property which seems
>> +to do the job.
>> +
>> +This doesn't seem to affect the normal non-cross build although I
>> +wouldn't expect you need to pass -isystem anyway.
>> +
>> +Upstream: https://github.com/KhronosGroup/Vulkan-Tools/pull/1077
>> +Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> +---
>> + vulkaninfo/CMakeLists.txt | 3 ++-
>> + 1 file changed, 2 insertions(+), 1 deletion(-)
>> +
>> +diff --git a/vulkaninfo/CMakeLists.txt b/vulkaninfo/CMakeLists.txt
>> +index 7e51bb2d..d4f7e1fa 100644
>> +--- a/vulkaninfo/CMakeLists.txt
>> ++++ b/vulkaninfo/CMakeLists.txt
>> +@@ -22,7 +22,8 @@ set(VULKANINFO_NAME vulkaninfo)
>> + set(GENERATED generated)
>> +
>> + add_executable(vulkaninfo)
>> +-set_target_properties(vulkaninfo PROPERTIES OUTPUT_NAME
>> ${VULKANINFO_NAME})
>> ++set_target_properties(vulkaninfo PROPERTIES OUTPUT_NAME
>> ${VULKANINFO_NAME}
>> ++
>> NO_SYSTEM_FROM_IMPORTED 1)
>> +
>> + target_sources(vulkaninfo PRIVATE vulkaninfo.cpp)
>> +
>> +--
>> +2.39.5
>> +
>> --
>> 2.39.5
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Best regards,
>
> Julien.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot