Re: [Buildroot] [PATCH v4 5/6] package/vkmark: add vkmark benchmarking tool

["Alex Bennée" <alex.bennee@linaro.org>]

Julien Olivain <ju.o@free.fr> writes:

> Hi Alex,
>
> Thanks for the patch.
>
> On 03/03/2025 17:15, Alex Bennée wrote:
>> We build from the recent 2025.1 release although we need one commit
>> from master to better handle the missing KHR_display extension.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> v4
>>   - fix tab vs space damage
>>   - don't if BR2_PACKAGE_VKMARK_FLAVOR_ANY
>>   - make comments properly depend
>>   - use the new 2025.01 release
>>   - add sha256sum of COPYING-LGPL2.1
>>   - alphabetic sort of initial VKMARK_DEPENDENCIES
>>   - add vulkan error probing patch
<snip>
>> diff --git
>> a/package/vkmark/0001-display-Properly-handle-Vulkan-errors-during-probing.patch
>> b/package/vkmark/0001-display-Properly-handle-Vulkan-errors-during-probing.patch
>> new file mode 100644
>> index 0000000000..7e2e43a946
>> --- /dev/null
>> +++
>> b/package/vkmark/0001-display-Properly-handle-Vulkan-errors-during-probing.patch
>> @@ -0,0 +1,77 @@
>> +From adf1aa346d99d29ad2c5c945c3e4de5e0e3e12cb Mon Sep 17 00:00:00 2001
>> +From: Alexandros Frantzis <alexandros.frantzis@collabora.com>
>> +Date: Thu, 27 Feb 2025 14:33:49 +0200
>> +Subject: [PATCH] display: Properly handle Vulkan errors during probing
>> +
>> +The vk::createInstance() function throws an exception on error,
>> +so handle it instead of checking for a null return value.
>> +
>> +Signed-of-by: Alex Bennée <alex.bennee@linaro.org>
>
> There is a small typo here. It should be:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> This is reported by "utils/docker-run make check-package".
>
>     package/vkmark/0001-display-Properly-handle-Vulkan-errors-during-probing.patch:0:
>     missing Signed-off-by in the header
>     (https://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
>
> Could you send an updated version of this patch, please?

I think this is now handled upstream by:

  https://github.com/vkmark/vkmark/pull/72

So I can switch to building from current HEAD or ask the vkmark people
to cut a new release.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot