* [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target
@ 2024-04-04 15:34 Peter Korsgaard
2024-04-04 15:34 ` [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig " Peter Korsgaard
2024-04-06 7:43 ` [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc " Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2024-04-04 15:34 UTC (permalink / raw)
To: buildroot
We do not have liblerc in Buildroot and it may cause linking issues for
host-tiff on build hosts with liblerc:
libtool: link: /usr/bin/gcc -O2
-I/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/include
-Wall -W -Wl,-rpath
-Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
-o tiffcp tiffcp.o
-L/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
../libtiff/.libs/libtiff.so ../port/.libs/libport.a -lLerc -ljbig -lm
-Wl,-rpath
-Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/build/host-tiff-4.6.0/libtiff/.libs
-Wl,-rpath
-Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
/usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
`deflateInit_'
/usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `deflate'
/usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
`deflateEnd'
/usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `inflate'
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/tiff/tiff.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
index e384e8b814..8ec53d4fe1 100644
--- a/package/tiff/tiff.mk
+++ b/package/tiff/tiff.mk
@@ -16,6 +16,7 @@ TIFF_INSTALL_STAGING = YES
# support in tiff, or that would create a circular dependency.
TIFF_CONF_OPTS = \
--disable-contrib \
+ --disable-lerc \
--disable-tests \
--disable-webp
@@ -24,6 +25,7 @@ TIFF_DEPENDENCIES = host-pkgconf
HOST_TIFF_CONF_OPTS = \
--disable-cxx \
--disable-zlib \
+ --disable-lerc \
--disable-libdeflate \
--disable-lzma \
--disable-jpeg \
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig support for host and target
2024-04-04 15:34 [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target Peter Korsgaard
@ 2024-04-04 15:34 ` Peter Korsgaard
2024-04-06 7:43 ` Peter Korsgaard
2024-04-06 7:43 ` [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc " Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2024-04-04 15:34 UTC (permalink / raw)
To: buildroot
BR2_PACKAGE_TIFF_JBIG did actually not do anything, as no explicit
--enable-jbig was passed to configure and there is no libjbig in Buildroot,
so drop it and instead explicitly disable jbig support.
Also add --disable-jbig for the host build, which was missed when host
support was added in commit 91b16fbbf9db (tiff: add host variant).
As the TIFF_JBIG option was a noop, do not add legacy handling for it.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/tiff/Config.in | 4 ----
package/tiff/tiff.mk | 6 ++----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/package/tiff/Config.in b/package/tiff/Config.in
index d1004d6668..d357d08406 100644
--- a/package/tiff/Config.in
+++ b/package/tiff/Config.in
@@ -63,10 +63,6 @@ config BR2_PACKAGE_TIFF_OLD_JPEG
bool "Old JPEG decompression"
default y
-config BR2_PACKAGE_TIFF_JBIG
- bool "JBIG compression"
- default y
-
config BR2_PACKAGE_TIFF_UTILITIES
bool "tiff utilities"
help
diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
index 8ec53d4fe1..0e5e0dd48a 100644
--- a/package/tiff/tiff.mk
+++ b/package/tiff/tiff.mk
@@ -17,6 +17,7 @@ TIFF_INSTALL_STAGING = YES
TIFF_CONF_OPTS = \
--disable-contrib \
--disable-lerc \
+ --disable-jbig \
--disable-tests \
--disable-webp
@@ -28,6 +29,7 @@ HOST_TIFF_CONF_OPTS = \
--disable-lerc \
--disable-libdeflate \
--disable-lzma \
+ --disable-jbig \
--disable-jpeg \
--disable-tests \
--disable-webp \
@@ -101,10 +103,6 @@ ifneq ($(BR2_PACKAGE_TIFF_OLD_JPEG),y)
TIFF_CONF_OPTS += --disable-old-jpeg
endif
-ifneq ($(BR2_PACKAGE_TIFF_JBIG),y)
-TIFF_CONF_OPTS += --disable-jbig
-endif
-
ifeq ($(BR2_PACKAGE_TIFF_UTILITIES),y)
TIFF_CONF_OPTS += --enable-tools
else
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig support for host and target
2024-04-04 15:34 ` [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig " Peter Korsgaard
@ 2024-04-06 7:43 ` Peter Korsgaard
2024-05-02 8:30 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2024-04-06 7:43 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> BR2_PACKAGE_TIFF_JBIG did actually not do anything, as no explicit
> --enable-jbig was passed to configure and there is no libjbig in Buildroot,
> so drop it and instead explicitly disable jbig support.
> Also add --disable-jbig for the host build, which was missed when host
> support was added in commit 91b16fbbf9db (tiff: add host variant).
> As the TIFF_JBIG option was a noop, do not add legacy handling for it.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig support for host and target
2024-04-06 7:43 ` Peter Korsgaard
@ 2024-05-02 8:30 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2024-05-02 8:30 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>> BR2_PACKAGE_TIFF_JBIG did actually not do anything, as no explicit
>> --enable-jbig was passed to configure and there is no libjbig in Buildroot,
>> so drop it and instead explicitly disable jbig support.
>> Also add --disable-jbig for the host build, which was missed when host
>> support was added in commit 91b16fbbf9db (tiff: add host variant).
>> As the TIFF_JBIG option was a noop, do not add legacy handling for it.
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Committed, thanks.
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target
2024-04-04 15:34 [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target Peter Korsgaard
2024-04-04 15:34 ` [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig " Peter Korsgaard
@ 2024-04-06 7:43 ` Peter Korsgaard
2024-05-02 8:30 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2024-04-06 7:43 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> We do not have liblerc in Buildroot and it may cause linking issues for
> host-tiff on build hosts with liblerc:
> libtool: link: /usr/bin/gcc -O2
> -I/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/include
> -Wall -W -Wl,-rpath
> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
> -o tiffcp tiffcp.o
> -L/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
> ../libtiff/.libs/libtiff.so ../port/.libs/libport.a -lLerc -ljbig -lm
> -Wl,-rpath
> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/build/host-tiff-4.6.0/libtiff/.libs
> -Wl,-rpath
> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
> `deflateInit_'
> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `deflate'
> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
> `deflateEnd'
> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `inflate'
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target
2024-04-06 7:43 ` [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc " Peter Korsgaard
@ 2024-05-02 8:30 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2024-05-02 8:30 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>> We do not have liblerc in Buildroot and it may cause linking issues for
>> host-tiff on build hosts with liblerc:
>> libtool: link: /usr/bin/gcc -O2
>> -I/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/include
>> -Wall -W -Wl,-rpath
>> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
>> -o tiffcp tiffcp.o
>> -L/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
>> ../libtiff/.libs/libtiff.so ../port/.libs/libport.a -lLerc -ljbig -lm
>> -Wl,-rpath
>> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/build/host-tiff-4.6.0/libtiff/.libs
>> -Wl,-rpath
>> -Wl,/home/dragon/src/ft/ftcommunity-TXT/output/build/rootfs/per-package/host-tiff/host/lib
>> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
>> `deflateInit_'
>> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `deflate'
>> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to
>> `deflateEnd'
>> /usr/bin/ld: ../libtiff/.libs/libtiff.so: undefined reference to `inflate'
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Committed, thanks.
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-02 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04 15:34 [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc support for host and target Peter Korsgaard
2024-04-04 15:34 ` [Buildroot] [PATCH 2/2] package/tiff: explicitly disable jbig " Peter Korsgaard
2024-04-06 7:43 ` Peter Korsgaard
2024-05-02 8:30 ` Peter Korsgaard
2024-04-06 7:43 ` [Buildroot] [PATCH 1/2] package/tiff: explicitly disable lerc " Peter Korsgaard
2024-05-02 8:30 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox