[Buildroot] [PATCH 1/1] package/pango: fix build with gcc >= 13

[Buildroot] [PATCH 1/1] package/pango: fix build with gcc >= 13

[Fabrice Fontaine]

Fix the following build failure with gcc >= 13:

In function 'find_best_lang_match_cached',
    inlined from 'find_best_lang_match_cached' at ../pango/pango-language.c:501:1,
    inlined from 'pango_language_get_scripts' at ../pango/pango-language.c:661:21:
../pango/pango-language.c:518:12: error: array subscript 0 is outside array bounds of 'const void *[0]' {aka 'const void *[]'} [-Werror=array-bounds=]
  518 |     *cache = result;
      |     ~~~~~~~^~~~~~~~
In function 'pango_language_get_scripts':
cc1: note: source object is likely at address zero
cc1: some warnings being treated as errors

Fixes:
 - http://autobuild.buildroot.org/results/e8b5a752a62621099942b29c1642747eef2930cb

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../pango/0001-Drop-Werror-array-bounds.patch | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 package/pango/0001-Drop-Werror-array-bounds.patch

diff --git a/package/pango/0001-Drop-Werror-array-bounds.patch b/package/pango/0001-Drop-Werror-array-bounds.patch
new file mode 100644
index 0000000000..45821e8533
--- /dev/null
+++ b/package/pango/0001-Drop-Werror-array-bounds.patch
@@ -0,0 +1,40 @@
+From e93dbd66973040f1e0afcba0dc7c712c27d75d59 Mon Sep 17 00:00:00 2001
+From: Matthias Clasen <mclasen@redhat.com>
+Date: Mon, 1 May 2023 23:27:52 -0400
+Subject: [PATCH] Drop -Werror=array-bounds
+
+gcc has strange issues with this and produces false
+positives that recently started breaking the build of
+pango as a subproject in gtk.
+
+See e.g. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
+
+Upstream: https://gitlab.gnome.org/GNOME/pango/-/commit/e93dbd66973040f1e0afcba0dc7c712c27d75d59
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ meson.build | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 930f41082..2d30c0141 100644
+--- a/meson.build
++++ b/meson.build
+@@ -89,7 +89,6 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
+     '-Wuninitialized',
+     '-Wunused',
+     '-Werror=address',
+-    '-Werror=array-bounds',
+     '-Werror=empty-body',
+     '-Werror=implicit',
+     '-Werror=implicit-fallthrough',
+@@ -132,7 +131,6 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
+     '-Werror=sequence-point',
+     '-Werror=return-type',
+     '-Werror=trigraphs',
+-    '-Werror=array-bounds',
+     '-Werror=write-strings',
+     '-Werror=address',
+     '-Werror=int-to-pointer-cast',
+-- 
+GitLab
+
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pango: fix build with gcc >= 13

[Yann E. MORIN]

Fabrice, All,

On 2023-10-29 09:58 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure with gcc >= 13:
> 
> In function 'find_best_lang_match_cached',
>     inlined from 'find_best_lang_match_cached' at ../pango/pango-language.c:501:1,
>     inlined from 'pango_language_get_scripts' at ../pango/pango-language.c:661:21:
> ../pango/pango-language.c:518:12: error: array subscript 0 is outside array bounds of 'const void *[0]' {aka 'const void *[]'} [-Werror=array-bounds=]
>   518 |     *cache = result;
>       |     ~~~~~~~^~~~~~~~
> In function 'pango_language_get_scripts':
> cc1: note: source object is likely at address zero
> cc1: some warnings being treated as errors
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e8b5a752a62621099942b29c1642747eef2930cb
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  .../pango/0001-Drop-Werror-array-bounds.patch | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 package/pango/0001-Drop-Werror-array-bounds.patch
> 
> diff --git a/package/pango/0001-Drop-Werror-array-bounds.patch b/package/pango/0001-Drop-Werror-array-bounds.patch
> new file mode 100644
> index 0000000000..45821e8533
> --- /dev/null
> +++ b/package/pango/0001-Drop-Werror-array-bounds.patch
> @@ -0,0 +1,40 @@
> +From e93dbd66973040f1e0afcba0dc7c712c27d75d59 Mon Sep 17 00:00:00 2001
> +From: Matthias Clasen <mclasen@redhat.com>
> +Date: Mon, 1 May 2023 23:27:52 -0400
> +Subject: [PATCH] Drop -Werror=array-bounds
> +
> +gcc has strange issues with this and produces false
> +positives that recently started breaking the build of
> +pango as a subproject in gtk.
> +
> +See e.g. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
> +
> +Upstream: https://gitlab.gnome.org/GNOME/pango/-/commit/e93dbd66973040f1e0afcba0dc7c712c27d75d59
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + meson.build | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/meson.build b/meson.build
> +index 930f41082..2d30c0141 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -89,7 +89,6 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
> +     '-Wuninitialized',
> +     '-Wunused',
> +     '-Werror=address',
> +-    '-Werror=array-bounds',
> +     '-Werror=empty-body',
> +     '-Werror=implicit',
> +     '-Werror=implicit-fallthrough',
> +@@ -132,7 +131,6 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
> +     '-Werror=sequence-point',
> +     '-Werror=return-type',
> +     '-Werror=trigraphs',
> +-    '-Werror=array-bounds',
> +     '-Werror=write-strings',
> +     '-Werror=address',
> +     '-Werror=int-to-pointer-cast',
> +-- 
> +GitLab
> +
> -- 
> 2.42.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pango: fix build with gcc >= 13

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure with gcc >= 13:
 > In function 'find_best_lang_match_cached',
 >     inlined from 'find_best_lang_match_cached' at ../pango/pango-language.c:501:1,
 >     inlined from 'pango_language_get_scripts' at ../pango/pango-language.c:661:21:
 > ../pango/pango-language.c:518:12: error: array subscript 0 is outside array bounds of 'const void *[0]' {aka 'const void *[]'} [-Werror=array-bounds=]
 >   518 |     *cache = result;
 >       |     ~~~~~~~^~~~~~~~
 > In function 'pango_language_get_scripts':
 > cc1: note: source object is likely at address zero
 > cc1: some warnings being treated as errors

 > Fixes:
 >  - http://autobuild.buildroot.org/results/e8b5a752a62621099942b29c1642747eef2930cb

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot