* [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
@ 2011-10-06 15:00 Roeland Van Praet
2011-10-06 16:30 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Roeland Van Praet @ 2011-10-06 15:00 UTC (permalink / raw)
To: buildroot
diff -ruN a/package/Config.in b/package/Config.in
--- a/package/Config.in 2011-10-06 16:47:32.000000000 +0200
+++ b/package/Config.in 2011-10-06 16:47:47.000000000 +0200
@@ -31,6 +31,7 @@
source "package/strace/Config.in"
source "package/whetstone/Config.in"
source "package/valgrind/Config.in"
+source "package/pv/Config.in"
endmenu
menu "Development tools"
diff -ruN a/package/pv/Config.in b/package/pv/Config.in
--- a/package/pv/Config.in 1970-01-01 01:00:00.000000000 +0100
+++ b/package/pv/Config.in 2011-10-06 15:50:50.000000000 +0200
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PV
+ bool "pv"
+ help
+ Pipe Viewer - is a terminal-based tool for
+ monitoring the progress of data through a
+ pipeline.
+
+ http://www.ivarch.com/programs/pv.shtml
diff -ruN a/package/pv/pv-1.2.0-fixld.patch
b/package/pv/pv-1.2.0-fixld.patch
--- a/package/pv/pv-1.2.0-fixld.patch 1970-01-01 01:00:00.000000000
+0100
+++ b/package/pv/pv-1.2.0-fixld.patch 2011-10-06 16:36:28.000000000
+0200
@@ -0,0 +1,12 @@
+diff -ruN a/autoconf/make/vars.mk b/autoconf/make/vars.mk
+--- a/autoconf/make/vars.mk 2010-03-11 00:43:19.000000000 +0100
++++ b/autoconf/make/vars.mk 2011-10-06 15:47:18.000000000 +0200
+@@ -30,7 +30,7 @@
+ @SET_MAKE@
+ SHELL = /bin/sh
+ CC = @CC@
+-LD = ld
++LD = $(CC:gcc=ld)
+ DO_GZIP = @DO_GZIP@
+ INSTALL = @INSTALL@
+ INSTALL_DATA = @INSTALL_DATA@
diff -ruN a/package/pv/pv.mk b/package/pv/pv.mk
--- a/package/pv/pv.mk 1970-01-01 01:00:00.000000000 +0100
+++ b/package/pv/pv.mk 2011-10-06 15:50:50.000000000 +0200
@@ -0,0 +1,13 @@
+#######################
+#
+# pv - Pipe Viewer
+#
+#######################
+
+PV_VERSION = 1.2.0
+PV_SOURCE = pv-$(PV_VERSION).tar.bz2
+PV_SITE = http://pipeviewer.googlecode.com/files
+
+PV_INSTALL_TARGET = YES
+
+$(eval $(call AUTOTARGETS,package,pv))
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
2011-10-06 15:00 [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot Roeland Van Praet
@ 2011-10-06 16:30 ` Thomas Petazzoni
2011-10-06 16:55 ` Roeland Van Praet
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2011-10-06 16:30 UTC (permalink / raw)
To: buildroot
Le Thu, 06 Oct 2011 17:00:44 +0200,
Roeland Van Praet <roelvp@mind.be> a ?crit :
> diff -ruN a/package/Config.in b/package/Config.in
> --- a/package/Config.in 2011-10-06 16:47:32.000000000 +0200
> +++ b/package/Config.in 2011-10-06 16:47:47.000000000 +0200
> @@ -31,6 +31,7 @@
> source "package/strace/Config.in"
> source "package/whetstone/Config.in"
> source "package/valgrind/Config.in"
> +source "package/pv/Config.in"
> endmenu
>
> menu "Development tools"
> diff -ruN a/package/pv/Config.in b/package/pv/Config.in
> --- a/package/pv/Config.in 1970-01-01 01:00:00.000000000 +0100
> +++ b/package/pv/Config.in 2011-10-06 15:50:50.000000000 +0200
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PV
> + bool "pv"
> + help
> + Pipe Viewer - is a terminal-based tool for
> + monitoring the progress of data through a
> + pipeline.
Incorrect indentation for the help text. It should be one tab + two
spaces for each line.
> --- a/package/pv/pv-1.2.0-fixld.patch 1970-01-01 01:00:00.000000000
> +0100
> +++ b/package/pv/pv-1.2.0-fixld.patch 2011-10-06 16:36:28.000000000
> +0200
Each patch must contain a description + Signed-off-by line.
> --- a/package/pv/pv.mk 1970-01-01 01:00:00.000000000 +0100
> +++ b/package/pv/pv.mk 2011-10-06 15:50:50.000000000 +0200
> @@ -0,0 +1,13 @@
> +#######################
> +#
> +# pv - Pipe Viewer
> +#
> +#######################
> +
> +PV_VERSION = 1.2.0
> +PV_SOURCE = pv-$(PV_VERSION).tar.bz2
> +PV_SITE = http://pipeviewer.googlecode.com/files
> +
> +PV_INSTALL_TARGET = YES
Line not needed, this is the default.
> +$(eval $(call AUTOTARGETS,package,pv))
This should now be:
$(eval $(call AUTOTARGETS))
This is a very recent change in Buildroot Git, and the doc has not been
updated yet.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
2011-10-06 16:30 ` Thomas Petazzoni
@ 2011-10-06 16:55 ` Roeland Van Praet
2011-10-07 7:04 ` Roeland Van Praet
0 siblings, 1 reply; 5+ messages in thread
From: Roeland Van Praet @ 2011-10-06 16:55 UTC (permalink / raw)
To: buildroot
On Thu, 2011-10-06 at 18:30 +0200, Thomas Petazzoni wrote:
> Le Thu, 06 Oct 2011 17:00:44 +0200,
> Roeland Van Praet <roelvp@mind.be> a ?crit :
>
> > diff -ruN a/package/Config.in b/package/Config.in
> > --- a/package/Config.in 2011-10-06 16:47:32.000000000 +0200
> > +++ b/package/Config.in 2011-10-06 16:47:47.000000000 +0200
> > @@ -31,6 +31,7 @@
> > source "package/strace/Config.in"
> > source "package/whetstone/Config.in"
> > source "package/valgrind/Config.in"
> > +source "package/pv/Config.in"
> > endmenu
> >
> > menu "Development tools"
> > diff -ruN a/package/pv/Config.in b/package/pv/Config.in
> > --- a/package/pv/Config.in 1970-01-01 01:00:00.000000000 +0100
> > +++ b/package/pv/Config.in 2011-10-06 15:50:50.000000000 +0200
> > @@ -0,0 +1,8 @@
> > +config BR2_PACKAGE_PV
> > + bool "pv"
> > + help
> > + Pipe Viewer - is a terminal-based tool for
> > + monitoring the progress of data through a
> > + pipeline.
>
> Incorrect indentation for the help text. It should be one tab + two
> spaces for each line.
>
> > --- a/package/pv/pv-1.2.0-fixld.patch 1970-01-01 01:00:00.000000000
> > +0100
> > +++ b/package/pv/pv-1.2.0-fixld.patch 2011-10-06 16:36:28.000000000
> > +0200
>
> Each patch must contain a description + Signed-off-by line.
>
> > --- a/package/pv/pv.mk 1970-01-01 01:00:00.000000000 +0100
> > +++ b/package/pv/pv.mk 2011-10-06 15:50:50.000000000 +0200
> > @@ -0,0 +1,13 @@
> > +#######################
> > +#
> > +# pv - Pipe Viewer
> > +#
> > +#######################
> > +
> > +PV_VERSION = 1.2.0
> > +PV_SOURCE = pv-$(PV_VERSION).tar.bz2
> > +PV_SITE = http://pipeviewer.googlecode.com/files
> > +
> > +PV_INSTALL_TARGET = YES
>
> Line not needed, this is the default.
>
> > +$(eval $(call AUTOTARGETS,package,pv))
>
> This should now be:
>
> $(eval $(call AUTOTARGETS))
>
> This is a very recent change in Buildroot Git, and the doc has not been
> updated yet.
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Ok, I'll submit a new patch tomorrow.
Roeland
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
2011-10-06 16:55 ` Roeland Van Praet
@ 2011-10-07 7:04 ` Roeland Van Praet
2011-10-07 8:21 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Roeland Van Praet @ 2011-10-07 7:04 UTC (permalink / raw)
To: buildroot
diff -ruN a/package/Config.in b/package/Config.in
--- a/package/Config.in 2011-10-06 16:47:32.000000000 +0200
+++ b/package/Config.in 2011-10-06 16:47:47.000000000 +0200
@@ -31,6 +31,7 @@
source "package/strace/Config.in"
source "package/whetstone/Config.in"
source "package/valgrind/Config.in"
+source "package/pv/Config.in"
endmenu
menu "Development tools"
diff -ruN a/package/pv/Config.in b/package/pv/Config.in
--- a/package/pv/Config.in 1970-01-01 01:00:00.000000000 +0100
+++ b/package/pv/Config.in 2011-10-07 08:36:52.000000000 +0200
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PV
+ bool "pv"
+ help
+ Pipe Viewer - is a terminal-based tool for
+ monitoring the progress of data through a
+ pipeline.
+
+ http://www.ivarch.com/programs/pv.shtml
diff -ruN a/package/pv/pv-1.2.0-fixld.patch b/package/pv/pv-1.2.0-fixld.patch
--- a/package/pv/pv-1.2.0-fixld.patch 1970-01-01 01:00:00.000000000 +0100
+++ b/package/pv/pv-1.2.0-fixld.patch 2011-10-07 08:39:12.000000000 +0200
@@ -0,0 +1,21 @@
+[PATCH] fix linker variable
+
+The linker variable LD was always set to 'ld' instead of the value from
+the environment. This breaks any linking, especially when dealing with
+a cross-compiler toolchain.
+The fix takes the CC variable and changes the 'gcc' extension to 'ld'.
+
+Signed-off-by: Roeland Van Praet <roelvp@mind.be>
+---
+diff -ruN a/autoconf/make/vars.mk b/autoconf/make/vars.mk
+--- a/autoconf/make/vars.mk 2010-03-11 00:43:19.000000000 +0100
++++ b/autoconf/make/vars.mk 2011-10-06 15:47:18.000000000 +0200
+@@ -30,7 +30,7 @@
+ @SET_MAKE@
+ SHELL = /bin/sh
+ CC = @CC@
+-LD = ld
++LD = $(CC:gcc=ld)
+ DO_GZIP = @DO_GZIP@
+ INSTALL = @INSTALL@
+ INSTALL_DATA = @INSTALL_DATA@
diff -ruN a/package/pv/pv.mk b/package/pv/pv.mk
--- a/package/pv/pv.mk 1970-01-01 01:00:00.000000000 +0100
+++ b/package/pv/pv.mk 2011-10-07 08:45:45.000000000 +0200
@@ -0,0 +1,11 @@
+#######################
+#
+# pv - Pipe Viewer
+#
+#######################
+
+PV_VERSION = 1.2.0
+PV_SOURCE = pv-$(PV_VERSION).tar.bz2
+PV_SITE = http://pipeviewer.googlecode.com/files
+
+$(eval $(call AUTOTARGETS))
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
2011-10-07 7:04 ` Roeland Van Praet
@ 2011-10-07 8:21 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2011-10-07 8:21 UTC (permalink / raw)
To: buildroot
>>>>> "Roeland" == Roeland Van Praet <roelvp@mind.be> writes:
Roeland> diff -ruN a/package/Config.in b/package/Config.in
Committed, thanks. In the future, don't forget to sign off on your
patches (git commit -s / format-patch -s)
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-07 8:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 15:00 [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot Roeland Van Praet
2011-10-06 16:30 ` Thomas Petazzoni
2011-10-06 16:55 ` Roeland Van Praet
2011-10-07 7:04 ` Roeland Van Praet
2011-10-07 8:21 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox