Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV
@ 2024-02-11 16:05 Fabrice Fontaine
  2024-02-11 17:04 ` Yann E. MORIN
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2024-02-11 16:05 UTC (permalink / raw)
  To: buildroot; +Cc: Antoine Tenart, Marcus Folkesson, Fabrice Fontaine

Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as
libselinux uses setuptools instead of distutils since version 3.5 and
https://github.com/SELinuxProject/selinux/commit/2b5d5585754eb731a68158b613c7676fc3195ed9

This will avoid the following build failure raised since commit
09de823cbc7bd50a40e25f4166b4e42be94b0c7b:

In file included from /home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/Python.h:38,
                 from selinuxswig_python_wrap.c:168:
/home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
  586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
      |  ^~~~~

Fixes:
 - http://autobuild.buildroot.org/results/3fbbb741de33310c8cacab753a32e79c5e531036

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libselinux/libselinux.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
index 529745f82e..734084ba50 100644
--- a/package/libselinux/libselinux.mk
+++ b/package/libselinux/libselinux.mk
@@ -38,7 +38,7 @@ LIBSELINUX_DEPENDENCIES += \
 	host-swig
 
 LIBSELINUX_MAKE_OPTS += \
-	$(PKG_PYTHON_DISTUTILS_ENV) \
+	$(PKG_PYTHON_SETUPTOOLS_ENV) \
 	PYTHON=python$(PYTHON3_VERSION_MAJOR)
 
 LIBSELINUX_MAKE_INSTALL_TARGETS += install-pywrap
@@ -85,7 +85,7 @@ HOST_LIBSELINUX_MAKE_OPTS = \
 	$(HOST_CONFIGURE_OPTS) \
 	PREFIX=$(HOST_DIR) \
 	SHLIBDIR=$(HOST_DIR)/lib \
-	$(HOST_PKG_PYTHON_DISTUTILS_ENV) \
+	$(HOST_PKG_PYTHON_SETUPTOOLS_ENV) \
 	PYTHON=python$(PYTHON3_VERSION_MAJOR) \
 	USE_PCRE2=y
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV
  2024-02-11 16:05 [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
@ 2024-02-11 17:04 ` Yann E. MORIN
  2024-02-11 19:36 ` Yann E. MORIN
  2024-03-10 21:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2024-02-11 17:04 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Antoine Tenart, Marcus Folkesson, buildroot

Fabrice, All,

On 2024-02-11 17:05 +0100, Fabrice Fontaine spake thusly:
> Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as
> libselinux uses setuptools instead of distutils since version 3.5 and
> https://github.com/SELinuxProject/selinux/commit/2b5d5585754eb731a68158b613c7676fc3195ed9
> 
> This will avoid the following build failure raised since commit
> 09de823cbc7bd50a40e25f4166b4e42be94b0c7b:
> 
> In file included from /home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/Python.h:38,
>                  from selinuxswig_python_wrap.c:168:
> /home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
>   586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
>       |  ^~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/3fbbb741de33310c8cacab753a32e79c5e531036

I've slightly changes the formatting of the "fixes" tag, to also point
to the commit introducing the issue.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libselinux/libselinux.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index 529745f82e..734084ba50 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -38,7 +38,7 @@ LIBSELINUX_DEPENDENCIES += \
>  	host-swig
>  
>  LIBSELINUX_MAKE_OPTS += \
> -	$(PKG_PYTHON_DISTUTILS_ENV) \
> +	$(PKG_PYTHON_SETUPTOOLS_ENV) \
>  	PYTHON=python$(PYTHON3_VERSION_MAJOR)
>  
>  LIBSELINUX_MAKE_INSTALL_TARGETS += install-pywrap
> @@ -85,7 +85,7 @@ HOST_LIBSELINUX_MAKE_OPTS = \
>  	$(HOST_CONFIGURE_OPTS) \
>  	PREFIX=$(HOST_DIR) \
>  	SHLIBDIR=$(HOST_DIR)/lib \
> -	$(HOST_PKG_PYTHON_DISTUTILS_ENV) \
> +	$(HOST_PKG_PYTHON_SETUPTOOLS_ENV) \
>  	PYTHON=python$(PYTHON3_VERSION_MAJOR) \
>  	USE_PCRE2=y
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV
  2024-02-11 16:05 [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
  2024-02-11 17:04 ` Yann E. MORIN
@ 2024-02-11 19:36 ` Yann E. MORIN
  2024-03-10 21:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2024-02-11 19:36 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Antoine Tenart, Marcus Folkesson, buildroot

Fabrice, All,

On 2024-02-11 17:05 +0100, Fabrice Fontaine spake thusly:
> Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as
> libselinux uses setuptools instead of distutils since version 3.5 and
> https://github.com/SELinuxProject/selinux/commit/2b5d5585754eb731a68158b613c7676fc3195ed9
[--SNIP--]
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index 529745f82e..734084ba50 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -38,7 +38,7 @@ LIBSELINUX_DEPENDENCIES += \
>  	host-swig
>  
>  LIBSELINUX_MAKE_OPTS += \
> -	$(PKG_PYTHON_DISTUTILS_ENV) \
> +	$(PKG_PYTHON_SETUPTOOLS_ENV) \
>  	PYTHON=python$(PYTHON3_VERSION_MAJOR)

You had forgotten to update the comment a few lines below, and I just
noticed, so I pushed a follow-up commit.

Regards,
Yann E. MORIN.

>  LIBSELINUX_MAKE_INSTALL_TARGETS += install-pywrap
> @@ -85,7 +85,7 @@ HOST_LIBSELINUX_MAKE_OPTS = \
>  	$(HOST_CONFIGURE_OPTS) \
>  	PREFIX=$(HOST_DIR) \
>  	SHLIBDIR=$(HOST_DIR)/lib \
> -	$(HOST_PKG_PYTHON_DISTUTILS_ENV) \
> +	$(HOST_PKG_PYTHON_SETUPTOOLS_ENV) \
>  	PYTHON=python$(PYTHON3_VERSION_MAJOR) \
>  	USE_PCRE2=y
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV
  2024-02-11 16:05 [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
  2024-02-11 17:04 ` Yann E. MORIN
  2024-02-11 19:36 ` Yann E. MORIN
@ 2024-03-10 21:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2024-03-10 21:42 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Antoine Tenart, Marcus Folkesson, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Replace PKG_PYTHON_DISTUTILS_ENV by PKG_PYTHON_SETUPTOOLS_ENV as
 > libselinux uses setuptools instead of distutils since version 3.5 and
 > https://github.com/SELinuxProject/selinux/commit/2b5d5585754eb731a68158b613c7676fc3195ed9

 > This will avoid the following build failure raised since commit
 > 09de823cbc7bd50a40e25f4166b4e42be94b0c7b:

 > In file included from /home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/Python.h:38,
 >                  from selinuxswig_python_wrap.c:168:
 > /home/buildroot/autobuild/instance-0/output-1/per-package/libselinux/host/include/python3.12/pyport.h:586:2: error: #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
 >   586 | #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
 >       |  ^~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/3fbbb741de33310c8cacab753a32e79c5e531036

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-10 21:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-11 16:05 [Buildroot] [PATCH 1/1] package:libselinux: replace PKG_PYTHON_DISTUTILS_ENV Fabrice Fontaine
2024-02-11 17:04 ` Yann E. MORIN
2024-02-11 19:36 ` Yann E. MORIN
2024-03-10 21:42 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox