* [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize
@ 2018-05-28 8:31 Vincent Prince
2018-05-28 8:31 ` [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package Vincent Prince
2018-05-28 12:41 ` [Buildroot] [PATCH v2 " Peter Korsgaard
0 siblings, 2 replies; 12+ messages in thread
From: Vincent Prince @ 2018-05-28 8:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
package/nss-mdns/nss-mdns.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
index 407b942..ee666c7 100644
--- a/package/nss-mdns/nss-mdns.mk
+++ b/package/nss-mdns/nss-mdns.mk
@@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
$(TARGET_DIR)/etc/nsswitch.conf
endef
-NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
+NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package
2018-05-28 8:31 [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
@ 2018-05-28 8:31 ` Vincent Prince
2018-05-28 12:47 ` Peter Korsgaard
2018-05-28 12:41 ` [Buildroot] [PATCH v2 " Peter Korsgaard
1 sibling, 1 reply; 12+ messages in thread
From: Vincent Prince @ 2018-05-28 8:31 UTC (permalink / raw)
To: buildroot
Note sed command comes from Yocto recipe here:
https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-support/nss-myhostname/nss-myhostname_0.3.bb
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
DEVELOPERS | 3 +++
package/Config.in | 1 +
package/nss-myhostname/Config.in | 11 +++++++++++
package/nss-myhostname/nss-myhostname.hash | 3 +++
package/nss-myhostname/nss-myhostname.mk | 20 ++++++++++++++++++++
5 files changed, 38 insertions(+)
create mode 100644 package/nss-myhostname/Config.in
create mode 100644 package/nss-myhostname/nss-myhostname.hash
create mode 100644 package/nss-myhostname/nss-myhostname.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 41e1b54..88c9a71 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1813,6 +1813,9 @@ F: package/openmpi/
F: package/pinentry/
F: package/trinity/
+N: Vincent Prince <vincent.prince.fr@gmail.com>
+F: package/nss-myhostname/
+
N: Vincent Stehl?? <vincent.stehle@laposte.net>
F: package/i7z/
F: package/msr-tools/
diff --git a/package/Config.in b/package/Config.in
index 3cf53ed..3ac0d63 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1426,6 +1426,7 @@ menu "Networking"
source "package/neon/Config.in"
source "package/norm/Config.in"
source "package/nss-mdns/Config.in"
+ source "package/nss-myhostname/Config.in"
source "package/nss-pam-ldapd/Config.in"
source "package/omniorb/Config.in"
source "package/openldap/Config.in"
diff --git a/package/nss-myhostname/Config.in b/package/nss-myhostname/Config.in
new file mode 100644
index 0000000..549e167
--- /dev/null
+++ b/package/nss-myhostname/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_NSS_MYHOSTNAME
+ bool "nss-myhostname"
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on !BR2_PACKAGE_SYSTEMD_MYHOSTNAME
+ help
+ Name Service Switch module for resolving the local hostname
+
+ http://0pointer.de/lennart/projects/nss-myhostname
+
+comment "nss-myhostname needs a glibc toolchain"
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/nss-myhostname/nss-myhostname.hash b/package/nss-myhostname/nss-myhostname.hash
new file mode 100644
index 0000000..dfa531c
--- /dev/null
+++ b/package/nss-myhostname/nss-myhostname.hash
@@ -0,0 +1,3 @@
+# locally computed
+sha256 2ba744ea8d578d1c57c85884e94a3042ee17843a5294434d3a7f6c4d67e7caf2 nss-myhostname-0.3.tar.gz
+sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861 LICENSE
diff --git a/package/nss-myhostname/nss-myhostname.mk b/package/nss-myhostname/nss-myhostname.mk
new file mode 100644
index 0000000..435c380
--- /dev/null
+++ b/package/nss-myhostname/nss-myhostname.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+## nss-myhostname
+#
+################################################################################
+
+NSS_MYHOSTNAME_VERSION = 0.3
+NSS_MYHOSTNAME_SITE = http://0pointer.de/lennart/projects/nss-myhostname
+NSS_MYHOSTNAME_LICENSE = LGPL-2.1+
+NSS_MYHOSTNAME_LICENSE_FILES = LICENSE
+
+define MYHOSTNAME_SET_NSSWITCH
+ $(SED) '/^hosts:/s/\s*\<myhostname\>//' \
+ -E -e 's,(^hosts:.*)(\<files\>)(.*)(\<dns\>)(.*),\1\2 myhostname \3\4\5,' \
+ $(TARGET_DIR)/etc/nsswitch.conf
+endef
+
+NSS_MYHOSTNAME_TARGET_FINALIZE_HOOKS += MYHOSTNAME_SET_NSSWITCH
+
+$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize
2018-05-28 8:31 [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
2018-05-28 8:31 ` [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package Vincent Prince
@ 2018-05-28 12:41 ` Peter Korsgaard
2018-05-28 19:08 ` Vincent Prince
1 sibling, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2018-05-28 12:41 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
Please describe _WHY_ this is done and not just state what the change is
you are making - Thanks.
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> ---
> package/nss-mdns/nss-mdns.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
> index 407b942..ee666c7 100644
> --- a/package/nss-mdns/nss-mdns.mk
> +++ b/package/nss-mdns/nss-mdns.mk
> @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
> $(TARGET_DIR)/etc/nsswitch.conf
> endef
> -NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
> +NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
> $(eval $(autotools-package))
> --
> 2.7.4
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package
2018-05-28 8:31 ` [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package Vincent Prince
@ 2018-05-28 12:47 ` Peter Korsgaard
2018-05-28 19:06 ` Vincent Prince
0 siblings, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2018-05-28 12:47 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
> Note sed command comes from Yocto recipe here:
> https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-support/nss-myhostname/nss-myhostname_0.3.bb
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> ---
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> package/nss-myhostname/Config.in | 11 +++++++++++
> package/nss-myhostname/nss-myhostname.hash | 3 +++
> package/nss-myhostname/nss-myhostname.mk | 20 ++++++++++++++++++++
> 5 files changed, 38 insertions(+)
> create mode 100644 package/nss-myhostname/Config.in
> create mode 100644 package/nss-myhostname/nss-myhostname.hash
> create mode 100644 package/nss-myhostname/nss-myhostname.mk
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 41e1b54..88c9a71 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1813,6 +1813,9 @@ F: package/openmpi/
> F: package/pinentry/
> F: package/trinity/
> +N: Vincent Prince <vincent.prince.fr@gmail.com>
> +F: package/nss-myhostname/
> +
> N: Vincent Stehl? <vincent.stehle@laposte.net>
> F: package/i7z/
> F: package/msr-tools/
> diff --git a/package/Config.in b/package/Config.in
> index 3cf53ed..3ac0d63 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1426,6 +1426,7 @@ menu "Networking"
> source "package/neon/Config.in"
> source "package/norm/Config.in"
> source "package/nss-mdns/Config.in"
> + source "package/nss-myhostname/Config.in"
> source "package/nss-pam-ldapd/Config.in"
> source "package/omniorb/Config.in"
> source "package/openldap/Config.in"
> diff --git a/package/nss-myhostname/Config.in b/package/nss-myhostname/Config.in
> new file mode 100644
> index 0000000..549e167
> --- /dev/null
> +++ b/package/nss-myhostname/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_NSS_MYHOSTNAME
> + bool "nss-myhostname"
> + depends on BR2_TOOLCHAIN_USES_GLIBC
> + depends on !BR2_PACKAGE_SYSTEMD_MYHOSTNAME
> + help
> + Name Service Switch module for resolving the local hostname
> +
> + http://0pointer.de/lennart/projects/nss-myhostname
> +
> +comment "nss-myhostname needs a glibc toolchain"
> + depends on !BR2_TOOLCHAIN_USES_GLIBC
> diff --git a/package/nss-myhostname/nss-myhostname.hash b/package/nss-myhostname/nss-myhostname.hash
> new file mode 100644
> index 0000000..dfa531c
> --- /dev/null
> +++ b/package/nss-myhostname/nss-myhostname.hash
> @@ -0,0 +1,3 @@
> +# locally computed
> +sha256 2ba744ea8d578d1c57c85884e94a3042ee17843a5294434d3a7f6c4d67e7caf2 nss-myhostname-0.3.tar.gz
> +sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861 LICENSE
> diff --git a/package/nss-myhostname/nss-myhostname.mk b/package/nss-myhostname/nss-myhostname.mk
> new file mode 100644
> index 0000000..435c380
> --- /dev/null
> +++ b/package/nss-myhostname/nss-myhostname.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +## nss-myhostname
> +#
> +################################################################################
> +
> +NSS_MYHOSTNAME_VERSION = 0.3
> +NSS_MYHOSTNAME_SITE = http://0pointer.de/lennart/projects/nss-myhostname
> +NSS_MYHOSTNAME_LICENSE = LGPL-2.1+
> +NSS_MYHOSTNAME_LICENSE_FILES = LICENSE
> +
> +define MYHOSTNAME_SET_NSSWITCH
> + $(SED) '/^hosts:/s/\s*\<myhostname\>//' \
> + -E -e 's,(^hosts:.*)(\<files\>)(.*)(\<dns\>)(.*),\1\2 myhostname \3\4\5,' \
> + $(TARGET_DIR)/etc/nsswitch.conf
I would still like to understand why this order is needed. The website
example and documentation says to add it as a fallback at the very end
of the hosts: line:
http://0pointer.de/lennart/projects/nss-myhostname/
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package
2018-05-28 12:47 ` Peter Korsgaard
@ 2018-05-28 19:06 ` Vincent Prince
2018-05-28 20:28 ` Peter Korsgaard
0 siblings, 1 reply; 12+ messages in thread
From: Vincent Prince @ 2018-05-28 19:06 UTC (permalink / raw)
To: buildroot
Things are not clear on nss-myhostname usage, you can check at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756224 discussion
and also this commit
http://git.nomeata.de/?p=libnss-myhostname.git;a=commit;h=5104d7f0045df55ee8be526e8c84078750e1e0ed
It seems to work great for me and everyone using it in Yocto & Debian with
this setting, it means not so many people as it is now integrated in
systemd.
2018-05-28 14:47 GMT+02:00 Peter Korsgaard <peter@korsgaard.com>:
> >>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
>
> > Note sed command comes from Yocto recipe here:
> > https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/
> recipes-support/nss-myhostname/nss-myhostname_0.3.bb
>
> > Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> > ---
> > DEVELOPERS | 3 +++
> > package/Config.in | 1 +
> > package/nss-myhostname/Config.in | 11 +++++++++++
> > package/nss-myhostname/nss-myhostname.hash | 3 +++
> > package/nss-myhostname/nss-myhostname.mk | 20 ++++++++++++++++++++
> > 5 files changed, 38 insertions(+)
> > create mode 100644 package/nss-myhostname/Config.in
> > create mode 100644 package/nss-myhostname/nss-myhostname.hash
> > create mode 100644 package/nss-myhostname/nss-myhostname.mk
>
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 41e1b54..88c9a71 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -1813,6 +1813,9 @@ F: package/openmpi/
> > F: package/pinentry/
> > F: package/trinity/
>
> > +N: Vincent Prince <vincent.prince.fr@gmail.com>
> > +F: package/nss-myhostname/
> > +
> > N: Vincent Stehl? <vincent.stehle@laposte.net>
> > F: package/i7z/
> > F: package/msr-tools/
> > diff --git a/package/Config.in b/package/Config.in
> > index 3cf53ed..3ac0d63 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1426,6 +1426,7 @@ menu "Networking"
> > source "package/neon/Config.in"
> > source "package/norm/Config.in"
> > source "package/nss-mdns/Config.in"
> > + source "package/nss-myhostname/Config.in"
> > source "package/nss-pam-ldapd/Config.in"
> > source "package/omniorb/Config.in"
> > source "package/openldap/Config.in"
> > diff --git a/package/nss-myhostname/Config.in b/package/nss-myhostname/
> Config.in
> > new file mode 100644
> > index 0000000..549e167
> > --- /dev/null
> > +++ b/package/nss-myhostname/Config.in
> > @@ -0,0 +1,11 @@
> > +config BR2_PACKAGE_NSS_MYHOSTNAME
> > + bool "nss-myhostname"
> > + depends on BR2_TOOLCHAIN_USES_GLIBC
> > + depends on !BR2_PACKAGE_SYSTEMD_MYHOSTNAME
> > + help
> > + Name Service Switch module for resolving the local hostname
> > +
> > + http://0pointer.de/lennart/projects/nss-myhostname
> > +
> > +comment "nss-myhostname needs a glibc toolchain"
> > + depends on !BR2_TOOLCHAIN_USES_GLIBC
> > diff --git a/package/nss-myhostname/nss-myhostname.hash
> b/package/nss-myhostname/nss-myhostname.hash
> > new file mode 100644
> > index 0000000..dfa531c
> > --- /dev/null
> > +++ b/package/nss-myhostname/nss-myhostname.hash
> > @@ -0,0 +1,3 @@
> > +# locally computed
> > +sha256 2ba744ea8d578d1c57c85884e94a3042ee17843a5294434d3a7f6c4d67e7caf2
> nss-myhostname-0.3.tar.gz
> > +sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861
> LICENSE
> > diff --git a/package/nss-myhostname/nss-myhostname.mk
> b/package/nss-myhostname/nss-myhostname.mk
> > new file mode 100644
> > index 0000000..435c380
> > --- /dev/null
> > +++ b/package/nss-myhostname/nss-myhostname.mk
> > @@ -0,0 +1,20 @@
> > +###########################################################
> #####################
> > +#
> > +## nss-myhostname
> > +#
> > +###########################################################
> #####################
> > +
> > +NSS_MYHOSTNAME_VERSION = 0.3
> > +NSS_MYHOSTNAME_SITE = http://0pointer.de/lennart/
> projects/nss-myhostname
> > +NSS_MYHOSTNAME_LICENSE = LGPL-2.1+
> > +NSS_MYHOSTNAME_LICENSE_FILES = LICENSE
> > +
> > +define MYHOSTNAME_SET_NSSWITCH
> > + $(SED) '/^hosts:/s/\s*\<myhostname\>//' \
> > + -E -e 's,(^hosts:.*)(\<files\>)(.*)(\<dns\>)(.*),\1\2
> myhostname \3\4\5,' \
> > + $(TARGET_DIR)/etc/nsswitch.conf
>
> I would still like to understand why this order is needed. The website
> example and documentation says to add it as a fallback at the very end
> of the hosts: line:
>
> http://0pointer.de/lennart/projects/nss-myhostname/
>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180528/d3edcceb/attachment.html>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize
2018-05-28 12:41 ` [Buildroot] [PATCH v2 " Peter Korsgaard
@ 2018-05-28 19:08 ` Vincent Prince
0 siblings, 0 replies; 12+ messages in thread
From: Vincent Prince @ 2018-05-28 19:08 UTC (permalink / raw)
To: buildroot
I though it was obvious without explication :)
I'll send a V3 to explain the _why_.
2018-05-28 14:41 GMT+02:00 Peter Korsgaard <peter@korsgaard.com>:
> >>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
>
>
> Please describe _WHY_ this is done and not just state what the change is
> you are making - Thanks.
>
> > Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> > ---
> > package/nss-mdns/nss-mdns.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/
> nss-mdns.mk
> > index 407b942..ee666c7 100644
> > --- a/package/nss-mdns/nss-mdns.mk
> > +++ b/package/nss-mdns/nss-mdns.mk
> > @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
> > $(TARGET_DIR)/etc/nsswitch.conf
> > endef
>
> > -NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
> > +NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
>
> > $(eval $(autotools-package))
> > --
> > 2.7.4
>
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180528/3ba3d30f/attachment.html>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package
2018-05-28 19:06 ` Vincent Prince
@ 2018-05-28 20:28 ` Peter Korsgaard
2018-05-29 8:00 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
0 siblings, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2018-05-28 20:28 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
> Things are not clear on nss-myhostname usage, you can check at
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756224 discussion
> and also this commit
> http://git.nomeata.de/?p=libnss-myhostname.git;a=commit;h=5104d7f0045df55ee8be526e8c84078750e1e0ed
Ok. I guess it depends on what you want. The original intention seems to
be purely as a fallback (so at the very end), but "files"
(E.G. /etc/hosts) normally has preference over DNS, and this is
basically an alternative to /etc/hosts so I can see the reasoning for
having it right after files.
In other words, both options are OK by me, but PLEASE document the
reasoning (and those URLs above) in the commit message, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize
2018-05-28 20:28 ` Peter Korsgaard
@ 2018-05-29 8:00 ` Vincent Prince
2018-05-29 8:00 ` [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package Vincent Prince
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Vincent Prince @ 2018-05-29 8:00 UTC (permalink / raw)
To: buildroot
Both nss-mdns and nss-myhostname patch nsswitch.conf file
so it needs to be done at the final stage otherwise changes are not applied
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
package/nss-mdns/nss-mdns.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
index 407b942..ee666c7 100644
--- a/package/nss-mdns/nss-mdns.mk
+++ b/package/nss-mdns/nss-mdns.mk
@@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
$(TARGET_DIR)/etc/nsswitch.conf
endef
-NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
+NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package
2018-05-29 8:00 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
@ 2018-05-29 8:00 ` Vincent Prince
2018-10-20 23:50 ` Peter Korsgaard
2018-05-29 8:50 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Peter Korsgaard
2018-10-20 23:48 ` Peter Korsgaard
2 siblings, 1 reply; 12+ messages in thread
From: Vincent Prince @ 2018-05-29 8:00 UTC (permalink / raw)
To: buildroot
nss-myhostname is helpful to resolve local hostname without domain.
For instance, if we set hostname to myboard and ping myboard
without .local suffix, it fails if /etc/hosts stays unchanged.
nss-myhostname modifies /etc/nsswitch.conf file.
It set myhostname resolution just after files in hosts line,
for example:
hosts: files myhostname mdns4_minimal [NOTFOUND=return] dns
This choice comes from Debian commit [1] and Yocto recipe [2].
Also, nss-myhostname author suggests myhostname should be used as
a backup and appended at the end of hosts line. Both choices are valid.
Discussion on Debian bug tracker [3] gives some details on issue
that may occurs using nss-myhostname (see fqdn).
Note nss-myhostname is already included in systemd is it conflicts with it
[1] http://git.nomeata.de/?p=libnss-myhostname.git;a=commit;h=5104d7f0045df55ee8be526e8c84078750e1e0ed
[2] https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-support/nss-myhostname/nss-myhostname_0.3.bb
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756224
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
DEVELOPERS | 3 +++
package/Config.in | 1 +
package/nss-myhostname/Config.in | 11 +++++++++++
package/nss-myhostname/nss-myhostname.hash | 3 +++
package/nss-myhostname/nss-myhostname.mk | 20 ++++++++++++++++++++
5 files changed, 38 insertions(+)
create mode 100644 package/nss-myhostname/Config.in
create mode 100644 package/nss-myhostname/nss-myhostname.hash
create mode 100644 package/nss-myhostname/nss-myhostname.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 41e1b54..88c9a71 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1813,6 +1813,9 @@ F: package/openmpi/
F: package/pinentry/
F: package/trinity/
+N: Vincent Prince <vincent.prince.fr@gmail.com>
+F: package/nss-myhostname/
+
N: Vincent Stehl?? <vincent.stehle@laposte.net>
F: package/i7z/
F: package/msr-tools/
diff --git a/package/Config.in b/package/Config.in
index 3cf53ed..3ac0d63 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1426,6 +1426,7 @@ menu "Networking"
source "package/neon/Config.in"
source "package/norm/Config.in"
source "package/nss-mdns/Config.in"
+ source "package/nss-myhostname/Config.in"
source "package/nss-pam-ldapd/Config.in"
source "package/omniorb/Config.in"
source "package/openldap/Config.in"
diff --git a/package/nss-myhostname/Config.in b/package/nss-myhostname/Config.in
new file mode 100644
index 0000000..549e167
--- /dev/null
+++ b/package/nss-myhostname/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_NSS_MYHOSTNAME
+ bool "nss-myhostname"
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on !BR2_PACKAGE_SYSTEMD_MYHOSTNAME
+ help
+ Name Service Switch module for resolving the local hostname
+
+ http://0pointer.de/lennart/projects/nss-myhostname
+
+comment "nss-myhostname needs a glibc toolchain"
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/nss-myhostname/nss-myhostname.hash b/package/nss-myhostname/nss-myhostname.hash
new file mode 100644
index 0000000..dfa531c
--- /dev/null
+++ b/package/nss-myhostname/nss-myhostname.hash
@@ -0,0 +1,3 @@
+# locally computed
+sha256 2ba744ea8d578d1c57c85884e94a3042ee17843a5294434d3a7f6c4d67e7caf2 nss-myhostname-0.3.tar.gz
+sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861 LICENSE
diff --git a/package/nss-myhostname/nss-myhostname.mk b/package/nss-myhostname/nss-myhostname.mk
new file mode 100644
index 0000000..435c380
--- /dev/null
+++ b/package/nss-myhostname/nss-myhostname.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+## nss-myhostname
+#
+################################################################################
+
+NSS_MYHOSTNAME_VERSION = 0.3
+NSS_MYHOSTNAME_SITE = http://0pointer.de/lennart/projects/nss-myhostname
+NSS_MYHOSTNAME_LICENSE = LGPL-2.1+
+NSS_MYHOSTNAME_LICENSE_FILES = LICENSE
+
+define MYHOSTNAME_SET_NSSWITCH
+ $(SED) '/^hosts:/s/\s*\<myhostname\>//' \
+ -E -e 's,(^hosts:.*)(\<files\>)(.*)(\<dns\>)(.*),\1\2 myhostname \3\4\5,' \
+ $(TARGET_DIR)/etc/nsswitch.conf
+endef
+
+NSS_MYHOSTNAME_TARGET_FINALIZE_HOOKS += MYHOSTNAME_SET_NSSWITCH
+
+$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize
2018-05-29 8:00 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
2018-05-29 8:00 ` [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package Vincent Prince
@ 2018-05-29 8:50 ` Peter Korsgaard
2018-10-20 23:48 ` Peter Korsgaard
2 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2018-05-29 8:50 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
> Both nss-mdns and nss-myhostname patch nsswitch.conf file
> so it needs to be done at the final stage otherwise changes are not applied
Sorry, but that still doesn't quite explain it to me. The problem rather
seems to be that nss-mdns completely replaces the hosts: line rather
than adding mdns4 to it, so depending on ordering it may overwrite the
modifications that nss-myhostname does.
If/when we get toplevel parallel builds then we also have the issue of
parallel changes to /etc/nsswitch.conf, so the move to target-finalize
is a good thing, just not the current description.
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> ---
> package/nss-mdns/nss-mdns.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
> index 407b942..ee666c7 100644
> --- a/package/nss-mdns/nss-mdns.mk
> +++ b/package/nss-mdns/nss-mdns.mk
> @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
> $(TARGET_DIR)/etc/nsswitch.conf
> endef
> -NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
> +NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
> $(eval $(autotools-package))
> --
> 2.7.4
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize
2018-05-29 8:00 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
2018-05-29 8:00 ` [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package Vincent Prince
2018-05-29 8:50 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Peter Korsgaard
@ 2018-10-20 23:48 ` Peter Korsgaard
2 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2018-10-20 23:48 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
> Both nss-mdns and nss-myhostname patch nsswitch.conf file
> so it needs to be done at the final stage otherwise changes are not applied
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
We also need to rewrite the sed invocation so the order between
toolchain / nss-mdns / nss-myhostname doesn't matter. I've added 2
followup patches to do that and committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package
2018-05-29 8:00 ` [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package Vincent Prince
@ 2018-10-20 23:50 ` Peter Korsgaard
0 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2018-10-20 23:50 UTC (permalink / raw)
To: buildroot
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
> nss-myhostname is helpful to resolve local hostname without domain.
> For instance, if we set hostname to myboard and ping myboard
> without .local suffix, it fails if /etc/hosts stays unchanged.
> nss-myhostname modifies /etc/nsswitch.conf file.
> It set myhostname resolution just after files in hosts line,
> for example:
> hosts: files myhostname mdns4_minimal [NOTFOUND=return] dns
> This choice comes from Debian commit [1] and Yocto recipe [2].
> Also, nss-myhostname author suggests myhostname should be used as
> a backup and appended at the end of hosts line. Both choices are valid.
> Discussion on Debian bug tracker [3] gives some details on issue
> that may occurs using nss-myhostname (see fqdn).
> Note nss-myhostname is already included in systemd is it conflicts with it
> [1] http://git.nomeata.de/?p=libnss-myhostname.git;a=commit;h=5104d7f0045df55ee8be526e8c84078750e1e0ed
> [2] https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-support/nss-myhostname/nss-myhostname_0.3.bb
> [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756224
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> ---
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> package/nss-myhostname/Config.in | 11 +++++++++++
> package/nss-myhostname/nss-myhostname.hash | 3 +++
> package/nss-myhostname/nss-myhostname.mk | 20 ++++++++++++++++++++
> 5 files changed, 38 insertions(+)
> create mode 100644 package/nss-myhostname/Config.in
> create mode 100644 package/nss-myhostname/nss-myhostname.hash
> create mode 100644 package/nss-myhostname/nss-myhostname.mk
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 41e1b54..88c9a71 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1813,6 +1813,9 @@ F: package/openmpi/
> F: package/pinentry/
> F: package/trinity/
> +N: Vincent Prince <vincent.prince.fr@gmail.com>
> +F: package/nss-myhostname/
> +
> N: Vincent Stehl? <vincent.stehle@laposte.net>
> F: package/i7z/
> F: package/msr-tools/
> diff --git a/package/Config.in b/package/Config.in
> index 3cf53ed..3ac0d63 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1426,6 +1426,7 @@ menu "Networking"
> source "package/neon/Config.in"
> source "package/norm/Config.in"
> source "package/nss-mdns/Config.in"
> + source "package/nss-myhostname/Config.in"
> source "package/nss-pam-ldapd/Config.in"
> source "package/omniorb/Config.in"
> source "package/openldap/Config.in"
> diff --git a/package/nss-myhostname/Config.in b/package/nss-myhostname/Config.in
> new file mode 100644
> index 0000000..549e167
> --- /dev/null
> +++ b/package/nss-myhostname/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_NSS_MYHOSTNAME
> + bool "nss-myhostname"
> + depends on BR2_TOOLCHAIN_USES_GLIBC
> + depends on !BR2_PACKAGE_SYSTEMD_MYHOSTNAME
> + help
> + Name Service Switch module for resolving the local hostname
> +
> + http://0pointer.de/lennart/projects/nss-myhostname
> +
> +comment "nss-myhostname needs a glibc toolchain"
> + depends on !BR2_TOOLCHAIN_USES_GLIBC
The comment should also be hidden if SYSTEMD_MYHOSTNAME is enabled.
> diff --git a/package/nss-myhostname/nss-myhostname.hash b/package/nss-myhostname/nss-myhostname.hash
> new file mode 100644
> index 0000000..dfa531c
> --- /dev/null
> +++ b/package/nss-myhostname/nss-myhostname.hash
> @@ -0,0 +1,3 @@
> +# locally computed
> +sha256 2ba744ea8d578d1c57c85884e94a3042ee17843a5294434d3a7f6c4d67e7caf2 nss-myhostname-0.3.tar.gz
> +sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861 LICENSE
> diff --git a/package/nss-myhostname/nss-myhostname.mk b/package/nss-myhostname/nss-myhostname.mk
> new file mode 100644
> index 0000000..435c380
> --- /dev/null
> +++ b/package/nss-myhostname/nss-myhostname.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +## nss-myhostname
> +#
> +################################################################################
> +
> +NSS_MYHOSTNAME_VERSION = 0.3
> +NSS_MYHOSTNAME_SITE = http://0pointer.de/lennart/projects/nss-myhostname
> +NSS_MYHOSTNAME_LICENSE = LGPL-2.1+
> +NSS_MYHOSTNAME_LICENSE_FILES = LICENSE
> +
> +define MYHOSTNAME_SET_NSSWITCH
> + $(SED) '/^hosts:/s/\s*\<myhostname\>//' \
> + -E -e 's,(^hosts:.*)(\<files\>)(.*)(\<dns\>)(.*),\1\2 myhostname \3\4\5,' \
> + $(TARGET_DIR)/etc/nsswitch.conf
> +endef
I've used a simpler sed invocation which does the right thing when
called more than once and committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-10-20 23:50 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-28 8:31 [Buildroot] [PATCH v2 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
2018-05-28 8:31 ` [Buildroot] [PATCH v2 2/2] package/nss-myhostname: Add package Vincent Prince
2018-05-28 12:47 ` Peter Korsgaard
2018-05-28 19:06 ` Vincent Prince
2018-05-28 20:28 ` Peter Korsgaard
2018-05-29 8:00 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Vincent Prince
2018-05-29 8:00 ` [Buildroot] [PATCH v3 2/2] package/nss-myhostname: Add package Vincent Prince
2018-10-20 23:50 ` Peter Korsgaard
2018-05-29 8:50 ` [Buildroot] [PATCH v3 1/2] package/nss-mdns: Fix hook from post-install to finalize Peter Korsgaard
2018-10-20 23:48 ` Peter Korsgaard
2018-05-28 12:41 ` [Buildroot] [PATCH v2 " Peter Korsgaard
2018-05-28 19:08 ` Vincent Prince
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox