[Buildroot] [PATCH] lzlib: depends on lua

[Buildroot] [PATCH] lzlib: depends on lua

[gustavo.zacarias at free-electrons.com]

From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

It's missing the dependency on lua, hence when using the upcoming PPS
support its staging directory isn't populated with the required
dependencies resulting in build failure.

Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
 package/lzlib/lzlib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/lzlib/lzlib.mk b/package/lzlib/lzlib.mk
index 91f380a..f468a1c 100644
--- a/package/lzlib/lzlib.mk
+++ b/package/lzlib/lzlib.mk
@@ -6,7 +6,7 @@
 
 LZLIB_VERSION = 0.4.3
 LZLIB_SITE = $(call github,LuaDist,lzlib,$(LZLIB_VERSION))
-LZLIB_DEPENDENCIES = zlib
+LZLIB_DEPENDENCIES = lua zlib
 LZLIB_LICENSE = MIT
 LZLIB_CONF_OPTS = -DINSTALL_CMOD="/usr/lib/lua/$(LUAINTERPRETER_ABIVER)" \
 	-DINSTALL_LMOD="/usr/share/lua/$(LUAINTERPRETER_ABIVER)"
-- 
2.10.2

[Buildroot] [PATCH] lzlib: depends on lua

[Peter Korsgaard]

>>>>> "gustavo" == gustavo zacarias <gustavo.zacarias@free-electrons.com> writes:

 > From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
 > It's missing the dependency on lua, hence when using the upcoming PPS
 > support its staging directory isn't populated with the required
 > dependencies resulting in build failure.

 > Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] lzlib: depends on lua

[Thomas Petazzoni]

Hello,

On Wed, 21 Dec 2016 17:22:44 -0300, gustavo.zacarias at free-electrons.com
wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> It's missing the dependency on lua, hence when using the upcoming PPS
> support its staging directory isn't populated with the required
> dependencies resulting in build failure.
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

I'm probably missing something, but even without PPS we should have
seen build failures of this package, no?

Or because lzlib is after lua in alphabetic ordering, and nothing makes
lzlib built before lua due to dependencies, we were lucky enough?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] lzlib: depends on lua

[Gustavo Zacarias]

On 21/12/16 19:48, Thomas Petazzoni wrote:

> I'm probably missing something, but even without PPS we should have
> seen build failures of this package, no?
>
> Or because lzlib is after lua in alphabetic ordering, and nothing makes
> lzlib built before lua due to dependencies, we were lucky enough?
>
> Thanks!
>
> Thomas

Hi.
I didn't try to reproduce this outside PPS, but i'm inclined to side 
with your second theory, the failure looks like:

*****
-- The C compiler identification is GNU 4.8.3
-- Check for working C compiler: 
/home/gustavoz/b/pps3/output/host/usr/bin/arm-none-linux-gnueabi-gcc
-- Check for working C compiler: 
/home/gustavoz/b/pps3/output/host/usr/bin/arm-none-linux-gnueabi-gcc -- 
works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
DIST_NAME: lzlib
DIST_VERSION: 0.4.2
DIST_LICENSE: MIT/X11
DIST_AUTHOR: Tiago Dionizio
DIST_MAINTAINER: Peter Draho?
DIST_URL: http://luaforge.net/projects/lzlib/
DIST_DESC: Lua bindings to the ZLib compression library
DIST_DEPENDS:
CMake Error at 
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
   Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR)
Call Stack (most recent call first):
   /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:388 
(_FPHSA_FAILURE_MESSAGE)
   cmake/FindLua.cmake:113 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
   cmake/lua.cmake:116 (find_package)
   cmake/lua.cmake:163 (_lua_module_helper)
   CMakeLists.txt:15 (install_lua_module)


-- Configuring incomplete, errors occurred!
See also 
"/home/gustavoz/b/pps3/output/build/lzlib-0.4.3/CMakeFiles/CMakeOutput.log".
package/pkg-generic.mk:206: recipe for target 
'/home/gustavoz/b/pps3/output/build/lzlib-0.4.3/.stamp_configured' failed
make: *** 
[/home/gustavoz/b/pps3/output/build/lzlib-0.4.3/.stamp_configured] Error 1
*****

Even if lua was built i can reproduce this after cleaning the lzlib 
package staging and build directories.

Regards.

[Buildroot] [PATCH] lzlib: depends on lua

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Wed, 21 Dec 2016 17:22:44 -0300, gustavo.zacarias at free-electrons.com
 > wrote:
 >> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
 >> 
 >> It's missing the dependency on lua, hence when using the upcoming PPS
 >> support its staging directory isn't populated with the required
 >> dependencies resulting in build failure.
 >> 
 >> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

 > I'm probably missing something, but even without PPS we should have
 > seen build failures of this package, no?

 > Or because lzlib is after lua in alphabetic ordering, and nothing makes
 > lzlib built before lua due to dependencies, we were lucky enough?

Yes, I think it purely worked by chance because of the alphabetical
ordering.

-- 
Bye, Peter Korsgaard