Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libabseil-cpp: require wchar
@ 2026-10-05  9:20 Michael Nosthoff via buildroot
  2026-10-05 16:33 ` Baruch Siach via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2026-10-05  9:20 UTC (permalink / raw)
  To: buildroot

absl::StrFormat() unconditionally includes <cwchar>. So a toolchain
with wchar support is required.

Fixes:
https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 package/libabseil-cpp/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libabseil-cpp/Config.in b/package/libabseil-cpp/Config.in
index feb4963042..739e6d279e 100644
--- a/package/libabseil-cpp/Config.in
+++ b/package/libabseil-cpp/Config.in
@@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	default y if BR2_sh
 	default y if BR2_sparc || BR2_sparc64
 	default y if BR2_x86_64
+	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
 	# absl/base/internal/direct_mmap.h only implements DirectMmap()
 	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/libabseil-cpp: require wchar
  2026-10-05  9:20 [Buildroot] [PATCH] package/libabseil-cpp: require wchar Michael Nosthoff via buildroot
@ 2026-10-05 16:33 ` Baruch Siach via buildroot
  2026-10-05 19:18   ` Michael Nosthoff via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach via buildroot @ 2026-10-05 16:33 UTC (permalink / raw)
  To: Michael Nosthoff via buildroot

Hi Michael,

On Mon, Oct 05 2026, Michael Nosthoff via buildroot wrote:
> absl::StrFormat() unconditionally includes <cwchar>. So a toolchain
> with wchar support is required.
>
> Fixes:
> https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  package/libabseil-cpp/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/libabseil-cpp/Config.in b/package/libabseil-cpp/Config.in
> index feb4963042..739e6d279e 100644
> --- a/package/libabseil-cpp/Config.in
> +++ b/package/libabseil-cpp/Config.in
> @@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
>  	default y if BR2_sh
>  	default y if BR2_sparc || BR2_sparc64
>  	default y if BR2_x86_64
> +	depends on BR2_USE_WCHAR

New dependencies must propagate to all reverse dependencies,
recursively.

Also, dependencies comment below needs update.

baruch

>  	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
>  	# absl/base/internal/direct_mmap.h only implements DirectMmap()
>  	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot]  [PATCH] package/libabseil-cpp:  require wchar
  2026-10-05 16:33 ` Baruch Siach via buildroot
@ 2026-10-05 19:18   ` Michael Nosthoff via buildroot
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2026-10-05 19:18 UTC (permalink / raw)
  To: Baruch Siach; +Cc: Michael Nosthoff via buildroot

Hi Baruch,

On Monday, October 05, 2026 18:33 CEST, Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Michael,
> 
> On Mon, Oct 05 2026, Michael Nosthoff via buildroot wrote:
> > absl::StrFormat() unconditionally includes <cwchar>. So a toolchain
> > with wchar support is required.
> >
> > Fixes:
> > https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//
> >
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> > ---
> >  package/libabseil-cpp/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/package/libabseil-cpp/Config.in b/package/libabseil-cpp/Config.in
> > index feb4963042..739e6d279e 100644
> > --- a/package/libabseil-cpp/Config.in
> > +++ b/package/libabseil-cpp/Config.in
> > @@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
> >  	default y if BR2_sh
> >  	default y if BR2_sparc || BR2_sparc64
> >  	default y if BR2_x86_64
> > +	depends on BR2_USE_WCHAR
> 
> New dependencies must propagate to all reverse dependencies,
> recursively.

The added depends is on the ARCH_SUPPORTS which should already be propagated.
Maybe that's not the right place?

> 
> Also, dependencies comment below needs update.
> 
thats's right.

Michael

> baruch
> 
> >  	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
> >  	# absl/base/internal/direct_mmap.h only implements DirectMmap()
> >  	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback
> 
> -- 
>                                                      ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-05 19:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-05  9:20 [Buildroot] [PATCH] package/libabseil-cpp: require wchar Michael Nosthoff via buildroot
2026-10-05 16:33 ` Baruch Siach via buildroot
2026-10-05 19:18   ` Michael Nosthoff via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox