[Buildroot] [PATCH 1/1] package/gstreamer1/gst1-vaapi: fix wayland build

[Buildroot] [PATCH 1/1] package/gstreamer1/gst1-vaapi: fix wayland build

[Fabrice Fontaine]

wayland-protocols is a mandatory dependency with wayland since
bump to version 1.22.0 in commit
33d4c226e582f6c0086431c4d9154e462cb3cf34 and
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/3c713cc16ee1d374213cb2b47a3127e14e5ff8a5:

Run-time dependency wayland-protocols found: NO (tried pkgconfig and cmake)

../output-1/build/gst1-vaapi-1.22.0/meson.build:111:0: ERROR: Dependency "wayland-protocols" not found, tried pkgconfig and cmake

Fixes: 33d4c226e582f6c0086431c4d9154e462cb3cf34
 - http://autobuild.buildroot.org/results/b5e79d4e10fdf24c3fd43ab742d9d14a5d07824b
 - http://autobuild.buildroot.org/results/ad624cd11d5a1b3346974000ae2b61f4261af02c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gstreamer1/gst1-vaapi/Config.in     | 1 +
 package/gstreamer1/gst1-vaapi/gst1-vaapi.mk | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/gstreamer1/gst1-vaapi/Config.in b/package/gstreamer1/gst1-vaapi/Config.in
index a1062097ed..d6a1542ad3 100644
--- a/package/gstreamer1/gst1-vaapi/Config.in
+++ b/package/gstreamer1/gst1-vaapi/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_GST1_VAAPI
 	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
 	select BR2_PACKAGE_GST1_PLUGINS_BAD # gstreamer-codecparsers
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS if BR2_PACKAGE_WAYLAND
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXRANDR if BR2_PACKAGE_XORG7
 	help
diff --git a/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk b/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
index 4b04d1bb72..d934bab233 100644
--- a/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
+++ b/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
@@ -39,6 +39,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_WAYLAND),y)
 GST1_VAAPI_CONF_OPTS += -Dwayland=enabled
+GST1_VAAPI_DEPENDENCIES += wayland wayland-protocols
 else
 GST1_VAAPI_CONF_OPTS += -Dwayland=disabled
 endif
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-vaapi: fix wayland build

[Arnout Vandecappelle via buildroot]

On 14/02/2024 20:58, Fabrice Fontaine wrote:
> wayland-protocols is a mandatory dependency with wayland since
> bump to version 1.22.0 in commit
> 33d4c226e582f6c0086431c4d9154e462cb3cf34 and
> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/3c713cc16ee1d374213cb2b47a3127e14e5ff8a5:
> 
> Run-time dependency wayland-protocols found: NO (tried pkgconfig and cmake)
> 
> ../output-1/build/gst1-vaapi-1.22.0/meson.build:111:0: ERROR: Dependency "wayland-protocols" not found, tried pkgconfig and cmake
> 
> Fixes: 33d4c226e582f6c0086431c4d9154e462cb3cf34
>   - http://autobuild.buildroot.org/results/b5e79d4e10fdf24c3fd43ab742d9d14a5d07824b
>   - http://autobuild.buildroot.org/results/ad624cd11d5a1b3346974000ae2b61f4261af02c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/gstreamer1/gst1-vaapi/Config.in     | 1 +
>   package/gstreamer1/gst1-vaapi/gst1-vaapi.mk | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-vaapi/Config.in b/package/gstreamer1/gst1-vaapi/Config.in
> index a1062097ed..d6a1542ad3 100644
> --- a/package/gstreamer1/gst1-vaapi/Config.in
> +++ b/package/gstreamer1/gst1-vaapi/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_GST1_VAAPI
>   	select BR2_PACKAGE_LIBDRM
>   	select BR2_PACKAGE_GST1_PLUGINS_BASE
>   	select BR2_PACKAGE_GST1_PLUGINS_BAD # gstreamer-codecparsers
> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS if BR2_PACKAGE_WAYLAND
>   	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
>   	select BR2_PACKAGE_XLIB_LIBXRANDR if BR2_PACKAGE_XORG7
>   	help
> diff --git a/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk b/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
> index 4b04d1bb72..d934bab233 100644
> --- a/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
> +++ b/package/gstreamer1/gst1-vaapi/gst1-vaapi.mk
> @@ -39,6 +39,7 @@ endif
>   
>   ifeq ($(BR2_PACKAGE_WAYLAND),y)
>   GST1_VAAPI_CONF_OPTS += -Dwayland=enabled
> +GST1_VAAPI_DEPENDENCIES += wayland wayland-protocols
>   else
>   GST1_VAAPI_CONF_OPTS += -Dwayland=disabled
>   endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-vaapi: fix wayland build

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > wayland-protocols is a mandatory dependency with wayland since
 > bump to version 1.22.0 in commit
 > 33d4c226e582f6c0086431c4d9154e462cb3cf34 and
 > https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/3c713cc16ee1d374213cb2b47a3127e14e5ff8a5:

 > Run-time dependency wayland-protocols found: NO (tried pkgconfig and cmake)

 > ../output-1/build/gst1-vaapi-1.22.0/meson.build:111:0: ERROR:
 > Dependency "wayland-protocols" not found, tried pkgconfig and cmake

 > Fixes: 33d4c226e582f6c0086431c4d9154e462cb3cf34
 >  - http://autobuild.buildroot.org/results/b5e79d4e10fdf24c3fd43ab742d9d14a5d07824b
 >  - http://autobuild.buildroot.org/results/ad624cd11d5a1b3346974000ae2b61f4261af02c

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot