Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name
@ 2023-07-16 16:37 Bernd Kuhls
  2023-07-21 21:31 ` Thomas Petazzoni via buildroot
  2023-08-29 16:46 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2023-07-16 16:37 UTC (permalink / raw)
  To: buildroot

In the current state this package install libyaml-cppd.so due to "d"
being added because the variable CMAKE_DEBUG_POSTFIX is not set:
https://github.com/jbeder/yaml-cpp/blob/master/CMakeLists.txt#L137

This breaks the build of mongodb which expects the library name
libyaml-cpp.so:
https://github.com/mongodb/mongo/blob/master/SConstruct#L5090

Fixes:
http://autobuild.buildroot.net/results/304/3044d040dec090a2f528a96f201d4e554f6779b4/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/yaml-cpp/yaml-cpp.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/yaml-cpp/yaml-cpp.mk b/package/yaml-cpp/yaml-cpp.mk
index d65298ffb9..367df27ff1 100644
--- a/package/yaml-cpp/yaml-cpp.mk
+++ b/package/yaml-cpp/yaml-cpp.mk
@@ -13,6 +13,7 @@ YAML_CPP_CPE_ID_VENDOR = yaml-cpp_project
 
 # Disable testing and parse tools
 YAML_CPP_CONF_OPTS += \
+	-DCMAKE_DEBUG_POSTFIX="" \
 	-DYAML_CPP_BUILD_TESTS=OFF \
 	-DYAML_CPP_BUILD_TOOLS=OFF
 
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name
  2023-07-16 16:37 [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name Bernd Kuhls
@ 2023-07-21 21:31 ` Thomas Petazzoni via buildroot
  2023-08-29 16:46 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-21 21:31 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

On Sun, 16 Jul 2023 18:37:07 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> In the current state this package install libyaml-cppd.so due to "d"
> being added because the variable CMAKE_DEBUG_POSTFIX is not set:
> https://github.com/jbeder/yaml-cpp/blob/master/CMakeLists.txt#L137
> 
> This breaks the build of mongodb which expects the library name
> libyaml-cpp.so:
> https://github.com/mongodb/mongo/blob/master/SConstruct#L5090
> 
> Fixes:
> http://autobuild.buildroot.net/results/304/3044d040dec090a2f528a96f201d4e554f6779b4/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/yaml-cpp/yaml-cpp.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name
  2023-07-16 16:37 [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name Bernd Kuhls
  2023-07-21 21:31 ` Thomas Petazzoni via buildroot
@ 2023-08-29 16:46 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-08-29 16:46 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > In the current state this package install libyaml-cppd.so due to "d"
 > being added because the variable CMAKE_DEBUG_POSTFIX is not set:
 > https://github.com/jbeder/yaml-cpp/blob/master/CMakeLists.txt#L137

 > This breaks the build of mongodb which expects the library name
 > libyaml-cpp.so:
 > https://github.com/mongodb/mongo/blob/master/SConstruct#L5090

 > Fixes:
 > http://autobuild.buildroot.net/results/304/3044d040dec090a2f528a96f201d4e554f6779b4/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-29 16:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-16 16:37 [Buildroot] [PATCH 1/1] package/yaml-cpp: fix library name Bernd Kuhls
2023-07-21 21:31 ` Thomas Petazzoni via buildroot
2023-08-29 16:46 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox